enricopolanski / functional-programming Goto Github PK

since fp-ts (v3) has been merged into the Effect ecosystem it would be great to have this course rewritten using Effect

Have you thought about the structure related to translation?

Instead of

A function that returns errors or throws exceptions is an example of a partial function.

Maybe we should remove the returns error part:

A function that throws exceptions is an example of a partial function.

If a function returns an error it may still be pure.

I understand this is a translation from another repo, but from the text I couldn't fully understand what code properties mean. We have below in the text:

In functional programming, where there's an emphasis on code properties rather than implementation details, the map operation is interesting due to its limitations

I have some guesses but What is the actual definition of term Code Property?

Looking at the sentence:

Please note that in order for f and g to combine, the domain of f has to be included in the codomain of g.

Shouldn't it be:

Please note that in order for f and g to combine, the codomain of g has to be included in the domain of f.

That way for any possible input x then there is an element g(x) is domain of f. (Codomain of g has fewer or equal number of elements than domain of f)

Or is there a gitbook but no link to it?

Really great work though! <3

Should be const idB = (n: number): number => n ?

Suggestion: Would it be possible for to make a youtube presentation of this repo? Thank's for publishing!

Can you add answers to the quiz questions that pop up throughout the file?

For instance, I'm at this section "Order-derivable Semigroups" where there's this quiz question: Quiz. Why is it so important that number is a total order?. As a reader I do have some answer to that question, but I don't know if that answer is correct and have no way to validate it.

Instead of sentence:

Given a type A, all endomorphisms defined on A are a monoid

isn't it more correct to say:

Given a type A, all endomorphisms defined on A under function composition operation are a monoid

Because semigroups are defined on pair of type A and operation on type A.