enjin / platform-csharp-sdk Goto Github PK

With the new Managed Wallet feature one of the most useful (and likely most used) queries will be 'return all Tokens belonging to this list of Colletions in this Player's managed wallet' . Executing this basic query today requires ALOT of framents/sub queries either starting with GetWallet or GetTokens.

Suggestion 1: Add a .SetExternalID and/or a .SetAddress to the GetToken API request. This will still require a 2-3 level dive in Edges/Nodes to get the Tokens but atleast only for the requested ones.

Suggestion 2: Add a .SetCollections to GetWallet as this would also give the desired result. The good thing here is that the returned Tokens will only be one level down in the Edge/Node tree.

Suggestion 3. Create a new query altogether GetTokensInWallet (or something to that effect) with a .SetCollections and SetExternalID/SetAddress params and then return a clean Connection.

The issue with the current implementation is that SendCreateWallet will return true even if the resulting player wallet as no Address assigned. This means that expected workflow for creating a managed player and immediately assigning them to a FuelTank will fail (SendCreateWallet .success -> GetWallet.success -> AddAccount using returned wallet.Account.Address) If you add a wait 3secs or so between succesfull SendCreateWallet and GetWallet you might get lucky and have the Address field field filled out. This not ideal.

Solution 1. SendCreateWallet only returns true when Wallet has been completely formed (with Address and Public Key).
Solution 2. SendCreateWallet returns a Transaction for the Wallet creation (with Address and Public Key).

Since creating a managed player and adding a FuelTank ref is expected to be the most common scenario why not do both in one call
Solution 3. SendCreateWallet.SetTankId().SetExternalId() for a combined create managed wallet + add fueltank. Returning a Transaction.