Comments (4)
I can't quite agree on this one, there is stuff in there that is standardized and things that aren't, so there are things that have to be followed.
If people think the create function is part of the standard, they didn't read the standard.
We could add comments to such things to say "this is a non-standard function".
from erc-1155.
Technically minting is standardized:
When minting/creating tokens, the _from argument MUST be set to 0x0 (i.e. zero address). See “Minting/creating and burning/destroying rules”.
Also see "Minting/creating and burning/destroying rules:".
How you write your implementation around those rules is not standardized but it shouldn't be given it's an API.
from erc-1155.
Yes, there are rules that apply to minting.
The function signature:
function create(uint256 _initialSupply, string calldata _uri) external returns(uint256 _id);
is not standardized.
And seeing the function in a file named ERC1155... may lead somebody to think it is.
from erc-1155.
Also please email me, I lost your email
from erc-1155.
Related Issues (17)
- It's not safe HOT 1
- Inline ASM Required? Can't support in Vyper HOT 4
- A question about function create() and mint() in ERC1155Mintable.sol HOT 3
- Could not find suitable configuration file. HOT 5
- Cannot read property 'match' of undefined
- Why does ERC1155MixedFungibleMintable needs store the type of both fungible and non fundgibl HOT 3
- Cannot use import statement outside a module HOT 2
- What is the difference between 'create' and 'mint' functions in ERC1155Mintable.sol
- Replace the EIP-1538 Implementation with EIP-2535, the Diamond Standard
- expectThrow.js unexpected token issue HOT 1
- id from mintNonFungible duplicating, skips even numbers
- ERC1155Mintable does not follow the metadata standard
- ERC1155 Questions about ID, Metadata and uniqueness
- How to withdraw tokens from ERC1155 contract?
- Vulnerability: Nonce must be limited to 2^127 in split bit design
- Spend allowance
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from erc-1155.