Inline ASM Required? Can't support in Vyper about erc-1155 HOT 4 CLOSED

@scherrey would it be helpful if I changed this impl to not use inline asm? I guess it would.

It was used this way when we had accept/reject logic for the receiver but that is gone now. It is either accept or revert now (in a non hybrid solution).

from erc-1155.

I updated the code at https://github.com/pixowl/thesandbox-contracts to fit the spec

@scherrey Feel free to ask any question

from erc-1155.

It's just pulling the return value out if it was returned. Here a lowlevel .call is being used rather than a straight function call so that the call to onERC1155Received doesn't revert the transaction automatically see https://solidity.readthedocs.io/en/v0.5.8/control-structures.html#error-handling-assert-require-revert-and-exceptions

In this ref function that is not really needed, it could be reverted straight away but as you can see in the 1155/721 hybrid this can be a useful technique (as this code wants to continue if it is also an erc721 but the .call fails). Note: this is not updated to latest 1155 spec by the looks of it, maybe @wighawag can let us know when it plans to be: https://github.com/pixowl/thesandbox-contracts/blob/master/src/Asset/ERC1155ERC721.sol#L679

I'm not sure if this type of thing is possible with Vyper I've never looked, but if you don't need hybridity it should be fine to just call the on1155Received function and require the return value is exact.

from erc-1155.

Altered: 6147143

from erc-1155.