Giter Club home page Giter Club logo

Comments (6)

JiriZidek avatar JiriZidek commented on July 18, 2024

Feel free to use DeepFreeze instead...

from immutableassign.

geirsagberg avatar geirsagberg commented on July 18, 2024

I did something like this:

import iassign from 'immutable-assign'
import DeepFreeze from 'deep-freeze'

export const deepFreeze = obj => iassign.freeze ? DeepFreeze(obj) : obj

Would you be opposed to a PR with such a wrapper included in ImmutableAssign?

from immutableassign.

JiriZidek avatar JiriZidek commented on July 18, 2024

Why create dependency on DeepFreeze, when benefit (freezing is usefull for developer only, in production it is no-no) is so small ? Moreover you can add such trival wrapper to your project as single function without forcing all consumers of iassign to bloat their code with DeepFreeze?

from immutableassign.

JiriZidek avatar JiriZidek commented on July 18, 2024

Now I see that DeepFreeze is in current version required anyway...

from immutableassign.

engineforce avatar engineforce commented on July 18, 2024

Hi geirsagberg, I am not a fan of re-exporting of another module, which is antipattern. The better way is that you create your own module (called immutable-util for example), which export iassign() and deepFreeze(). And make your application codes depending on the new module, so you can swap out iassign() in the future if needed.

from immutableassign.

geirsagberg avatar geirsagberg commented on July 18, 2024

from immutableassign.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.