Giter Club home page Giter Club logo

Comments (12)

danieloi avatar danieloi commented on June 21, 2024 2

Hey guys, so sorry for being late, cannot check the issue of the hold menu for a long time due to my personal occupation. @EvanBacon thanks a lot for the issue and fix 🫢🏼 @SohelIslamImran I'll take a look in a day and puvlish new version.

Please fix them as you said ASAP. We are working on a production project, we need to use it if all these issues are resolved.

Hey guys, so sorry for being late, cannot check the issue of the hold menu for a long time due to my personal occupation. @EvanBacon thanks a lot for the issue and fix 🫢🏼 @SohelIslamImran I'll take a look in a day and puvlish new version.

Please fix them as you said ASAP. We are working on a production project, we need to use it if all these issues are resolved.

Unless you're contributing significantly financially to an open source project, to use words like ASAP the way you're doing here in text format comes off as very unpleasant.

Saw you use the same tone in other issues.

Take it easy buddy

from react-native-hold-menu.

enesozturk avatar enesozturk commented on June 21, 2024 1

Hey guys, so sorry for being late, cannot check the issue of the hold menu for a long time due to my personal occupation. @EvanBacon thanks a lot for the issue and fix 🫢🏼
@SohelIslamImran I'll take a look in a day and puvlish new version.

from react-native-hold-menu.

enesozturk avatar enesozturk commented on June 21, 2024 1

Yeah, today I was working on hold menu and realized it, there are also some other issues I need to solve, blur background looks related to dependencies. I'll handle it.

from react-native-hold-menu.

enesozturk avatar enesozturk commented on June 21, 2024 1

Published a new release. The icon rendering issue should be fixed now. Along with the same PR, the following issues should be fixed:

  • Android backdrop gesture handler was not working
  • Icon colors were not changing as the theme change
  • Blur view was not working on iOS

Awesome, lets goo πŸ’―

from react-native-hold-menu.

SohelIslamImran avatar SohelIslamImran commented on June 21, 2024

Facing the same issue. Can't use icon: () => <Icon name="delete" size={18} /> as mentioned in this example https://enesozturk.github.io/react-native-hold-menu/docs/examples#list-with-icons

from react-native-hold-menu.

SohelIslamImran avatar SohelIslamImran commented on June 21, 2024

Can't you create an RP? @EvanBacon

from react-native-hold-menu.

SohelIslamImran avatar SohelIslamImran commented on June 21, 2024

Please fix this issue ASAP @enesozturk

from react-native-hold-menu.

SohelIslamImran avatar SohelIslamImran commented on June 21, 2024

Also, How can I change the Backdrop background color?

from react-native-hold-menu.

SohelIslamImran avatar SohelIslamImran commented on June 21, 2024

Hey guys, so sorry for being late, cannot check the issue of the hold menu for a long time due to my personal occupation. @EvanBacon thanks a lot for the issue and fix 🫢🏼 @SohelIslamImran I'll take a look in a day and puvlish new version.

Thank you so much

from react-native-hold-menu.

SohelIslamImran avatar SohelIslamImran commented on June 21, 2024

@enesozturk Also, Please try to make this package more customizable (styles, state, variables, props, etc)

from react-native-hold-menu.

SohelIslamImran avatar SohelIslamImran commented on June 21, 2024

It doesn't have blurry background (Backdrop) on IOS as shown in the examples pictures @enesozturk

from react-native-hold-menu.

SohelIslamImran avatar SohelIslamImran commented on June 21, 2024

Hey guys, so sorry for being late, cannot check the issue of the hold menu for a long time due to my personal occupation. @EvanBacon thanks a lot for the issue and fix 🫢🏼 @SohelIslamImran I'll take a look in a day and puvlish new version.

Please fix them as you said ASAP. We are working on a production project, we need to use it if all these issues are resolved.

from react-native-hold-menu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.