Crash with latest version of reanimated2 about react-native-hold-menu HOT 10 CLOSED

https://github.com/software-mansion/react-native-reanimated/releases/tag/2.1.0
It is here 🔥 Lets try guys 🤓

from react-native-hold-menu.

@enesozturk it is ok. Thank you very much!!! looking forwards to the function of switching from longPress to one click(onPress) able! ^_^

from react-native-hold-menu.

Your design is so beautiful! This is my favorite react native program ! Thank you very much!!!!!

from react-native-hold-menu.

The crash is indeed fixed. 👍

The example app is working as expected.

Quick question, do we need to save the whole onPress callback in shared value? Could it be on the context instead?

from react-native-hold-menu.

Hi @zhigang1992, could your provide other details like code snippets? How did you implement it? I will try to reporduce it.

from react-native-hold-menu.

I'm running the example app, with reanimated upgraded to 2.0.1

from react-native-hold-menu.

This is what I had been seeing myself as per our previous discussion in #11 @enesozturk Perhaps it would be worth opening a new issue in the Reanimated repo?

from react-native-hold-menu.

Yeah, it seems like it's not released

software-mansion/react-native-reanimated#1874 (comment)

from react-native-hold-menu.

Yeah, it seems like it's not released

software-mansion/react-native-reanimated#1874 (comment)

Oh this is good to know 😄 As I guessed here it is not included in v2.0.1 as I understood. Will wait the new release. But at the end, it is not good to force people to use latest version of Reanimated..

from react-native-hold-menu.

The crash is indeed fixed. 👍

The example app is working as expected.

Quick question, do we need to save the whole onPress callback in shared value? Could it be on the context instead?

That is great to know 👍🏽 Good question. It is important to move list data super fast because for example in Whatsapp, message sender and receiver has different list values. That is why shared value is needed. It is already in context actually.

from react-native-hold-menu.