Giter Club home page Giter Club logo

Comments (12)

shivanibhanwal avatar shivanibhanwal commented on September 3, 2024 1

On I forgot to mention I am taking the approach of list_group but I am doing it below the List item, not on right @enderahmetyurt
which is same as your example difference is I am not using accordion

from gistcatch.

enderahmetyurt avatar enderahmetyurt commented on September 3, 2024 1

Great. It looks nice @shivanibhanwal I will be check later. Thanks 🙏

from gistcatch.

shivanibhanwal avatar shivanibhanwal commented on September 3, 2024

Yes @enderahmetyurt I have planned, already started with that I think by tomorrow I should be able to do that. My assumption is to just get the gist content and display in the content section on click of list view.

from gistcatch.

enderahmetyurt avatar enderahmetyurt commented on September 3, 2024

Yes. You can do it with your assumption. I want to show an example of what I really want. https://getbootstrap.com/docs/4.0/components/collapse/ When the user clicks the gist name on the list and open a div which includes gist codes and then click again the link div should be close.

from gistcatch.

shivanibhanwal avatar shivanibhanwal commented on September 3, 2024

@enderahmetyurt 👍 we thought same thing I planned it this way https://getbootstrap.com/docs/4.0/components/list-group/#javascript-behavior

from gistcatch.

enderahmetyurt avatar enderahmetyurt commented on September 3, 2024

No. I guess we should do toggle below the gist link. Because opening it left of the link cannot be fit in a div or it should be smaller. Can you do it as I mentioned?

from gistcatch.

shivanibhanwal avatar shivanibhanwal commented on September 3, 2024

@enderahmetyurt I have completed implementation of show/hide. Attached is the screenshot. Only thing which I have some issue is with the Content displaying as it comes in gist editor because every file is of different format e.g .rb, .md
I tried Redcarpet Markdown and Rouge syntax highlighter, but markdown changes it to HTML which is not case with all the gist. I explored Rouge but need to see if we can do that based on just file extension with Rouge. But for now I am committing changes. Let me know your thought
screen shot 2018-10-17 at 9 21 07 pm

from gistcatch.

enderahmetyurt avatar enderahmetyurt commented on September 3, 2024

Thank you @shivanibhanwal but it's not working properly.
screen shot 2018-10-17 at 22 52 27

I want to make some color with Redcarpet. Gist API gives the extension of the gist. It doesn't make any sense with raw html.

from gistcatch.

shivanibhanwal avatar shivanibhanwal commented on September 3, 2024

@enderahmetyurt Markdown redcarpet will not help with syntax highlitghter only that case be changed. I need to explore that more.

from gistcatch.

enderahmetyurt avatar enderahmetyurt commented on September 3, 2024

Okay. Could you fix the accordion problem?

from gistcatch.

shivanibhanwal avatar shivanibhanwal commented on September 3, 2024

Hi, @enderahmetyurt I have fixed it completely will be raising PR in a few minutes. It has many cases to handle. The accordion issue was because one gist can have Many Files in it. So I have handled it too
screen shot 2018-10-18 at 7 40 34 pm
screen shot 2018-10-18 at 7 40 50 pm

from gistcatch.

shivanibhanwal avatar shivanibhanwal commented on September 3, 2024

@enderahmetyurt it is complete now you can check the changes and let me know.

from gistcatch.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.