encode / starlette-example Goto Github PK

Is this project intended to be a single app example, or could it potentially include multiple examples of various features/usage with other libs? I am sitting on enough experiments and test code that I could probably pick out some useful things to PR in either case.

I'm in a conda environment and tried running
scripts/install after git clone https://github.com/encode/starlette-example.git cd starlette-example

and got

scripts/install: line 1: virtualenv: command not found
scripts/install: line 2: venv/bin/pip: No such file or directory

I face the following error.

Traceback (most recent call last):
  File "app.py", line 4, in <module>
    from starlette.templating import Jinja2Templates
ModuleNotFoundError: No module named 'starlette.templating'

The starlette was installed using conda but the templating module is not present in that.

Add pre-commit config and GitHub Action to prevent code formatting issues on pull requests.

E. g. .pre-commit-config.yaml

repos:
  - repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v4.3.0
    hooks:
      - id: trailing-whitespace
      - id: end-of-file-fixer

.github/workflows/main.yml

name: CI
on:
  push
jobs:
  lint:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-python@v4
        with:
          python-version: "3.7"
      - uses: pre-commit/[email protected]
        if: always()

When I deploy the app on Heroku [1], all the url_fors in base.html give me URLs with http instead of https, which triggers a Mixed Content error. When I run uvicorn locally using ssl_keyfile and ssl_certfile, I don't get this problem.

Links:
[1] https://aqueous-waters-64836.herokuapp.com/

Could we have this flagged at a template repository? It will let users generate new repositories with the same directory structure and files.

On heroku, using

web: gunicorn app:app

in the Procfile leads to an error:

Traceback (most recent call last):
File "/app/.heroku/python/lib/python3.6/site-packages/gunicorn/workers/sync.py", line 135, in handle
self.handle_request(listener, req, client, addr)
File "/app/.heroku/python/lib/python3.6/site-packages/gunicorn/workers/sync.py", line 176, in handle_request
respiter = self.wsgi(environ, resp.start_response)
TypeError: __call__() takes 2 positional arguments but 3 were given

It'd be nice to add a tests.py to demonstrate how to write tests against this app.

Pull requests would be very welcome! 😎