emosewaj / papibot Goto Github PK

What I expected to happen:
The bot deletes the command after it was executed.

What actually happened:
The bot crashed.

How to replicate:

1. Remove "Manage Messages" permission from the bot
2. Use the //say command or any command that deletes a message

Whenever Discord has one of it's outages, the bot beliefes it was removed and then readded to several guilds, making it reintroduce itself.

Fix: Check new server against list of known servers and only send introduction if server is unknown.

I actually noticed that while trying to change the channel myself lol, oops xd

The servers.db file stores data that is not needed for normal operation.

Issues

1. Table: prefixes
   This table stores every single guild even when no custom prefix was set.
2. Table: prefixes
   This table stores the names of the guilds together with their ID. This may be a risk to privacy.

Solutions

1. Reprogram the getPrefix function in /depen/config.js to return the default prefix if no prefix/no entry was returned from the database. This way only custom prefixes have to be saved.
2. Since the name column is not used in regular operation, it is save to assume that its deletion should create no issues.

Title pre-11.01.2018: //play random sometimes won't play the song but announce that it's being played

Expected behaviour: The announced song is played.

Actual behaviour: Song seems to not be played in random cases.

Workaround: none

To reproduce:

1. Send "//"
2. Receive "No such command!" as a response

The //broadcast command does not send the message to all servers as required. Reason for that is probably rate limiting, a 1s or 1.5s delay between sending the messages might help here, but I'm not sure.

Also make sure it checks for the new category channels.

The guild list //getguilds outputs is over the maximum character limit and therefore not sent.

Workaround: Send multiple messages/pages.

Caused by the function being run in the Client.on("ready") block, causes duplicate entries in the help system.

Should be fixable by moving the function into init().

How to reproduce:

1. Add the bot to a server
2. Enter either "//" or "//non-existant command"
3. Receive "@yourtag" as a reply

The current images are quite shitty and only really work on a white background, need some others, maybe original ones.

Not urgent.

To reproduce:
//pokedex move tailwind
Power and Accuracy will be null.

To fix:
Edit line 131 and line 132 to parse null values.

If the bot has fewer messages sent than trying to delete, the bot will return the following error:
messages[i]: The set already contains this value
where i is an empty array entry.

Example:
Error while cleaning up:
DiscordAPIError: Invalid Form Body
messages[15]: The set already contains this value
messages[16]: The set already contains this value
messages[17]: The set already contains this value
messages[18]: The set already contains this value
messages[19]: The set already contains this value

The bot will return the following error, if it does not have the Manage Messages permission:
Error while cleaning up:
DiscordAPIError: Missing Permissions

This is due to bulk delete being disabled when these permissions are missing.

Workaround: Recursively delete messages manually.