emmerich / cordova-build Goto Github PK

There's an issue with splash screens on Cordova 2.7.0 which is preventing me from upgrading. Currently using 2.5.0.

See: https://issues.apache.org/jira/browse/CB-3337

The plugin should finish the process off by producing a built application in a bin folder.

Access declarations are a little bit more complicated now. PGB doesn't just allow access to everything anymore, it's more platform dependent. Follow what they do.

See: https://build.phonegap.com/blog/access-tags

At the moment it's hardcoded to 2.5.0 in ApplicationContext

In PGB, you can specify a property named "permissions" and set it to "none" to remove all permissions. I need to do some testing on this, namely:

• What happens when you have no feature tags and no permissions property?
• What happens when you have feature tags but no permissions property?
  • Permissions are trimmed to only those in the features list
• What happens when you have feature tags AND the "none" permissions property?
• What happens when you have no feature tags AND the "none" permissions property?

Research this and make sure we do what PGB does.

As above, it's something of a mess.

As a first implementation I just call cmd.exe from inside the AndroidPreparer. Should use the Maven exec plugin or something to do this in a cross-platform way.

A lot of common code that should be pulled into private methods etc.

As is really, make sure that we implement as many PhoneGap features as possible. I'll come up with a feature list for this soon.

Mergers should do a merge(applicationContext, context).. not a perform.

On top of this, a beforeMerge might be useful to allow the Mergers to assign some common variables that are used throughout (for example on Android it'd be things like the resources folder path etc.)

If a PhoneGap field is not recognized then the user gets an error, but if a Property that we don't yet support isn't recognized it goes by silently (we know about Property tags).

I suggest something like a handleProperty(PropertyName prop) on the merger to handle this kind of thing. If it wasn't implemented we could tell the user about it.

At the moment it'll just break in the create stage but we don't explicitly handle it. There should be a check dependencies stage.