emilioastarita / lyricfier Goto Github PK

Hey there,

I am pretty new to Spotify and Lyricfier. Where does Lyricfier get the lyrics from and is there any possibility to edit wrong lyrics or submit missing ones?
I hope my question is not too noob.
Thanx in advance

Tattva

Found a bug when lyrics contains double quotations marks (") , lyricfier shows a \ char before the quotations marks and nothing else after that. Simple quotation marks (') is parsed properly. The use of double quotation marks seems to be particular of musicxmatch, see example: https://www.musixmatch.com/lyrics/twenty-one-pilots/Holding-On-To-You

The issue seems to be one that involves an album that is known by more than one name, and labeled so in spotify. So Metallica (also known as The Black Album but not referred to as such) loads lyrics fine, but David Bowie's 2nd album doesn't load any lyrics as it's referred to as "David Bowie (aka Space Oddity)". I know this is kind of an unusual situation as not many album titles have this ambiguity, but there may be a need for some code to help navigate around these unusual special cases.

It seems that , when fast skipping to next song, lyricfier can't correctly retrieve the lyrics.
See the screenshot

I quickly skipped 2 songs and got it.

The message is clearly wrong. lyricfier should at least show the real problem (better if it correctly retrieved lyrics 😏)

Chromecast support would be great. Once way to do this would be to also act as a web server we can connect to locally. We could then chromecast that tab to the TV>

latest version (x32-x64 and ia32) give me white screen on start
(win10)

run as admin, compatibility mode, no dice.

Lyrics have not been loading for any songs for the last several days. Since the app worked before I figured it must be due to a change in one of the lyrics providers.

I removed each search plugin and identified the MusicMatch plugin as the problem. With that plugin removed lyrics loaded correctly again.

I think a lot of people (probably all of them) are having this problem, Issue #60 is where people are reporting this bug although the description in that Issue is not correct.

Thank you so much for this plugin! It is great and when it stopped working I HAD to figure out a workaround.

It seems like a great app, but i am not able to use it since its always giving me an error
Error details - Current song error: Error: connect EONNREFUSED 194.68.40.99:443 port is always 443

Hello again

MusixMatch/MusicMatch restricts certain lyrics like this one and Lyricfier will show a blank field since the body value is empty.

So the suggestion is that Lyricfier should show/signal to the user in some way that the lyrics is restricted.

EDIT: Thinking about it telling the user doesn't really benefit them as they realistically can't do anything about restricted lyrics. So it might as well just say it couldn't find any.

The (Mac) app comes in at a whopping 370MB. Does it also work as a PhotoShop replacement? :-P

In all earnest: How is that possible? Does the app ship with a massive amount of dependencies?

This song is on portuguese. The problem occurs because there is a lyric with the same name of the song but different artist, the correct lyric is later.

It takes first lyric from:

No Stress - Blacko

https://www.musixmatch.com/search/No%20stress%20no%20stress/tracks/1

Correct lyric is on:

No Stress - No Stress

https://www.musixmatch.com/search/No%20stress%20no%20stress/tracks/2

at position 9...

First of all, let me thank you for an amazing plugin.

I am Lithuanian and my language has some additional characters that needs latin-extended subset to be included. Roboto font supports this subset (https://fonts.googleapis.com/css?family=Roboto:300,300i,400,400i,500,500i,700,700i&subset=latin-ext). If this subset is not included I see very bad looking lyrics for Lithuanian songs:

Also I suggest you to include cyrilic and other subsets, because you can find songs of all languages in Spotify.

The colorful icon looks weird along the rest of monochrome icons on the menubar.
Something like this would look better imo:

Only occurs with non-dark theme, caused by lack of default background-color (beakerbrowser/beaker#68)

Hey, I want to use Lyricfier to practice my english pronunciation throughout songs. Is there any way to modify to code to do one of the following:

1. Get the lyrics, run them through an IPA (International Phonetic Alphabet) translator and display the translated lyrics.

2. Or at least, allow copying the lyrics with some clicks/keys in order to manually run them through the IPA translator.

Thank you!

Hello,
I am a computer engineer working as mainly front-end web developer.
I found this tool on searching how can I improve my english by listening my favorite musics.
So I suggest this 2 more features:

1. On right side adding native language translations (by using google translations or some other machine translators)
2. Highlighting the lyric position of current music.
   I have some ideas for that.
   Thanks for your efforts.
   Kind regards,
   Emre

Here is the error

npm ERR! Linux 4.4.0-21-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start"
npm ERR! node v6.9.1
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR! [email protected] prestart: `tsc`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the [email protected] prestart script 'tsc'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the lyricfier package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tsc
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs lyricfier
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls lyricfier
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:

0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/nodejs', '/usr/bin/npm', 'start' ]
2 info using [email protected]
3 info using [email protected]
4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle [email protected]~prestart: [email protected]
6 verbose lifecycle [email protected]~prestart: unsafe-perm in lifecycle true
7 verbose lifecycle [email protected]~prestart: PATH: /usr/lib/node_modules/npm/bin/node-gyp-bin:/home/drupalshift/Desktop/lyricfier/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
8 verbose lifecycle [email protected]~prestart: CWD: /home/drupalshift/Desktop/lyricfier
9 silly lifecycle [email protected]~prestart: Args: [ '-c', 'tsc' ]
10 silly lifecycle [email protected]~prestart: Returned: code: 2  signal: null
11 info lifecycle [email protected]~prestart: Failed to exec prestart script
12 verbose stack Error: [email protected] prestart: `tsc`
12 verbose stack Exit status 2
12 verbose stack     at EventEmitter.<anonymous> (/usr/lib/node_modules/npm/lib/utils/lifecycle.js:255:16)
12 verbose stack     at emitTwo (events.js:106:13)
12 verbose stack     at EventEmitter.emit (events.js:191:7)
12 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/lib/utils/spawn.js:40:14)
12 verbose stack     at emitTwo (events.js:106:13)
12 verbose stack     at ChildProcess.emit (events.js:191:7)
12 verbose stack     at maybeClose (internal/child_process.js:877:16)
12 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
13 verbose pkgid [email protected]
14 verbose cwd /home/drupalshift/Desktop/lyricfier
15 error Linux 4.4.0-21-generic
16 error argv "/usr/bin/nodejs" "/usr/bin/npm" "start"
17 error node v6.9.1
18 error npm  v3.10.8
19 error code ELIFECYCLE
20 error [email protected] prestart: `tsc`
20 error Exit status 2
21 error Failed at the [email protected] prestart script 'tsc'.
21 error Make sure you have the latest version of node.js and npm installed.
21 error If you do, this is most likely a problem with the lyricfier package,
21 error not with npm itself.
21 error Tell the author that this fails on your system:
21 error     tsc
21 error You can get information on how to open an issue for this project with:
21 error     npm bugs lyricfier
21 error Or if that isn't available, you can get their info via:
21 error     npm owner ls lyricfier
21 error There is likely additional logging output above.
22 verbose exit [ 1, true ]

Hi, when I run this app I get the message "Current song error: Error: connect ECONNREFUSED 127.0.0.1:443" am I missing a step in setting this up?

Buenas tardes.

Tengo un problema al tratar de iniciar la aplicación después de haber clonado.

El error que me aparece es el siguiente:

npm start

[email protected] prestart /Users/desarollo/Documents/proyectos/lyricfier
tsc && lessc render/less/main.less render/css/main.css

node_modules/@types/electron/index.d.ts(773,30): error TS2689: Cannot extend an interface 'NodeJS.EventEmitter'. Did you mean 'implements'?
node_modules/@types/electron/index.d.ts(2603,21): error TS2689: Cannot extend an interface 'NodeJS.EventEmitter'. Did you mean 'implements'?
node_modules/@types/electron/index.d.ts(2813,30): error TS2689: Cannot extend an interface 'NodeJS.EventEmitter'. Did you mean 'implements'?
node_modules/@types/electron/index.d.ts(3254,24): error TS2689: Cannot extend an interface 'NodeJS.EventEmitter'. Did you mean 'implements'?
node_modules/@types/electron/index.d.ts(3975,21): error TS2689: Cannot extend an interface 'NodeJS.EventEmitter'. Did you mean 'implements'?
node_modules/@types/electron/index.d.ts(4436,93): error TS2304: Cannot find name 'Promise'.
node_modules/@types/electron/index.d.ts(5295,93): error TS2304: Cannot find name 'Promise'.
node_modules/@types/electron/index.d.ts(5520,93): error TS2304: Cannot find name 'Promise'.

npm ERR! Darwin 16.1.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
npm ERR! node v6.5.0
npm ERR! npm v3.10.3
npm ERR! code ELIFECYCLE
npm ERR! [email protected] prestart: tsc && lessc render/less/main.less render/css/main.css
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] prestart script 'tsc && lessc render/less/main.less render/css/main.css'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the lyricfier package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! tsc && lessc render/less/main.less render/css/main.css
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs lyricfier
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls lyricfier
npm ERR! There is likely additional logging output above.

Gracias.

The Lyrics for some songs is not displayed but available on musixmatch.
I've uploaded a screenshot here: http://prntscr.com/d3dyxj

Everything else works fine

caused by the new drag bar

Title, and why is there no close button?

I made sure that all spotify domains are unlocked in hosts. In app it shows "Current song error: No song" and in developer console every time this happens this shows up:
Object {error: Object, version: 9, client_version: "1.0.50.41368.gbd68dbef", running: true} client_version:"1.0.50.41368.gbd68dbef" error:Object message:"Invalid OAuth token" type:"4102" __proto__:Object running:true version:9 __proto__:Object

I've already tried reunzipping archive and relogging in Spotify

Would be nice to add a link to the source of the lyrics to be open in the default browser.

The link must have name of the source (Wikia, MusicMatch, etc) and point directly to the lyric on their site.

Hi,

I cannot download the windows version.

I've tried various different songs, but they all result in the same error screen, showing the following error;

Hello again
Getting this error following the development setup instructions, deleting the line in render-typings.d.ts referencing the vue index.d.ts file seems to let it run without a problem. Log is attached.

render/render-typings.d.ts(3,1): error TS6053: File 'C:/Users/Lars/lyricfier/node_modules/@types/vue/index.d.ts' not found.

Also related the readme in the folder where the file should be:

This is a stub types definition for vuejs (https://github.com/vuejs/vue).
vuejs provides its own type definitions, so you don't need @types/vue installed!

npm-debug.log.txt

Hi how do I use this. I'm not too smart with computers just wanna listen to music

Spofity not recognized until you push try again button.

Spotify version: 1.0.45.186.g3b5036d6
Windows version: 10.0.14393

When you run application with npm start and use alt + f4 to close, process is not terminated.

The problem is on 'close' event. I propose to add quit method.

createWindow() {
        let options = {
            width: 500,
            height: 600,
            icon: this.getTrayIcon(),
            frame: false,
            show: false,
            alwaysOnTop: this.settings.get('alwaysOnTop')
        };
        this.window = new electron.BrowserWindow(options);
        this.window.on('close', (e) => {
            e.preventDefault();
            this.window.hide();
            this.quit(); // terminate process
        });
        this.window.loadURL(this.getView('index'));
        this.window.on('ready-to-show', () => {
            this.window.show();
        });

        return this.window;
    }

The checked-ness of the settings don't get set correctly initially and can come out of sync later as well

MusicMatch doesn't provide lyrics for all songs, some are not available, some don't have them due to copyright restrictions. E.g. Journey - Don't Stop Believing

In such a case, it would be great to fall back on other providers. E.g.:

The ChartLyrics API is down, the contact form is not functional. The LyricWiki API was removed due to licensing restrictions.

However, both can be crawled on demand. Search for the song then get the lyrics from the result.

Hi, not sure if there's an option for the following or a workaround:

• Change colors to be inverted, black background and white text (similar colors to spotify client would give a more immersive experience and easier on the eyes in my opinion).
• Disable notifications. As it is now, i'm getting a notification from spotify and another from lyricfier every time spotify's song changes (Running on Linux with dunst as notification daemon).
• Move scroll bar to the top when song changes.

Otherwise really loving it, good job. Out of curiosity, what lyrics api are you using?

It would be nice to have a button to change the font-size. In developer options this already works with e.g. fon-size:25pt, but after closing the programm restores the default font-size.

Hi, just a suggestion:
Introduce a button for hide the lyrics and just keep the bar with the title of the song and the cover.
So when you are working and you just want to know the current song you can hide the lyrics without taking up the workspace.

I'm using spotify at office. My company uses proxy to access internet. How can I use lyricfier through proxy?

Thanks in advance

Hello and thanks for this great program!

With the song 'Everybody' from 'DON BROCO' I'm getting 'INSTRUMENTAL' shown instead of the lyrics.
Source is listed as 'MusicMatch', links to the actual lyrics and the song doesn't appear to be flagged as instrumental.

Looking at the htm of the lyrics page of this song compared to songs where MusicMatch works, I've found that this song contains a lyrics object in the crowdLyricsList array whereas the working ones don't.
This lyrics object in crowdLyricsList is flagged as instrumental and it's body value is "INSTRUMENTAL".

It differs like this:
DON BROCO - Everybody
"lyrics":{"crowdLyricsList":[{"body":"INSTRUMENTAL"}],"lyrics":{"body":"-the right lyrics-"}}
Get Well Soon - It's Love
"lyrics":{"crowdLyricsList":[],"lyrics":{"body":"-the right lyrics-"}}

Since the MusicMatch plugin looks for the first body value the lyrics from the crowdLyricsList will be chosen for the first. No song seems to be using a lyrics from the crowdLyricsList so it probably contains user submitted unverified lyrics and can be ignored.

It keeps saying it's looking for a song on Spotify, but I had one open. I also use Windows 10 and run this application as administrator.

I think the app should store lyrics in system as cache to avoid getting the same lyrics again.

hi,
Can i run it on a Mac computer?
if yes how can I do it ?
thanks

Been happening for a while, probably because I might have deleted the spotify configs in the hosts file. The developer tools say this:

"C:\Users\Ayrton\AppData\Roaming\Spotify\LyricFier\resources\app\render\SpotifyService.js:79 Error getting csrf token URL: http://127.0.0.1:4370/simplecsrf/token.json"

What are the URLs I need to set up?

Hey Guys!

I'm here just to say how much I'm thank full for your guys taking your free time to do this program.

The internet is better with people like you.

THANK YOU SO MUCH!

And sucess to you all in all of your projects.

best regards.

It would be great if you could add dark theme matching the spotify color scheme.

Spotify version: 1.0.45.186.g3b5036d6
Windows version: 10.0.14393

No conecta con Spotify: