Crash - AttributeError: 'NoneType' object has no attribute 'group' about itchio HOT 7 CLOSED

I've had a look at this, and I can't seem to add this to my library for testing as it is free, but I'll add error checking on this to just include the name from the download name

from itchio.

@Emersont1 Well, the main issue is that it crashes the script, meaning that it doesn't download what follows.

Related to #25

from itchio.

So, I forked it ( https://github.com/TheFrenchGhosty/itchio ), and removing .group(1) from https://github.com/Emersont1/itchio/blob/main/itchiodl/utils.py#L21 made the download work, I then moved back to the pip package and download continued correctly, without "breaking" on this file.

What's the use of .group(1) exactly? Because it doesn't seem to cause any problem from what I can see.

from itchio.

so the .group(1) returns the regex captured group 1 which contains the filename to be downloaded from the header

What file did your code output it as, as I feel it will have messed with that

from itchio.

@Emersont1 You're right, the file is named None... though I guess it's better than the script just crashing on it.

from itchio.

Follow up: I now have downloaded my whole collection (962GB) - except the stuff that got outputted to errors.txt, this file was the only one causing an issue.

from itchio.

@TheFrenchGhosty I've opened #29, can you test this code to see if that fixes the issue please

from itchio.