Comments (7)
I've had a look at this, and I can't seem to add this to my library for testing as it is free, but I'll add error checking on this to just include the name from the download name
from itchio.
@Emersont1 Well, the main issue is that it crashes the script, meaning that it doesn't download what follows.
Related to #25
from itchio.
So, I forked it ( https://github.com/TheFrenchGhosty/itchio ), and removing .group(1)
from https://github.com/Emersont1/itchio/blob/main/itchiodl/utils.py#L21 made the download work, I then moved back to the pip package and download continued correctly, without "breaking" on this file.
What's the use of .group(1)
exactly? Because it doesn't seem to cause any problem from what I can see.
from itchio.
so the .group(1)
returns the regex captured group 1 which contains the filename to be downloaded from the header
What file did your code output it as, as I feel it will have messed with that
from itchio.
@Emersont1 You're right, the file is named None
... though I guess it's better than the script just crashing on it.
from itchio.
Follow up: I now have downloaded my whole collection (962GB) - except the stuff that got outputted to errors.txt
, this file was the only one causing an issue.
from itchio.
@TheFrenchGhosty I've opened #29, can you test this code to see if that fixes the issue please
from itchio.
Related Issues (20)
- Bundle tool not working HOT 2
- Running into error while trying to add all items in a bundle to my account HOT 4
- Broken files aren't redownloaded HOT 1
- Deleted files aren't redownloaded HOT 1
- Download free games with this tool? HOT 6
- Show overall progress
- Add Games in bundle to library does not work HOT 8
- Downloader is creating folders and JSON files for about half of my library, then exiting HOT 18
- Can't Get Downloader working HOT 6
- Detect (and remove) files that aren't available on Itch servers (older version of games)
- No progress of download | after running the tool
- Failing to download HOT 9
- licensing HOT 1
- Feature Request: Cache download_key_ids HOT 1
- downloads empty folders without admin privileges / crashes with admin privileges or when trying to download individual games HOT 6
- Finding games but not writing files. HOT 8
- crash downloading large library HOT 5
- Crash when a game file changes name when downloaded due to filename character restrictions HOT 2
- Crash - AttributeError: 'str' object has no attribute 'open' HOT 4
- Crash - FileNotFoundError: [Errno 2] No such file or directory when filename contains unusual symbols HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from itchio.