The embrace-demo-apps from embrace-io

[Bug] iOS Build fails for react_native/sample_integration app

Steps

1. git clone https://github.com/embrace-io/embrace-demo-apps.git
2. cd react_native/sample_integration && yarn
3. cd ios && pod install && pod update
4. open sample_integration.xcworkspace

Update API_KEY in Embrace-Info.plist and AppDelegate.m.
Hit Play button to run the App.

Outcome

Error AppDelegate.m:57:5: Use of undeclared identifier 'Embrace'

Expected

App should successfully build and launch.

Error Cause

Check the embrace import in code at line 20, which falls in #ifdef FB_SONARKIT_ENABLED block, which ends at line 31.
This block don't get executed in release mode as it is used for Flipper integration in debug mode.

embrace-demo-apps/react_native/sample_integration/ios/sample_integration/AppDelegate.m

Lines 1 to 32 in ac7295f

 #import "AppDelegate.h" 

 #import <React/RCTBridge.h> 

 #import <React/RCTBundleURLProvider.h> 

 #import <React/RCTRootView.h> 

 #ifdef FB_SONARKIT_ENABLED 

 #import <FlipperKit/FlipperClient.h> 

 #import <FlipperKitLayoutPlugin/FlipperKitLayoutPlugin.h> 

 #import <FlipperKitUserDefaultsPlugin/FKUserDefaultsPlugin.h> 

 #import <FlipperKitNetworkPlugin/FlipperKitNetworkPlugin.h> 

 #import <SKIOSNetworkPlugin/SKIOSNetworkAdapter.h> 

 #import <FlipperKitReactPlugin/FlipperKitReactPlugin.h> 

 // EMBRACE HINT: 

 // Embrace is integrated using CocoaPods.  

 // If you just installed the library to the project and it is failing to build, simply run 

 // 'pod install' from the root of the IOS project in terminal, See: https://embrace.io/docs/react-native/add-embrace-sdk/ 

 // Keep an eye on the terminal since it should warn you about this. 

 #import <Embrace/Embrace.h> 

 static void InitializeFlipper(UIApplication *application) { 

 FlipperClient *client = [FlipperClient sharedClient]; 

 SKDescriptorMapper *layoutDescriptorMapper = [[SKDescriptorMapper alloc] initWithDefaults]; 

 [client addPlugin:[[FlipperKitLayoutPlugin alloc] initWithRootNode:application withDescriptorMapper:layoutDescriptorMapper]]; 

 [client addPlugin:[[FKUserDefaultsPlugin alloc] initWithSuiteName:nil]]; 

 [client addPlugin:[FlipperKitReactPlugin new]]; 

 [client addPlugin:[[FlipperKitNetworkPlugin alloc] initWithNetworkAdapter:[SKIOSNetworkAdapter new]]]; 

 [client start]; 

 } 

 #endif

Resolution

Move embrace import #import <Embrace/Embrace.h> out side / above #ifdef FB_SONARKIT_ENABLED block.

Feature request

It would be better you guys can app proper documentation for JS bundle, currently even after uploading dYSMs and JS symbols I still see main.jsbundle in stack trace which is not expected, It should show JS lines as we already have JS source maps.

Add codepush integration sample as in documentation it says Embrace SDK will leverage the CodePush SDK to find the location of the bundle but actually its not finding JS bundle location and giving error.

embrace-io / embrace-demo-apps Goto Github PK

embrace-demo-apps's People

Contributors

Stargazers

Watchers

Forkers

embrace-demo-apps's Issues

[Bug] iOS Build fails for react_native/sample_integration app

Steps

Outcome

Expected

Error Cause

Resolution

Feature request

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	#import "AppDelegate.h"

	#import <React/RCTBridge.h>
	#import <React/RCTBundleURLProvider.h>
	#import <React/RCTRootView.h>

	#ifdef FB_SONARKIT_ENABLED
	#import <FlipperKit/FlipperClient.h>
	#import <FlipperKitLayoutPlugin/FlipperKitLayoutPlugin.h>
	#import <FlipperKitUserDefaultsPlugin/FKUserDefaultsPlugin.h>
	#import <FlipperKitNetworkPlugin/FlipperKitNetworkPlugin.h>
	#import <SKIOSNetworkPlugin/SKIOSNetworkAdapter.h>
	#import <FlipperKitReactPlugin/FlipperKitReactPlugin.h>

	// EMBRACE HINT:
	// Embrace is integrated using CocoaPods.
	// If you just installed the library to the project and it is failing to build, simply run
	// 'pod install' from the root of the IOS project in terminal, See: https://embrace.io/docs/react-native/add-embrace-sdk/
	// Keep an eye on the terminal since it should warn you about this.
	#import <Embrace/Embrace.h>

	static void InitializeFlipper(UIApplication *application) {
	FlipperClient *client = [FlipperClient sharedClient];
	SKDescriptorMapper *layoutDescriptorMapper = [[SKDescriptorMapper alloc] initWithDefaults];
	[client addPlugin:[[FlipperKitLayoutPlugin alloc] initWithRootNode:application withDescriptorMapper:layoutDescriptorMapper]];
	[client addPlugin:[[FKUserDefaultsPlugin alloc] initWithSuiteName:nil]];
	[client addPlugin:[FlipperKitReactPlugin new]];
	[client addPlugin:[[FlipperKitNetworkPlugin alloc] initWithNetworkAdapter:[SKIOSNetworkAdapter new]]];
	[client start];
	}
	#endif