emarci15 / asplos22-minesweeper-reproduce Goto Github PK

Hi there,
Thanks a lot for your impressive work. I came across a problem while reading your code and I was hoping you could assist me. Specifically, in the markItemsContaining() function which I list below, I noticed that only pointers point to the heap will be marked in the shadow space because min_entry and max_entry point to the start and end address of the heap respectively. However, given that jemalloc uses mmap() to map new pages to the memory ranges between the heap and stack, blocks allocated from the mmap() region may be freed even if they have dangling pointers point to them. I was wondering if you had taken this into account and if so, how it is handled. Thank you for your time and expertise. And here's the function. It is defined in the header file central_quarantine.h.

 inline void CentralQuarantine::markItemsContaining(void *ptr, void *min_entry, void *max_entry) {
    // Only mark if within range of ptrs in quarantine
    if ((ptr >= min_entry) && (ptr < max_entry))
        shadow.mark(ptr);
}