Giter Club home page Giter Club logo

angular-owl-carousel-2's People

Contributors

emalikterzi avatar hostmir avatar manticsic avatar r3wt avatar sarfarazsajjad avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

angular-owl-carousel-2's Issues

overwriting watched scope variable results in endless duplication for owl-items

First load = n items
Second load = n items * 2
third load = n items * 3
etc

basically repro it by changing the watched item. in my case the following should simulate the problem.

$scope.details = {

gallery: ['item/1.png','item2.png','item.3png','item4.png']

};

$scope.changeDetails = function(){
     $scope.details = angular.copy($scope.details);
};

watched property is for owl-items directive is details.gallery.

In our case we have a map, and when a marker is clicked the markers details are set into $scope.details and the sidebar is then opened revealing the owl carousel containing details.gallery and the rest of the details properties as shown:

image

Notice in above image that the gallery has now been duplicated 3 times. reason nothing is displayed is due to #7 which i discovered right before this.

2 general requests | 2 bugs

Hey,
thx for providing a working owl carousel directive.

Some general requests

  • could you add a licence please?
  • could you add this to npm please?

... and now some bugs

  • currently you cannot attach callbacks (missing values in owlProperties list)
  • you cannot trigger an event programmatically (no access to owl carousel api)

Pullrequest is on the way :)

update:
Pull request #2

expose init() and destroy() in ready() function

As you can see, anything that is animated will cause the autoHeight to never adjust the carousel. can be worked around by exposing these methods in someway, possibly by providing it to the ready() listener

image

'rtl' property missing

I understood 'rtl' option has been missing in owl-properties, so this feature are unavailable.

Some times the carousel isn't initialized

Hey,

I've got the problem, that some times the carousel isn't initialized after route change. Some times it is.
Then, the carousel isn't working and the carousel-items just shown among each other

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.