emadhegab / mhnetwork Goto Github PK

Readme:

case .error(_, let networkError):

https://github.com/emadhegab/MHNetwork/blob/master/MHNetworkTests/NetworkDispatcherTest.swift

case .error(let error):

And the last one is compileable only

execute
missed "c" button in protocol declaration so class which implements this protocol should use the same mistaken name

Currently I try to connect to API with GET requests. The problem is when I get an error I don't see the final request URL - it is hidden somewhere inside this library.
What about to add some log (at least for visible url part)?

I could inherit from NetworkDispatcher but:
Cannot inherit from non-open class 'NetworkDispatcher' outside of its defining module

return URLQueryItem(name: element.key, value: element.value as? String)
This allows to pass string params only. But if you replace element.value as? String with \(element.value) it will accept for example int and bool values too.

Additionally NetworkDispatcher is protected from inheritance and I should create a copy of it

For example I need a library to collect rss from different websites. I need to specify single url only and get/post method only for each website. You library requires to setup all params even if they are not necessary

For example in your code with getMoviesList I want to pass an additional param - "year".
I send the same requests but with different year value specified from outside.
How to implement it?