elyssonmr / double-check Goto Github PK
View Code? Open in Web Editor NEWDouble Check is a service that you can enable multi factor authentication for your systems using a Telegram bot
License: MIT License
Double Check is a service that you can enable multi factor authentication for your systems using a Telegram bot
License: MIT License
I am trying to generate a token without having the chat_id registered in Redis.
double_check_api | DEBUG:aiogram:Make request: "sendMessage" with data: "{'chat_id': 986743, 'text': 'Hello afdf6057-77b3-4985-a4c9-fe94dbfc5e72. Your token is: 986743'}" and files "None"
double_check_api | DEBUG:aiogram:Response for sendMessage: [400] "'{"ok":false,"error_code":400,"description":"Bad Request: chat not found"}'"
Could we retrieve the user's chat_id from the telegram API if it doesn't already exist?
Add and configure bump version.
It should have a version in:
The /request_token doesn't return a correct Status Code when the provided data is not valid. It returns a 500 status code (Internal Server Error) which is not correct for this situation.
It should return a 400 (Bad Request) informing which field is not valid.
The API accepts a action field to indicate which action should be "Double Checked" but this action is not being sent within the message to a user.
Add the action in the message sent to the user to inform which action is being requested to be Double Checked
The /check_token doesn't return a correct Status Code when the provided data is not valid. It returns a 500 status code (Internal Server Error) which is not correct for this situation.
It should return a 400 (Bad Request) informing which field is not valid.
Improve swagger text. There is some errors there
Today the application doesn't delete the created token after it was used from a "Double Check" request. This could lead to a security problem and use of the same token for more than one request.
When a application verifies a token and it is correct, it should be removed from the cache to prevent its use for the same verification request again.
The project is written and tested using Python 3.7 but the current stable version is 3.10.
Update the python version of the project and don't forget to also update the python version used in the Dockerfile
The project has no release yet, but we need to configure a changelog and we should track all the changes.
Configure the Towncrier in the prject and create a CHANGELOG.md in the project root.
The Double Check API still don't have a Swagger documentation in order to indicate its endpoints or explain how to integrate with the API.
Create a documentation using swagger.
I should contain the endpoints:
It also should have the data structure used on those endpoints.
The README.md is not with all information about the project.
This issue refers to the improvement of the installation process within the README.md.
The rquested improvement should cover:
Add the configuration of logs in the system.
It should use python default logs with the configuration within the config file.
For now if we log to a file should be really great but in the future we should configure some tools provided by big clouds or make the logs in a way that we can configure different logs tools.
The idea of this issue is to create a end-to-end test for the project.
The test structure is not yet planned but any suggestions would be great.
The restrictions are:
We can discuss the structure in this issue before start implementing
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.