elringus / sprite-glow Goto Github PK

How can I do this without resetting the brightness, I tried doing color * Mathf.LinearToGammaSpace (emission);

I tried for many hours to find a solution but i'm out of ideas !

I'm working on Unity 2018, SpriteGlow 1.6 (and it's the same with 1.7).

I have the processing stack enabled on my project, and a sprite with a glow effect.

It's ok in my editor and in play mode and it's ok when I build for Windows, I can see the glow effect.

But when I build for Android and try the .apk on Android Studio, the sprite with the SpriteGlowEffect script is pink.

I manually added the shader Sprite/Outline in Graphics settings but no effect.

Do you have an idea ? Tthanks !

If we have multiple sprites the glows generated will overlay one another. See center of RHS image
Desired effect would be a combined sprite so that a single outline is created. See center of LHS of image.

Even better - would be to enable placing these glows on separate layers? THough This may be far too complex?

When I'm trying to add the sprite to a custom layer unity freaks out and throws this error: Can't add component 'SpriteRenderer' to x because if conflicts with the existing 'MeshFilter' derived component!

It seems to no longer work on 2019.3. Is there something else I need to configure for the URP?

Can you update shader code for Unity 5.6 please?
Thanks.

Corresponding Unity issue: https://issuetracker.unity3d.com/issues/bloom-not-working-with-hdr-and-bloom-threshold-at-1

Even though it's marked as fixed in 2017.1, it's actually not.

Workaround: unknown, please share if you find any solution.

If there's no SpriteGlow in the scene already adding a SpriteGlow component form the script causes a NullReferenceException because SpriteGlowMaterial.OUTLINE_SHADER is null.

The glow is not working even after following all the steps.
I dont know how to fix it.

I have tried several different things but for some reason the "HDR" is not actually showing up within the HDR color picker. The HDR picker is being shown but I don't see the "HDR" text within the color picker and there is no glow on my sprite. I copied all the files into my project and set everything up just as the sample project but no luck.

Am I missing something here?
Thanks!

Hi, when i'm switch to android, image effect doesnt work like platform pc, but when i try with kinobloom of Takahashi, bloom view to good, so what issue of this
https://github.com/keijiro/KinoBloom

Working fine with all Mesh and Sprites but nothing happen with Spine 2D.... No Outline appear. can you please make this support for Spine2D skeleton and provide upgrade for this

PC: http://take.ms/yK9jm
Android: http://take.ms/FYDmQ

I have a simple sprite (square of white color) and I am setting a random color to its sprite renderer in code. I want to use the same color as GlowColor which works fine for once but when I change GlowColor a couple of times it loses its color brightness resulting in lose of glow.

Here is the code I am using:

public void Init (Color color) 
{
    sprite = GetComponent<SpriteRenderer>();
    sprite.color = color;
    SpriteGlow.SpriteGlow glow = GetComponent<SpriteGlow.SpriteGlow>();
    glow.GlowColor = color;
}

Init method is called multiple times, how can I set glow color so it is visible every time?

PS: Currently Bloom effect is applied on all the materials. How can I remove the effect from some of materials?

Cheers

Hello! It is possible to somehow disconnect bloom on Particles?

I want to implement this to the 2D game I'm developing. I'm kinda new to this. If you could elaborate on the workflow a bit. I'm confused about the material that I've to create, you've mentioned it in the Description. Any help is appreciated.

when I create a material and set it to an image in the scene view the glow work, but in game view it does not, but bloom work just fine on everything else. URP 7.3.1 and in 2019.3.

Video showing the problem: https://www.dropbox.com/s/8d5col4tvhs0jgd/yJVJZkgwyk.mp4?dl=0

NullReferenceException
UnityEngine.Material..ctor (UnityEngine.Shader shader) (at /Users/builduser/buildslave/unity/build/artifacts/generated/common/runtime/ShaderBindings.gen.cs:259)
SpriteGlow.SpriteGlowMaterial..ctor (UnityEngine.Texture spriteTexture, Boolean drawOutside, Boolean instancingEnabled) (at Assets/SpriteGlow/SpriteGlowMaterial.cs:21)
SpriteGlow.SpriteGlowMaterial.GetSharedFor (SpriteGlow.SpriteGlow spriteGlow) (at Assets/SpriteGlow/SpriteGlowMaterial.cs:37)
SpriteGlow.SpriteGlow.SetMaterialProperties () (at Assets/SpriteGlow/SpriteGlow.cs:144)
SpriteGlow.SpriteGlow.OnValidate () (at Assets/SpriteGlow/SpriteGlow.cs:131)

Hello,

I creat a default square in unity and drag the two files to it,but nothing happened.
What did I forget to do?

I read the replies to some of the other issues, but none seems to solve it.

When I add the Sprite Glow component to the sprite, it creates an outline outside of it:

But modifying the Bloom effect using the Unity PostProccessing stack doesn't have any effect on the sprite I want to glow, instead it has the same effect on every Sprite:

I'm using the Unity PPS bloom and any time the effect overlaps with another object it creates really bad colour distortions and bloom size changes, sometimes blotting out the entire screen. any idea if I just have this set up wrong or what might be causing that? Thanks!

https://i.imgur.com/bL1DQ2i.png
https://i.imgur.com/zcjquYQ.png

Can't find the namespace that has been used for the script and thus unable to get the component. I want to edit the glow parameters from my C# script.

Edit:

using SpriteGlow;

SpriteGlowEffect glow = GetComponent<SpriteGlowEffect>();

I build a apk work with this asset and I run this on my mobile and it's not work and also weird thing happen but Unity editor it's perfectly work! if you can fix that it's awesome

Hi there, great plugin! I am trying to use this with Unity UI but I get this warning. Is there any way to add Stencil support?

Thank you!

I've copied every single parameter, object, asset, and project setting I could find in the example project. Still, I can get no more than this punny outline around the character's head:

It's my first time attempting this post processing wizardry, and I would be very thankful if it could be just a rookie mistake.

I managed to reproduce the bloom but i can't find any way to do that dirty lens effect

Hi, the plugin look great, but I can't import to Unity with following error:

Cannot perform upm operation: Unable to add package [https://github.com/Elringus/SpriteGlow.git#package]:
  No 'git' executable was found. Please install Git on your system then restart Unity and Unity Hub [NotFound]
UnityEditor.EditorApplication:Internal_CallUpdateFunctions()

Error adding package: .
UnityEditor.EditorApplication:Internal_CallUpdateFunctions()

Do you have other method to suggest to import the package?

Thanks a lot

I dont really know why the script isn't working, i'm using Unity 2018.2.13f1:

The sprite:

Configurations on inspector:

HDR in graphics is checked:

Camera also have checked Allow HDR:

The system is great and I'm very satisfied, but I noticed I can't use it on tilemaps.

Unity displays the LogError message: "Can't add component 'SpriteRenderer' to Tilemap because it conflicts with the existing "TilemapRenderer" derived component!", which makes it pretty obvious that the problem is with the TilemapRenderer.

I'm still new in Unity and slowing learning all the small bits, so please forgive me if this is a silly question, but is there a workaround to apply this System on a Tilemap? Thanks!

Hi. It took a while, but I managed to add the glow effect you provided to a sprite in my 2D game after installing the package, setting the post-processing volume/layers and assigning the sprite outline. It seems to have a use for what I'm looking for and runs well.

However, this game was meant to run at 60 frames per second, and it was running very well at the beginning. With this whole glowing effect added however, the game now runs between 20 to 30 frames, which is unbearable to watch. I'm leading to believe this has to do with the addition of the bloom effect, as I have not implemented lighting effects yet. Furthermore, the game seems to only cause this slowdown of performance when operating under the Unity Editor. I tested building the game into an executable file and it thankfully started working at the 60 fps I expected. Regardless, I want to continue testing the game in the editor without this setback of performance rate, as it would take too long to test each update in a new build.

My overall questions are, was this sprite glow addition meant to function in a lower frame rate? Are there methods I can consider to reduce the performance issues in result of this add-on shader? Any advice on how to keep projects running smoothly after applying the bloom effect would be very helpful. Thank you.

Hi , firstly thanks for creating great assets.
Is "SpriteGlow" also usable for mobile devices ?
Asking for performance.

I tested on an old HTC phone, all outlines become pink like it's missing the material.

This error comes up when unity3d wants to compile under OpenGl. I think it is something with unroll command.

With the newer Post-Processing Stack introduced in 2018.1, it seems that either this package doesn't support it, or there's a different setup required - I couldn't seem to figure it out and get it working, but I'm a little bit of a novice when it comes to the fine intricacies of the PPS.

Maybe some clarification in the help/troubleshooting/support area for v2?

In the meantime, the legacy PPS works awesome!

Everything is glowing instead of just outlines, how can I fix this?

When I add the Sprite Glow Effect (Script)
I get this error:
Shader error in 'Sprites/Outline': not enough actual parameters for macro 'UNITY_ACCESS_INSTANCED_PROP' undeclared identifier 'UNITY_ACCESS_INSTANCED_PROP' at line 222 (on d3d11)

Compiling Vertex program
Platform defines: UNITY_NO_DXT5nm UNITY_ENABLE_REFLECTION_BUFFERS UNITY_NO_CUBEMAP_ARRAY UNITY_USE_DITHER_MASK_FOR_ALPHABLENDED_SHADOWS UNITY_PBS_USE_BRDF1 UNITY_SPECCUBE_BOX_PROJECTION UNITY_SPECCUBE_BLENDING UNITY_ENABLE_DETAIL_NORMALMAP SHADER_API_DESKTOP UNITY_COLORSPACE_GAMMA UNITY_LIGHT_PROBE_PROXY_VOLUME

Thanks!

Can we apply this to line renderer for 2d? When I add the Sprite Glow script, it automatically adds the new material to the sprite renderer (Sprites/Outline), can we create this material instead of adding with the script so that we can add this material to the line renderer?

So far I can add in the SpriteGlowEffect into my sprite. But I couldn't add in SpriteGlowMaterial, it says the script needs to derive from MonoBehaviour. I tried changing the word Material from the public class into MonoBehaviour, but most lines have errors. Is there anyway to solve this?

Hi, I don't know this is my issue only, or it's your ideal shader. Please help me about shader, I need 1 outline pixel only. Thanks!
https://www.dropbox.com/s/g8kjkwju0mjdda6/outline_size.PNG?dl=0

Corresponding Unity issue: https://issuetracker.unity3d.com/issues/setting-default-behavior-mode-to-2d-breaks-hdr-rendering

Even though it's marked as fixed in 2017.2, it's actually not.

Workaround: switch editor to 3D behavior mode.

Corresponding PPS issue: https://github.com/Unity-Technologies/PostProcessing/issues/194

Workaround: use other bloom solutions, eg https://github.com/keijiro/KinoBloom

Hi, cool product, thank you! I am trying to get this working on my UI (buttons etc) for Built-In rendering, but having some issues on Unity 2019.4.7:

In SpriteGlow-1.8, in the UIExample scene, the LegacyCamera does not show the glow effect. I took these steps:

1. I disabled URPCamera and enabled LegacyCamera
2. I ticked Post Processing on the LegacyCamera
3. I set the Render Camera of the Canvas to LegacyCamera

See screenshot SpriteGlow_1_8_Issue
The example scenes work fine apart from UIExample. Am I missing something?

Just for reference, I also tried a previous version, but in SpriteGlow-1.7, none of the example scenes work.
See screenshot SpriteGlow_1_7_Issue

Thanks for your help.

Editor:http://take.ms/MqwPy
Android (Nexus 4):http://take.ms/ySFK8
Settings:http://take.ms/CwGGo
If to specify opengl es2 that all is normal but ate opengl 3 that leaves a problem ...

I am using UNITY 2017.1.1 but only 2018 in the instance supports UIGlow. Is there any way to convert it?

Hello! Is it possible to use this same effect with Images instead of SpriteRenderers? Thanks.

Hi there, is there any reason why the effect could be seen in scene view but not through the camera?

Is it because a 2d renderer is use?
I am trying to include it in a urp project that use a 2d renderer data