Giter Club home page Giter Club logo

fvtt-module-combat-music-master's People

Contributors

elizeuangelo avatar marutypes avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

Forkers

marutypes

fvtt-module-combat-music-master's Issues

Current scene playlist is not pausing, it continues, overlapping

I debated writing this up, because I suspect it might be user error on my side. But what I am experiencing is that when I start combat, I am expecting the scene playlist to stop or pause, so the battle music can take over, but what is happening is that both continue, overlapping. I have the "pause tracks" option enabled in the settings.

Music will not play if certain tokens are included in the battle.

image

If I place some tokens alone and start a battle, the music won't play.
And if the multiple tokens are in combat, music will not play if the problem token is included.

I didn't have any personal settings on all the tokens.
Also, there is no deleted or moved music file.

Is there a solution to fix this?

Playlists are not appearing

Having an issue where the drop down lists in both the combat and token sections show none of my playlists, so I am unable to select any music.
image
image

[Bug] When combat starts, one track from combat playlist is played then all stops

When I configure a combat playlist and begin combat, the module properly plays the first track and afterwards it is silence, unless I manually go to Audio tab and manually restart the play list.

I don't use per-encounter or token tracks.

Below is the configuration of the module and the track. Not sure if misconfiguration or bug.

image
image


Foundry version v10.291 and v11.300
Module version 1.4.4
Browser: Firefox/ Edge latest

[Feature] Resume combat tracks from last played position

Thanks for this great module!

I'm testing out Combat Music Master to provide both general combat tracks for NPCs and also personalize hype tracks for Players. As a consequence, the music changes with every player change.

At present, Combat Music Master begins each designated track from the beginning each time a character's turn starts. The results in the same 20-30 seconds of the song over and over again.

Is it possible to have the track resume from where it left off last time? That's the behavior that currently exists in the current module I'm using (Video Game Music), and I'm finding it's something my players miss when we've tested out Combat Music Master.

If this is something that would be considered, I'd be happy to take a stab at it to submit a pull request.

No Personal Music

image
I set a song here, but going to their turn on the turn order, still playing generic combat music.

What'd I do wrong? Or is something busted?

DSA5 compatibility

The token associated playlist ist not wotking with DSA5, because there is no ressource (e.g. health) available in the menu.

[Question] Understanding of the priorization

I think i dont fully understand the priorization.
Favorites got prio 1
Combat Tracker got prio 0
Tokens could be set individually.

If the lowest track is chosen, then how could i set the Token prio so it tops the combat tracker if a treshhold is reached?

Music skips

When I advance to a new turn, it skips several tracks quickly, playing a faint noise before giving up and moving to the next one. Sometimes it finds one it likes and plays it, other times it just gives up and nothing plays.

[Feature Request] Add Track not working in v11

When editing the music for a token, the Add Track option to allow different tracks at different resource levels does not work.

Test Configuration

Foundry Virtual Tabletop: Version 11 Stable, 11.305
Game System: pf2e, 5.1.2

How to Reproduce

With: Combat Music Master installed
Open character sheet of any character or NPC
Click Token
Click Music
Click "Add Track"

Observed: Nothing happens.
Expected: A new row is created.

[Feature Request] Pre-Combat Intro Track

During the phase when combat is starting, but before the first turn begins, Combat Music Master does not start playing music.

This is a period when starting a degree of hype music would be welcome. Something to get players alert as they roll initiative and as the bosses are introduced.

Ideally, it would be both a specific playlist, and something specific to each token in the combat. It would start the moment combat goes into the rolling initiative phase, and transitions to normal behavior once the GM hits "begin encounter."

Sometimes, music does not play at all

During the first time that a combat starts when a world is first loaded, music plays fine. Then during subsequent combats it starts to get wonky with music just outright not playing at all when combat starts. When using hype tracks, it sometimes goes completely silent on the token's turn and some other times it works correctly.

I used find the culprit and after turning off all other modules except this one, I was able to fully reproduce the issues. (reproduce is used loosely here since it's quite random if this happens)

Here's my settings, steps to reproduce etc.

Playlist:
I have 3 playlists

  • "Combat - Normal" (set to default with priority 1, aka starred)
  • "Combat - Boss" (used for manual overrides)
  • "Combat - Characters" (used for hype tracks)
    as follows
    image

All tracks are set to Loop, no fade has been set

Tokens:
I have 5 tokens

  • Player character 1~4, each set with their hype tracks as follows
    image
    Priority is 10, turn only is checked, tracked resource is always empty regardless of what I select (because there's no other option atm?)
  • Enemy token with no hype track set.

Steps:

  • Add all to combat. (note, no player clients are connected, this is just the GM solo testing)
  • Roll all at once.
  • Begin combat
  • Scenario 1 (player character first in order, enemy somewhere in the middle)
    - default track plays over character track (priority 1 beats priority 10?)
    - other charcter's tracks play fine
    - on enemy's turn nothing plays (about 25% of the times, the default track plays)
    - end combat, ambient music resumes
    - start combat again by reading everything
    - enemy always stays silent, character tracks sometimes play, sometimes don't. It's quite random.
  • Scenario 2 (enemy first in order)
    - nothing plays (but 25% of the time the default track plays as in scenario 1)
    - subsequent character tracks play fine
    - end combat, ambient music resumes
    - start combat again by reading everything
    - enemy always stays silent, character tracks sometimes play, sometimes don't. It's quite random.

It's a bit hit and miss, but sometimes nothing play at all. Refreshing the world does make everything play, but this is not really feasible during actual play.

There might be something going on with synchronizing what is currently being played?
Perhaps await the track to be fully loaded before firing off the hook that plays it?
I can invite you to the world to test for yourself, this is a bit weird.

Conflict with PF2e and Monk's Combat Details

I receive the following error when I change turns in the combat tracker:

image

It doesn't always occur, but the vast majority of turns are broken, causing the new track to not be played, and sometimes keeping the previous song playing.

Note, this error still occurs even with Monk's Combat Details deactivated. With only PF2e running, here is what I get:

image

Let me know if you need any other details. Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.