elgs / gostrgen Goto Github PK

hello sir
Sorry to bother I was going through GitHub to see if I could find help then I stumbled on your repo, The problem I have is with this Go code

package main

// Project rand-string
// file: main.go
// Author: handsomekaizer [email protected]
// Description: random string generator

import (
"crypto/rand"
"fmt"
"math/big"
)

const RANDOM_STR_LEN = 10

func shuffleDict(dict string) []rune {
shuffledDict := []rune(dict)
for i := 0; i < len(dict); i++ {
r, _ := rand.Int(rand.Reader, big.NewInt(int64(len(dict))))
randn := r.Int64()
char := shuffledDict[i]
shuffledDict[i] = shuffledDict[randn]
shuffledDict[randn] = char
}
return shuffledDict
}

func main() {
fmt.Println("Here:")
var dictionary string = "abcdefghiklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
for k := 0; k < 100; k++ {
shuffledDict := shuffleDict(dictionary)
for j := 0; j < RANDOM_STR_LEN; j++ {
i, _ := rand.Int(rand.Reader, big.NewInt(int64(len(dictionary))))
fmt.Printf("%c", shuffledDict[i.Int64()])
}
fmt.Printf("\n")
}
}

The Go code is ok, it generates 10 alphanumeric characters. but I wanted you to help me add a function where it generates the 10 alphanumeric characters and replaces **********
in this characters below

5m**********kbgTRZhiS5sjGMpmcRZdPAhmWLRfpmutGmPHtjklob

with the 10 alphanumeric characters it generates.

thanks

If this function is called in a fast-ish loop, the strings will not be random, because RandGen includes a call to rand.Seed(time.Now().UTC().UnixNano()). Called within the same nano, it will contain the same string. This also has the very undesirable side effect of resetting the rand seed for any other calls to rand in the rest of the program, essentially killing randomness.

Suggest to put the call to rand.Seed(time.Now().UTC().UnixNano()) inside an init() function, so it is called once and once only.