electronicwar / nbs-irc Goto Github PK

The latest update, and subsequent PM fix (:D), was really nice, but I noticed that channel notice from ZNC log is still behaving like the chat did before, with timestamps being current time on them all, and not when they were sent out.

Is this something you can look into?

• /timer: insufficient parameters (line 4362, main.nbs),

Appears sometimes, randomly .

1. I downloaded nbs-irc*.zip and extracted to %appdata%\nbs-irc
2. I created a shortcut to: "C:\Program Files (x86)\mIRC\mirc.exe" -r%appdata%\nbs-irc
3. I launch the application and get the following error:

To fix this error I ran SysInternals ProcMon and realised that I need to change the Start In directory in the properties of the shortcut from, to:

Now everything is peachy!

The latest release works fine besides all queries ends up as notices in server status window.

Since updating mIRC to 7.51 the options window appears so.

The idea comes from the use of BNC, with *status windows going nuts, when IRC goes down, but might have a general application for people in other situations:

*Set parameter to include or exclude query sound for various nicks and/or status windows
*Set parameter to only ping X amount of times, and then shut off sound, either on specific nicks/status windows, or in general, perhaps with a combination of the two (Having a general setup, but being able to also set for specific users/status windows.)
*Set parameter with a timer, so pinging X times resets after X minutes/hours, both generally as well as with specific nicks/status windows.

[19:21:43] <H4ndy> memory usage: 1/2048 MB (48%)
[19:22:10] <Rotab> memory usage: 1/2048 MB (56%)

The percentage seems correct, but 1/2048 is not.

Stuff > Auto Op and Auto Voice entries cannot be edited anymore with mIRC address book which opens when clicking "Edit" in the Stuff menu.

Workaround: remove entries from %appdata%\nbs-irc\control.ini manually.

This was probably introduced with mIRC 7.

1. There's a small bug when you run the /vote command and you are not connected.

Before and after fix:

Code:
if (!$server) { n.echo -atg info not connected | return }
Ought to be:
if (!$server) { n.echo info -atg not connected | return }

2. If you start a vote, it'll ask for a yes/no question. If you just click the OK button it shouldn't continue with the vote, it should just return / halt.

Code:
set %vote $n.input(Enter topic (yes/no))
Ought to be:
set %vote $$n.input(Enter topic (yes/no))

I am responsible for maintaining another mIRC script, dlFilter, designed to filter out adverts and other people's triggers from file sharing channels.

nbs-irc is incompatible with this script because nbs-irc is called on every IRC message and then haltdefs and explicitly echos every message regardless of whether this is needed for specific nbs-irc functionality. dlFilter also does something similar, but only when it is needed to stop messages from being shown or to send them to a different window than mIRC's default, and this is what makes them incompatible.

When dlFilter runs first, nbs-irc does not respect that dlFilter has halted specific messages and still echos them - in this situation nbs-irc's ON events should use the "&" prefix so that they are NOT run if a previous script has halted them and should only echo them if $halted is false.

When dlFilter runs last and wants to stop a message from being displayed, it notes that the messages have been halted, but cannot stop them displaying because nbs-irc echos them directly.

I would like to recommend three changes for how nbs-irc processes messages:

1. Make the ON events specific to the messages that you need to process to deliver specific functionality and not run on messages not needed for nbs-irc functioning. Split generic routines like ON NOTICE which then check message content into separate ON NOTICE routines for each type of content e.g. have a separate ON me:^*:notice:lag437289 *:?: rather than test with if ($nick == $me) && ($1 == lag437289) this inside a generic on ^*:notice:*:*: which runs on every channel and private notice;

2. Only haltdef messages when necessary to hide them or redirect them to a different window. Before echoing these messages check $halted and only echo if $halted == $false; and

3. Prefix your ON events with "&" unless you specifically need to process them (e.g. as responses to requests you have made) in order to respect haltdef of any scripts which run before. Note: This is equivalent to the existing code ìf ($halted) return` that is the first statement in many existing ON events.

I hope that by working on this together we can make our scripts compatible with one another.

The is a small layout issue in the toolbar with mIRC 7.47

Second window doesn't show anything though, but it still opens.

(1) whois: H4ndy|off  � name: H4ndy
(1)  � address: [email protected]
(1)  � channels: #help.script @#x0r #nbs-irc #PhantomL0rd @#lolgents (5)
(1)  � auth: H4ndy
(1)  � server: *.quakenet.org (QuakeNet IRC Server)
(1)  � idle: 18h 59m 6s, signed on: 03:15:03 - 29/07/2015 (18h 59m 17s ago)
(1) /whois: 22:14