Giter Club home page Giter Club logo

Comments (8)

MarshallOfSound avatar MarshallOfSound commented on May 18, 2024 1

@ameerthehacker I don't think we want to move away from storing everything in a GitHub repo, it allows for versioning/tracking/history we won't get from an S3 bucket. Steps 1-3 I already have somewhere with local code and step 4 is what I stopped working on just instead of sending to S3 I was making it auto-PR to github. I'll figure out which laptop had the code on it some time this week if I get a chance

from apps.

zeke avatar zeke commented on May 18, 2024

Yep, good point. This project has grown organically, and a web-based form for adding apps does seem like a nice improvement.

A few ideas:

  • On the form, ask for repo first and automatically fill in description, website, name, etc
  • Support "login with GitHub" and autodetect Electron apps owned by the logged-in user.
  • We'd probably need a database. PostgreSQL, Redis, or something...

from apps.

ameerthehacker avatar ameerthehacker commented on May 18, 2024

Exactly but how should i get started? This would be a big change to the site and is that ok and doing this in one pull request does not seem right way for me so i would be great help if you can give your thoughts on this.

from apps.

zeke avatar zeke commented on May 18, 2024

Yeah honestly I feel like this would be a pretty big undertaking for an outside contributor.

@MarshallOfSound, you were working on something related to this. What came of that? Any thoughts on how it should work?

from apps.

MarshallOfSound avatar MarshallOfSound commented on May 18, 2024

I still have the code somewhere, I got to the point where I was inferring default values from a repository and was making progress towards automatically making a PR for the users app. When I get a chance I'll resurrect the code from whatever stash it is sitting in and push it up so others can maybe finish off the work

from apps.

ameerthehacker avatar ameerthehacker commented on May 18, 2024

Great, but will it be a problem if I can start things from scratch and start pushing minor updates step by step. This is the roadmap which I feel might work.

  1. Create login with Github
  2. Get the default values from repo
  3. Store those things in the database
  4. Upload the downloadables to a S3 bucket or something similar
  5. Making sure backward compatibility for the older apps and the apps being newly added.

from apps.

ameerthehacker avatar ameerthehacker commented on May 18, 2024

Fine @MarshallOfSound I will be waiting for it

from apps.

rustdevbtw avatar rustdevbtw commented on May 18, 2024

@MarshallOfSound Is there any progress on it? What about a dashboard that will trigger the electron-bot to add the app to the repo (with a direct commit or PR) after an app is reviewed? And after the PR is merged, it'll automatically add that app to the meta files and rebuild the https://www.electronjs.org website. This repo will still be the centralised place for all apps but a Dashboard will actually make the process better and easier - both for reviewers and developers.

Also, a database might be needed, I prefer the new Appwrite Backend-As-A-Service as it's a modern and highly scalable solution.

from apps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.