eko / monday Goto Github PK

Hello!

In pkg/forwarder/forwarder.go, at line 211:

for {
    err := forwarder.Forward(ctx)
    if err != nil {
        time.Sleep(1 * time.Second)
        f.view.Writef("%v\n👓  Forwarder: lost port-forward connection trying to reconnect...\n", err)
    }
}

• It doesn't seem to ever exit the for loop?
• This message happens when I forget that monday is running, leave it for the night, my k8s token expires, and there a flood of such messages while my CPU fan goes brrrrr (an unfortunate side effect of the repeated connection attempts catched by security tools installed by my employer on this Mac, apparently)
• I think a limited number of retries (with possible a longer wait time between retries), followed by a clean exit of monday, would be an acceptable failure mode (at least in my case ;)

What do you think?

<: &postgres
  name: postgres
  type: ssh
  values:
    remote: [email protected] # SSH <user>@<hostname>
    args:
      - "-i.vagrant/machines/default/virtualbox/private_key"
      - "-p 2222"
    ports:
     - 5432:5432

projects:
 - name: forward-only
   forward:
    - *postgres

I want to do this
ssh -NT -L 5432:127.0.0.1:5432

log:

❌  An error has occured while trying to write host file for application 'postgres' (ip: 127.0.1.1): open /etc/hosts: permission denied
✅  Successfully mapped hostname 'postgres' with IP '127.0.1.1' and port 9401
🔌  Proxifying postgres locally (127.0.1.1:5432) <-> forwarding to 127.0.0.1:9401

Hi,

Another issue that's kind of allowing I noticed, might as well raise it, should be easy to fix. If I start some forwards and the namespace does not contain the deployment with the labels specified, then it's going to hang forever, and no feedback at all from the program just blank screen. It would be nice to first have some feedback whats it trying to do, here find the deployment with those labels, maybe even print the labels its looking for, so we might realise we made an error or wrong namespace.
And at this point monday already is catching signal Ctrl-C so we can't kill the program at this point from that shell. We need to open a new shell and kill the process manually. And then the other shell is in a bad state cause the program was also trying to redirect stdout stderr I am guessing. It's not closed "properly".

If you have sometime to work on that at some point, I wouldn't say its high priority but a nice to have.

Thanks for the tool again.

Steps for Reproduction*

1. Set up a kubernetes-remote forward in the config.yaml configuration file with labels not available in the namespace specified or a wrong namespace
2. Start Monday
3. Blank screen
4. Hit Ctrl-C to kill the program

Expected behavior:

The program is closed properly.

Actual behavior:

Nothing happens, manually killing the process then put that shell in a "bad" state.

Platforms:

Linux Ubuntu 18.04 / Mac OS

Versions:

Monday 1.0.4

That will be great to allow the user to provide a custom folder path containing its monday config files 👍

pkg/proxy/proxy.go:121: "defer target.Close()" causes a panic if "target, err := net.Dial()" (line 114) failed. Missing a break/return/continue statement after "p.view.Writef()" line 116? Or juste add a check for nil pointer in the defer statement?

(unable to reproduce the panic, unfortunately)

Hi,
First time trying Monday, I worked with the installation guide (curl *.sh | sh ) , but the url that is generated is actually:
https://github.com/eko/monday/releases/download/latest/monday-linux-386
When trying to reach the URL i'm getting to a 404 page.

Expected behavior:
Link working :)

Actual behavior:
Link is broken

Platforms:
Distributor ID: Ubuntu
Description: Ubuntu 18.04.3 LTS
Release: 18.04
Codename: bionic

Hi there,

I noticed your documentation serves your one liner script over HTTP, instead of HTTPS. This isn't a good practice, as you're recommending the output be piped directly to sh without any validation. If the connection was some how intercepted, a bad actor would be able to run arbitrary code on the developers box without the developer knowing what exactly was ran.

I'd recommend installing SSL and serving your script over HTTPS. If you need help getting SSL set up, I'd be happy to assist.

Cheers,
Scott

That will be great to allow the user to optionally provide his aliases path instead of adding the alias in .zshrc or .basrc 👍

Also I think it is safe to call source ~/$profile in order to load the newly added alias 😄

Hey! Sorry not a technical issue, I just wondered how this diagram has been created:

Are those just stock icons and some simple app or that was some kind of a studio with lots of stock objects? I'm using OmniGraffle and Sketch for all my diagrams, but sometimes I need something more rich that just a colored rectangle :D

That terminal window frame there is dope. Arrows look like it has been declared programmatically i.e. using dot / postscript.

😅

Simple one: during init on Mint Linux, I see:

command not found: gedit

This is because gedit is assumed. Mint uses xed. Can we make this an ENV, or maybe it could try for both?

When there're multiple kube config file configured via KUBECONFIG environment variable,
monday can see only the default one .kube/config

It seems that https://composieux.fr/getmonday.sh is not found now.
So I installed monday with other method.

Steps for Reproduction

• curl -i https://composieux.fr/getmonday.sh

Expected behavior:

It returns content of getmonday.sh.

Actual behavior:

curl -i https://composieux.fr/getmonday.sh
HTTP/2 404
server: nginx/1.10.3
date: Mon, 05 Aug 2019 02:51:51 GMT
content-type: text/html; charset=utf-8
content-length: 169

<html>
<head><title>404 Not Found</title></head>
<body bgcolor="white">
<center><h1>404 Not Found</h1></center>
<hr><center>nginx/1.10.3</center>
</body>
</html>

Platforms:

macOS 10.13.16

Include browser, operating system and respective versions

Versions:

README in master

I am having some issues running monday on arch linux, while looking through the code base looks like the networkinterface is being hard coded:
/monday/pkg/proxy/network.go:

const (
	networkInterface = "lo0"
)

my loopback interface is set to lo. I changed the constant and ran into some other issues: ifconfig is being used to, some linux distros dont come with net-tools installed (ip is a better choice) but even with net-tools installed it is running ifconfig incorrectly for linux:

args := []string{"lo0", "alias", ip.String(), "up"}

linux should be args := []string{"lo", ip.String(), "up"}

after making all these changes on my local i am still getting this error:

Unable to find an available IP/Port

Looks like its unable to assign a port to ip addresses ( last byte in addr is always off by one so it never assigns a port) in
/monday/pkg/proxy/network.go
if addr.String() == ip.String()+"/8"

This seems to be the issue:

error assignment is missing here:

see:
https://github.com/kubernetes/client-go/blob/fb8b7346aacefea5ee2ab2e234afc4451c90c435/transport/spdy/spdy.go#L46-L51

Hi guys,

When I set up monday with the shell cmd in https://github.com/eko/monday, I got the error as follows:

# curl https://composieux.fr/getmonday.sh | sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1091  100  1091    0     0    432      0  0:00:02  0:00:02 --:--:--   432
-> Determining your OS and architecture type...\n
-> Downloading Monday binary...\n
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   138    0   138    0     0    205      0 --:--:-- --:--:-- --:--:--   205
  0     0    0   609    0     0    398      0 --:--:--  0:00:01 --:--:--  594k
100 26.8M  100 26.8M    0     0    99k      0  0:04:36  0:04:36 --:--:-- 74759
-> Setting permissions on Monday binary (password could be required)\n
-> Setting access to /etc/hosts file for the current user (password could be required)\n
chmod: 无效模式："+a"
Try 'chmod --help' for more information.
-> monday alias has been added in your ~/.bashrc\n
🖥  Monday - version 1.0.1

I checked the issues in this repository, I found this #3.

Someone said the shell script is now up-to-date, but I still come into this problem.
Can anybody help me?

When updating the Monday using curl | sh method on Mac it overwrites my .zshrc file entirely with a single line: alias monday='sudo -E monday'

The +a parameter you use in the README and also in your curl installer script is not available on Linux, this is a Mac only parameter.

I'm running this on ubuntu 18.04 but as far as I know this gives the same error message on other distros:

chmod: invalid mode: ‘+a’

Our company uses okta for authentication. When I try to connect do port-forwarding I get the following error:
❌ No Auth Provider found for name "oidc"

Part of our configuration looks like this:

• context:
  cluster: staging.company.com
  user: okta
  name: staging.company.com

• name: okta
  user:
  auth-provider:
  config:
  client-id: clientid
  id-token: token
  idp-issuer-url: https://company.okta.com
  name: oidc

I was trying to find contribution guidelines to this project. Couldn't find hence opened this issue.