efforg / digitalcitizen Goto Github PK

Where nav items are active, highlight them as seen in this .png.

this wp plugin is throwing an error

not sure if it's important or can be ignored

From Jillian:
"When I upload a featured image, it's supposed to (and sometimes does) carry over to the other connected posts (the translations). This sometimes works and sometimes doesn't, so it's possible there's a certain order in which things need to happen but I'm not sure. Can someone please advise?"

The language link is crashing into the right margin. Indent it by 20px.

Body text links: style as seen in .png: black with 2px blue underline. On hover the link should appear as seen in the “here” link at the top of the page: blue box behind text.

We need to tweak the newsletter plugin to support french.

@mgerring anywhere else in the codebase that we might need to add support for french language?

Can we remove the heading “About”?

There is a 1 px border separating the top nav from the rest of the pages — mostly visible on pages other than Home. Let’s remove so that white is contiguous.

Home page: “Digital Citizen” in 1st paragraph is a link. it shouldn’t be (but should remain black)

Country headings: increase space above by 7px. Reduce space below by 10px.

Sidebar on right: this is sliding down over the bottom section. Seems fine if it stays where it is, but disappears behind the blue AND black sections. Even better is it stops moving when it reaches the blue section.

The Volume txt over the image is crashing into the left margin. Indent it by 20px.

maybe it'll "just work"? or maybe not?

Remove this header from the theme:

Digital Citizen is a monthly review of news, policy, and research on human rights in the Arab World.

Social media icons: these are crashing into the top margin. Set them to the same top margin as the initial text (“Digital Citizen is a…”).

for wordpress plugins that are managed thru wordpress itself, I don't think it makes sense to track these in the git repository. As it is, the site gets out of sync with the git repository.

obviously if we remove them from the repo, we have to make sure they don't get actually removed from production.

Make the Digcit Logo a button that takes you Home.

Volume pager: re-style as seen in .png. Blue bar aligned to the bottom of the page, white text.

Photos and text should have the same margin. Reduce margin of text to match.

Increase space beneath photos by 10 px. Increase space after paragraph by 15px.

“Older Posts” link should share the same margin as main text, and appear in link style.

I just sent a couple of test newsletters and one had arabic first, the other had english first.

I think maybe it depends which post you are looking at when you send?

Can we make sure that the language order is consistent?

@hughillustration: @mgerring said in #13 (comment) that he needs vector social media icons, can you make vector versions of the png?

@mgerring: more from @hughillustration:

Looking good! Thanks for the fixes made thus far. Some changes to the general layout:

Top nav disappears too quickly. Wait until “volume” hits it?

Nav text: highlight text blue instead of blue bg

Language nav: still crashing into top margin. 10 px plz.

Social icons still wrong, see .PNG

EFF logo: it’s become pixelated. Use the version I sent earlier (attached again here).

EFF logo: It appears some text (reads “EFF”) is overlapping the logo in some views.

Social media icons: replace w/ below.They turn black on hover. (Use attached sprite.)

@jilliancyork says she used to only have to set the featured image once and it crossed over to the translations, but today, she had to both upload and set the featured image three times, once per language.

If you look at the HTTP headers for files on digital citizen, the cache times are incredibly long. For example, the style.css file says: Expires:Thu, 31 Mar 2016 08:11:52 GMT

This means that varnish will cache it for a year, and users will see very old versions of the CSS. Is there a way to set these to shorter expiration time, for example a day or an hour would be fine.

Looking good. Some things need adjusting, others never completed. See PNG for what it should look like:

And this copy of the same image has certain items circled in magenta:

1. Nav text: Reduce the size of the nav text to 20px.
2. Nav text: move down by 1px
3. Where nav items are active, highlight them as seen in this .png.
4. The language link is crashing into the upper right margin. Indent it by 20px, lower it by 10px.
5. The Volume txt over the image is crashing into the left margin.
   Indent it by 20px.
6. Social media icons: replace these with the ones I have used.They turn
   black on hover. (Use attached sprite.)
   
7. Social media icons: these are crashing into the top margin. Set them
   to the same top margin as the initial text (“Digital Citizen is a…”).
8. Initial text (“Digital citizen is a…”): Style as seen in .png.
9. Body text links: style as seen in .png: black with 2px blue
   underline. On hover the link should appear as seen in the “here” link at
   the top of the page: blue box behind text.
10. Logo cloud: the logos are crashing into each other. Separate them
    into two rows, as seen in the .png. Use the attached EFF logo in place
    of the one you have used.

to reproduce: go to random url on the site

Uncaught TypeError: Cannot read property 'top' of undefined

Indent the subhead slightly so that it doesn’t crash into the left margin. See attached png.

Reduce size of nav bar text and align bottom of nav bar text with logo text.

Can we disable the pll_language cookie on digcit.org?

This would improve cacheability, as we are putting the wordpress site behind varnish

my humble opinion is that the newsletter should have some kind of header.

It just doesn't look like much of a newsletter as-is.

via @hughillustration:

Text margins on About and Archive are required. At least 7px.

Photos on Archive page should be full width, no margin.

Contribute & Signup: these look terrible in responsive and need to be fixed.

via @hughillustration: Sharing icons should include the link, with all 3 circles in a row. (As it is, the link button turns into text + icon down below)

From Jillian:
"We have invited a new partner to Digital Citizen and would like to have
their logo added amongst the others at the bottom of the site. There's
no major rush on this, and the logo is attached in two different
formats. It should link to apc.org."

Contribute:

Make this look like the attached .PNG.

Signup:

Make this match Contribute.

I am not an expert on wordpress but it looks to me like caching is mostly disabled. Would it be a good idea to enable all types of caching for improved scalability of the site?

via @hughillustration: The Access logo is crashing into the EFF logo in mobile view.

this is what we need for piwik. normally we add action_name=page title so we can record page visits.. we have some php code which injects the page title there.

<noscript><img src="https://anon-stats.eff.org/piwik.php?idsite=16&amp;rec=1&amp;action_name=insert+page+title+here" style="border:0" height="0" width="0" alt="" /></noscript><div style="height: 0; width: 0" id="anon-stats"></div><script type="text/javascript">document.getElementById('anon-stats').innerHTML = '<img src="https://anon-stats.eff.org/piwik.php?idsite=16&amp;rec=1&amp;urlref=' + encodeURIComponent(document.referrer) + '&amp;action_name=' + encodeURIComponent(document.title) + '" style="border:0" height="0" width="0" alt="" />';</script>

Initial text (“Digital citizen is a…”): Style as seen in .png.

screenshot attached.

Logo cloud: the logos are crashing into each other. Separate them into two rows, as seen in the .png. Use the attached EFF logo in place of the one you have used.

The two forms, like the one here: https://www.digcit.org/ar/%D8%B4%D8%A7%D8%B1%D9%83/ show up incorrectly on the Arabic page. I need the translations and I can add it to the translation file.

Someone or something disabled the translation plugin and the entire site is broken. This should be a relatively easy fix but I don't have credentials to the site anymore and I haven't been able to contact anyone to fix it.

the default post except is "Digital Citizen is a biweekly review of news, policy, and research on human rights in the Arab World." This needs to be a translatable string (if it is I don't know how to find it) so that it appears in arabic on arabic pages. The translation is

تقرير المواطن الرقمي هو استعراض للأخبار والسياسات والأبحاث المتعلقة
بحقوق الإنسان والتكنولوجيا في العالم العربي.

Could you document how we should go about apply updates to wordpress core and wordpress plugins?

Will it email us when there is an update?

What's the procedure from there?

While you're at it, would be a good thing to ensure all of this stuff is actually up to date :)