efforg / congress-forms-test Goto Github PK

@Hainish @sinak

Not sure, what we are settling on yet.

retrieve-form-elements looks like it only ask for zip5 even if the yaml directions contains a zip4 action

Some contact forms just have
Mr Mrs

Looks like congress-forms tries to select by [value=""]

Take a look at: http://efforg.github.io/congress-forms-test/?bioguide_id=P000596

The subject says "Subject: subject" and there is no zip+4 field for some reason.

The address_state fields have their values as labels and do not populate the test data properly on the test form. They do, however, submit the appropriate state to the back end, so this is an aesthetic / confusion issue, but not a functionality issue.

missing images/225x275/J000296.jpg

Hey @Hainish, I cannot figure this one out yet

http://efforg.github.io/congress-forms-test/?bioguide_id=B000575

Looks like this guys form submits correctly but server doesn't return success.

Some reps seem to test these values. See this thread.

http://efforg.github.io/congress-forms-test/?bioguide_id=G000555

Looks like it doesn't intelligently select if type="radio"

Cross-post 'cuz I didn't know this repo existed!

http://efforg.github.io/congress-forms-test/?bioguide_id=T000193 as an example, the only state listed in the YAML is MS, but AL gets filled. Shouldn't be an issue in practice, but the state needs to be included/touched for success w/ mechanize so it's listed now.

There is no reason why everything has to be split apart for the testers.

Add git-oauth etc

They can edit yaml and commit from here.

Test there yaml file via browser extension, generate it etc

The bookmarklet grabs the field entries from this file, would be great if the test tool did the same:

https://github.com/unitedstates/contact-congress/blob/master/support/variables.yaml

{
error: "no implicit conversion of Symbol into String ["/home/congressforms/congress-forms/app/models/congress_member.rb:43:in `include?'", "/home/congressforms/congress-forms/app/models/congress_member.rb:43:in `rescue in fill_out_form'", "/home/congressforms/congress-forms/app/models/congress_member.rb:38:in `fill_out_form'", "/home/congressforms/congress-forms/app/helpers/form_fill_handler.rb:15:in `block in create_thread'"]",
run_at: "2014-04-07T10:49:05+00:00"
}

Get this when submitting Rand Pauls captcha

Link type: https://github.com/unitedstates/contact-congress/search?q=B001289&type=Issues

I use HTTPS Everywhere. Now that gihub.io enabled SSL, I get a mixed content warning and a blank page. Even after ignoring the warning on https, I get a blue progress bar and the content refuses to load.
https://efforg.github.io/congress-forms-test/

Manually forcing http circumvents this, but I propose switching all content to SSL.

You can configure github pages to point
efforg.github.io/congress-forms-test to point at

subdomain.domain.com

Any appropiate sub domains? @sinak

Rushed a bunch of code over the past week, will spend a few hours cleaning it up.

For example, this one is wrong: http://efforg.github.io/congress-forms-test/?bioguide_id=U000031

Should be pulled in from relevant YAML file rather than from global list.

I actually had to create a middle man server which lets me bring in the yaml file directly from Github with CORS.

Pretty inefficient, this issue is a reminder to figure out something else.

Currently the workflow for retrying jobs if for the contractor to figure out the problem, then someone with shell access performs:

$  rake phantom-dc:delayed_job:perform_fills[A000001]

And that command will retry all the delayed_jobs associated with that bio_id.

probably a link to the instructions

Minor UI bug: When filling out a form - e.g. http://efforg.github.io/congress-forms-test/?bioguide_id=V000128 - Street Address 2 is required (required="required"), even though the Yaml indicates that street address 2 is not required.

So can throw and listen to events

https://efforg.github.io/congress-forms-test/?bioguide_id=T000461

1. populate fields
2. submit test

@thomasdavis want to tackle this one?

Should we throw DISQUS threads on each congress members page so people can talk about whats going on