Giter Club home page Giter Club logo

check-your-reps's People

Contributors

esoterik avatar k-stewart avatar lenazun avatar lschatzkin avatar vbrown608 avatar wioux avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

check-your-reps's Issues

Fix single quotes in tweet_helper.rb and congress_member.rb

Running rake test spits out some errors, as follows:
`Offenses:

app/helpers/tweet_helper.rb:6:67: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
related: Rails.application.config.twitter_related.to_a.join(',')
^^^
app/helpers/tweet_helper.rb:9:12: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
link_to 'Tweet', url, { target: "_blank", rel: "noopener noreferrer" }
^^^^^^^
app/helpers/tweet_helper.rb:16:10: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
when 'yes'
^^^^^
app/helpers/tweet_helper.rb:17:7: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
'for'
^^^^^
app/helpers/tweet_helper.rb:18:10: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
when 'no'
^^^^
app/helpers/tweet_helper.rb:19:7: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
'against'
^^^^^^^^^
app/helpers/tweet_helper.rb:21:7: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
'undecided'
^^^^^^^^^^^
app/helpers/tweet_helper.rb:29:12: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
].join(' ')
^^^
app/models/congress_member.rb:18:22: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
twitter_id[0] == '@' ? twitter_id : "@#{twitter_id}"
`

Improve database host config

Presently the .env example shows "localhost", but docker requires "db". We should probably make this work natively by default and let this be an optional environment variable for docker.

Erroneous form submit on 'see all reps' button

From the landing page, add a street address to the form field.
Change your mind and click on 'See all reps'
The form is submitted and the 'Please fill out this field' error is thrown. Users should be routed to to the full list page instead.

Design Tweaks

Some design tweaks:

  • top banner is 5rem instead of 3rem
  • Title is not underlined and not bottom-aligned
  • Address and zip box are side-by-side on desktop, in order to cut space.
  • Address box is slightly wider than zip box.
    See mockup.
    thx
    H.

Social medial icons block form inputs

It's not possible to click the form inputs on desktop because they're blocked by transparent parts of the social media icons.

The social media text pullouts could also use a social background. They look strange when there's content behind them.

Design assets

  • header background
  • external link icon
  • checkmark icon
  • table sorting icon

content tweaks from Michelle

  • Add Rep. and Sen. titles to reps names (below images)
    x table: change state to state abbrev (aka CA not California) : DONE
  • table: change CRA position to from "Yes" and "No" and "Uncommited" to Y, N, N/A

Tweet intents

Add tweet intents for individual reps (when the user looks them up) and to the general "view all" reps table

Quieter logs

On the action center, we're using a gem to make the production log both quieter and privater. We should use it here too.

Adjust the Action Center form

The action center embed should be prepopulated with the user zip code and if possible, pre-populated with a relevant topic for every rep

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.