Giter Club home page Giter Club logo

coredatasafeexample's People

Contributors

eelfner avatar

Watchers

 avatar  avatar

coredatasafeexample's Issues

Not sure if this needs to be blocking

Sorry, no way to comment in the code :/

This should not need to be synchronous. Once the private moc has saved to the main we really don't care when the moc writes. It can be now or can be later. It only matters if we crash and that is not the responsibility of the private moc imho.

Kick off an async or don't include the propagated save at all. Just because a child is done doesn't mean it is a good time to halt the UI to write.

sync is bad

DispatchQueue.global(qos: .background).sync {

I would recommend never using sync here. It is just asking for pain down the road.

This should be async and the UI must wait for the persistence layer to be ready. Normally this is < 100ms and not noticeable by the UI. But when a merge or some other long task runs the UI must be able to handle it. Plan for it and when it happens it is not an issue. Don't plan for it and you are asking for a re-write in the future.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.