Giter Club home page Giter Club logo

macos's People

Contributors

efef avatar erikvdwal avatar escobar-qw avatar hypafrag avatar johankool avatar notorca avatar shaanen avatar thenerdfromsiliconvalley avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

macos's Issues

2FA enrollment is not working

When no 2FA is set the QR tag is missing for enrollment, instead you get a textbox where you should enter the 2FA OTP(?).

screen shot 2018-05-09 at 8 22 41 pm

DMG contains developer artifacts

The DMG file contains the eduVPN app as expected, but it also contains these three files:

  • DistributionSummary.plist
  • ExportOptions.plist
  • Packaging.log

These should be cleaned away before building the DMG.

EduVPN to eduVPN

Oi,

eduVPN is written like 'eduVPN' (instead of EduVPN). Since the app is being developed now, it can't hurt to do it right the first time, instead of changing it afterwards :-)

tunnelblick OpenVPN version

It seems Tunnelblick offers you the choice of OpenVPN 2.3.x or OpenVPN 2.4.x. The eduVPN app for macOS MUST use OpenVPN 2.4.

Delete VPN profile doesn't work correctly

Due to issue #78 I have an non working profile.
When deleting the VPN profile, add manual the same server, authenticate and approve the token download. The 'new' profile still can't connect. It looks like as-if the delete wasn't fully done. Server-side there hasn't been created a new config.
Issue might be related to isue #78

App has trouble getting to the foreground from the Status bar menu

When I use the status bar menu to open the preferences dialog, the dialog appears below all my active windows. This is especially problematic when I have Show in Dock disabled, because then I need Exposé to find the preferences dialog.

Using the Dock icon everything works as expected.

No VPNs available when app is started without internet connection available

It seems that eduVPN requests a lists of available VPNs when it starts, because when I start it without an internet connection, I see this:

Empty eduVPN window

A workaround is to fix the internet connection and restart the app.

I think it would be better if the client caches the list of VPNs, so that it doesn't have to be restarted.

make it possible to delete a profile

Apparently it is only possible to add profiles, and never to delete them. Implement delete. If this was already implemented, my excuses. I don't have the ability to test with macOS.

expired refresh token

When refresh token expires or was revoked then a user should re-authenticatie via OAuth.
At this moment the user will get an error message (see screenshot)

screen shot 2018-03-14 at 16 25 14

This can be tested by disabling the authorization in the webinterface.

disconnect - connect errors

When I disconnect a running session and quickly re-connect. I get strange errors. Sometimes the connection disconnects within a second. Sometimes error notifications.
screen shot 2018-09-28 at 15 44 14
screen shot 2018-09-28 at 15 46 05

Work in "master"

Normal development takes place in master. Currently master is empty.

do not "hang" without feedback

When the server is slow to respond, or not available the user loses control over the UI and is unable to cancel the action.

  • allow user to at all times "cancel" connection attempt to avoid having an UI that is "stuck"
  • give appropriate feedback when trying to connect / what is going on
  • display error when connection fails

oauth token revoking - unable to retrieve new token

In the Web application an user can revoke the Oauth token by clicking "intrekken" see screenshot:
screen shot 2018-09-28 at 16 06 39 copy

At the next connect of the app, the app should be able to retrieve a new Oauth token. Somehow the token never reaches the app, and the webbrowser status is “waiting for 127.0.0.1”.
screen shot 2018-09-28 at 16 02 39

Keep Changelog

Now there is no way to know what changed between releases.

AAAA records are not resolved if the underlying connection doesn't have IPv6

Possibly related to #39.

When I'm on a network without native IPv6 available and I connect to a eduVPN instance with IPv6 available, the default resolver will still not try to resolve IPv6 addresses. Illustration:

% curl v6.myip.tf
curl: (6) Could not resolve host: v6.myip.tf

% host v6.myip.tf
v6.myip.tf has IPv6 address 2001:19f0:5001:229:80::1
v6.myip.tf has IPv6 address 2001:19f0:7001:1031:80::1

% curl 'http://[2001:19f0:5001:229:80::1]'
2001:700:0:4108::1001

As we can see, IPv6 connectivity works fine but only if I use IPv6 addresses directly. Connections to IPv6-only hostnames will fail and connections to dualstack hostnames will go over IPv4. This applies to both Firefox and Safari. ping6 and traceroute6 work, also when given a hostname.

Expected behaviour:

% curl v6.myip.tf
2001:700:0:4108::1001

This works if the underlying connection supports IPv6.

Difficult to find eduVPN window when opened on fullscreen space

Somewhat related to #44.

When the app is opened through Spotlight from a fullscreen space, while the Dock icon is hidden in the preferences, eduVPN will appear behind the fullscreen window and will not be moved to a free space, even if «Show eduVPN…» is selected from the menu bar.

The only two ways to get hold of the eduVPN window is to restart eduVPN, or to select «Show eduVPN…», move away from the space and then move back to the space where it was originally started.

back button not working

After a few connects/disconnect to the frkovpn VPN the back button (top left) isn't working. I can still "connect", but can't go back.

screen shot 2018-09-28 at 10 57 21

remove country VPN profile "distributed mode"

The "distributed" mode means an OAuth token can be used to get a VPN profile/config in other countries. In the app the "-" symbol indicates I should be able to delete a single country, however I can only delete "the netherlands". When I delete .NL all countries disappear.
screen shot 2018-10-09 at 22 56 20
This is not a real bug, but more cosmetic issue.

releases | master branch | changelog

It would be great to have releases and release notes (changelog). This would mean:

  • merge all outstanding (dev) branches in master before making a release;
  • tag every release that we build and distribute to end users;
  • create a changelog showing the difference between the versions;

To create a changelog, you can see the examples in the Windows and Android repositories, i.e. https://github.com/Amebis/eduVPN/blob/master/CHANGES.md and https://github.com/eduvpn/android/blob/master/CHANGES.md

unable to install helper

Made the "Let's Connect!" build of the release/1.1a1 on my system. It does seem to (almost) work except connecting. Maybe I'm doing something wrong?

image

disabled by admin - gives "unexpected state error"

As administrator you can disable users in the webportal. I disabled myself, disconnected the VPN and tried to connect. The result was :
screen shot 2018-09-28 at 16 36 04

Second time I got redirect to webpage, which mentions I was disabled (that's good).

invalid refresh token -> app crash

When the refresh token is revoked. The user will be send to the webinterface when trying to connect. Next an user clicks "approve" -> the eduVPN app will crash. It seems the local webservice isn't started (correctly).

custom URL field usability

I is a "textarea" at the moment and doesn't show any hint you need to add https:// in front.

Proposal: make it 1 line, and always add https:// so only ask the user to provide the hostname. This is the same on the other platforms.

chrome doesn't work

When changing my default browser to chrome and choose "institute access" - DEMO the chrome browser opens an empty browser tab.

screen shot 2018-02-21 at 14 47 40

"connection in unexptected state" message

When trying to connect the VPN to country Ugunda (high latency). After clicking on "connect" the app doesn't respond (that's how it experiences) after a few seconds I click again on 'connect'. A few seconds later the connection screen appears and an error message appears (see screenshot)
Strangely the VPN will get connected and the icon changes to 'green'.
screen shot 2018-06-07 at 12 21 33

OAuth client ID

The current client_id is org.eduvpn.app. Please start using org.eduvpn.app.macos. Everything else related to OAuth stays the same.

tray and dock icon always same color

Currently the eduVPN icon in tray and in dock have always the same color.
Dock color is orange and in tray it's grey. At least the tray icon color should change depending of the connection status. From red (disconnected), yellow (connecting) to green (connected)

DNS resolver wrong when exit client

When a VPN session has been established and the user immediately shutdowns the eduVPN client, the local recursive nameserver setting (/etc/resolv.conf) doesn't always return to the correct recursive nameserver.

I have the impression that this also occurs when normal stopping the VPN connection.

Tag releases

Tag the exact release that will be published for users to download / use. So we know which code is actually used.

delete configuration server side - client doesn't create new configuration

test condition:
-running client - VPN is started successfully
-delete server side the available client configuration (...vpn-user-portal/configurations)
-client after a while redirects to authentication page WRONG
-clients adds a second server profile WRONG

correct behaviour:
-client should automatically create a new valid configuration (as defined in api.md)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.