edgi-govdata-archiving / 100days Goto Github PK

Re-ticketed from #53

ULs and the sub- and sub-sub-headings in the ToC are at 1rem font size, rather than the 1.1rem the main body is. Can we make font size consistent in the body and the ToC at least as large as body copy?

Re-ticketed from #53

review commented out sections

Moving from Slack (https://edgi.slack.com/archives/C3EF5T7T6/p1497259423181120):
the report is distributed with https:// in the url, we need to make sure that works when visiting the site.

@patcon -- you dug up that gist: https://gist.github.com/cvan/8630f847f579f90e0c014dc5199c337b
Can you tackle this asap? I'm out until Monday but can revisit then

I think it would be good to give people "follow/hear more" hooks direct from 100 days, see edgi-govdata-archiving/edgi-website#40 as an example for the main website

1. set up permalinks/redirects (addressed in #52)
2. update name of peer reviews to match the first part (addressed in #52)
3. The “DATA METHODOLOGY” nav link points to “pursuing-toxic-agenda-data.html”, but we used just “pursuing-toxic-agenda-data” in the PDF. Are we going to use both and add a redirect? (addressed in #52)
4. FN 58 it says Colby Texas and it should say Crosby Texas. Is it too late to do anything about this? (addressed in #54)
5. fix link to the second pdf (addressed in #54)
6. Colby to Crosby is fixed online. (addressed in #55)
7. The peer reviews page for Part 2 uses Part 1 image (addressed in #55)
8. report peer review: fix the background image to part 2 main image (addressed in #55)
9. on all subpages clear links back to the report main page and check it work (currently returning an error) (addressed in #56)
10. The bottom of the Interview has this text: “EDGI_Logo-1_Hi-Res_Transp.png
    Pursuing a Toxic Agenda” (addressed in #56)
11. data page: the logo isn't appearing at the bottom of the page (addressed in #56)
12. on the data page, @shaq and @wyliesara should be added as authors (addressed in #56)
13. all part 2 links have the Google Docs wrapper, this should be removed (i.e., https://www.google.com/url?q= at the beginning and a trailing &amp... unique per link) (addressed in #58)
14. data chance page title and nav reference to "data methods" (addressed in #58)
15. responsive image sizing fixes (addressed in #58)
16. on the mustafa ali interview page the boxes are out of alignment over the image (addressed in #56)
17. on main page the header image is being overwhelmed by the second text box appears resolved?
18. PRIORITY Colby to Crosby is in the pdf-- this needs to be reuploaded Uploaded 2:30pm Sept 19 on envirodatagov.org
19. fix the alignment on the data page title (addressed in #58)

bugs/features

1. PRIORITY Scaling of images/tiles on homepage and Toxic Agenda pages not working correctly on Safari and Chrome on OSX (addressed on 65)
2. PRIORITY Footnote 58 has been corrected in the PDF and it needs to be reuploaded done by @patcon at 5:41pm Sept 19
3. PRIORITY All links to the interview in the report need to be fixed; all either 404 or do nothing #59
4. Fix alignment of author byline on Part II report page, so it's not cut off at smaller screen widths moved to #70
5. The header/subheader/sub-subheader styling hasn’t been added (all are all-caps) DUP of (12) below
6. The Chlorpyrifos map key covers a lot of the map and info box on mobile (worth hiding on mobile?) migrated to #72
7. data on the data page bold the figure numbers so it's clearer which paragraph is about which figure #60 (and #58?)
8. data also on the data page add links to the relevant figures #60 (and #58)
9. Add link from the text “interview with Mustafa Ali” right before the ToC. (addressed in #59)
10. Add Interview to icon nav menu (addressed in #59)
11. the visual links to the interview and part 1 aren't appearing at the bottom of the report page? migrated to #78
12. data The header/subheader/sub-subheader styling hasn’t been added (prelim address in #60) migrated to #71
13. There are some extra files we need to trim (imageN vs. part2figureN) migrated to #77
14. Images are not compressed, might want to include 2x scaling for hires migrated to #76
15. re-enable disqus comments migrated to #75
16. data add data to github and link from data methods page migrate to #74
17. review commented out sections migrated to #73

style/ux

1. Request from Sara: can we float the icon nav menu so it stays visible as the page is scrolled? #79
2. data figure numbers at begin of paragraphs should be bolded but I can live without it #60
3. There’s a stray extra linebreak or two. Maybe one of us should address minor formatting glitches in a PR? #80
4. on peer reviews distinguishing between the review and our revisions #81
5. on both the part 2 and the ali interview page there should be a link back to the overall first 100 days report somewhere, right now the EDGI link takes you there but that should probably take you the main EDGI site? #82
6. the anchor links for the references are slightly off, so if you link to a reference you have to scroll up to see the number referenced. #83
7. Treatment of report page cover image/title not consistent on Part I and Part II (should we just use same layout for Part I as Part II?) #84
8. ULs and the sub- and sub-sub-headings in the ToC are at 1rem font size, rather than the 1.1rem the main body is. Can we make font size consistent in the body and the ToC at least as large as body copy? #85
9. I really think it aids readability of sections if there is more space around subheadings, and especially before them. Ideally, there’s slightly more space above a section heading than below it, so that the heading is visually associated with its content. There’s a lot of space before main headings, which is nice; would be good to add more around sub- and sub-sub-headings, too. #86
10. I think it’s nice to add a little space before/after figures/images, so they’re more distinct from copy. #87
11. Should we consider linking to larger versions of the figures and tables from each, in case anyone wants to zoom in? #88
12. Should we increase the offset of ULs so they stand out a bit more from body copy? #90
13. Should we use same link styling in this site as we do on main EDGI site? No underline and different hover effect? #89
14. If the EDGI logo at top-left is the nav element to the 100 Days homepage, it might be nice to have a link somewhere (just on homepage?) back to main EDGI site #82

questions

1. If I zoom out enough on the Chlorpyrifos image to see the whole country, it become a dot map (on desktop and mobile). Is that intended?
   • This is a limitation of google fusion tables

Figures in the 100 Days drive here: https://drive.google.com/drive/folders/0B1eR9Fjlv3o6S3ByQ3dna19jc3c

Re-ticketed from #53

on both the part 2 and the ali interview page there should be a link back to the overall first 100 days report somewhere, right now the EDGI link takes you there but that should probably take you the main EDGI site?

If the EDGI logo at top-left is the nav element to the 100 Days homepage, it might be nice to have a link somewhere (just on homepage?) back to main EDGI site

Re-ticketed from #53

There are some extra files we need to trim (imageN vs. part2figureN)

Reticketed from #1 (review)

EDGI logo makes sense but probably we want some kind of a cover image as well?

cc: @titaniumbones

naming, etc. could be improved for screen reader software

Re-ticketed from #53

Request from Sara: can we float the icon nav menu so it stays visible as the page is scrolled?

Re-ticketed from #53

data add data to github and link from data methods page

Just realized the logo on the stop left doesn't display in FF (comparison with chrome)

I'm wondering if the issue is the path in post.css:
https://github.com/edgi-govdata-archiving/100days/blob/master/assets/post.css#L257

(and related to eventual v. expected deployment)

Our process got ugly on NameCheap.

There are two options that come to mind:

1. nshapiro suggested namecheap's git deploy method: #22
2. Host jekyll site on heroku. there's a way to do this: #33
   • SSL instructions: https://devcenter.heroku.com/articles/custom-domains#add-a-custom-domain-with-a-subdomain (down-side is need to redo)
   • heroku has review apps for easy review of changes without building locally. this seems like it would be rad to including other non-tech folks in pull request review process. seems a big plus. https://devcenter.heroku.com/articles/github-integration-review-apps

Re-ticketed from #53

the visual links to the interview and part 1 aren't appearing at the bottom of the report page?

Re-ticketed from #53

Should we consider linking to larger versions of the figures and tables from each, in case anyone wants to zoom in?

Re-ticketed from #53

The header/subheader/sub-subheader styling hasn’t been added (all are all-caps)

data The header/subheader/sub-subheader styling hasn’t been added (prelim address in #60)

We should update the readme to cover steps to deploy, as we got more of these coming down the pipe!

Re-ticketed from #53

Should we use same link styling in this site as we do on main EDGI site? No underline and different hover effect?

Re-ticketed from #53

the anchor links for the references are slightly off, so if you link to a reference you have to scroll up to see the number referenced.

From @patcon in edgi-govdata-archiving/edgi-website#41 (repo for main EDGI site):

See: https://100days.envirodatagov.org/epa-under-siege.html

On a high-resolution screen (like a 4K) or when zooming out to a comparable degree via browser controls, the bottom of the page starts displaying very oddly, with tons of whitespace and a jumpy, glitchy scrollbar. By the way the glitching happens, it might be related to the "Back to Appendix Themes" button that hovers when at the bottom of page.

cc: @dcwalk

From Slack conversations (https://edgi.slack.com/archives/C4ER5PRD0/p1497857485718831):

Looks like we can pull from GitHub directly to the server, there may be reasons not to, but we can can/should discuss!

https://www.namecheap.com/support/knowledgebase/article.aspx/9586/89/how-to-deal-with-git-on-our-shared-servers

Reticketed from #32

https://rtyley.github.io/bfg-repo-cleaner/

Biggest image is 1.3MB, so anything over 2MB is probably something we could strip out (?)

Blocked on #33 bc existing PRs will break after this

@shaqsingh was lamenting over drinks the lack of analytics on the 100days site. I will admit she was torn about wanting them, but not liking trackers (if i'm remembering correctly).

We floated the idea of self-hosting analytics, of which I'm aware of Piwik.

Perhaps we should instead open an issue in overview repo on formulating a general analytics policy?

Related issue for EDGI website: edgi-govdata-archiving/edgi-website#27

Conversation in Slack RE: more social sharing, suggestion to add basic OG metadata, especially the image!

Re-ticketed from #53

The Chlorpyrifos map key covers a lot of the map and info box on mobile (worth hiding on mobile?)

Re-ticketed from #53

on peer reviews distinguishing between the review and our revisions

Not able to load CC license image:

I think the best fix is to add to assets instead of loading remotely, but that tends to be my preference. Any thoughts @shaqsingh and @patcon

These definitely aren't issues but just a couple ideas for quick updates that might be nice:

• Make the words "download the PDF" a link to the PDF as well, on this page: https://envirodatagov.org/publication/the-epa-under-siege/, just for folks that aren't familiar with the PDF viewer and which button is the download.

• Space the whole report out a bit more, for easier reading (between paragraphs and around pullout quotes), but especially add and standardize spacing before section headings. If we could use the same spacing that we do above "IX. APPENDIX: INTERVIEW COMPENDIUM" above the other section headings, it'd be nice to be consistent and seems like that spacing works a bit better.

• Match the formatting of the figure captions to that of the table caption, which is indented from the body copy. Would be nice to be consistent and that seems to work a bit better to delineate the caption from the body.

EDIT: @patcon turned into checklist

Re-ticketed from #53

Fix alignment of author byline on Part II report page, so it's not cut off at smaller screen widths

I recall with the first chapter there were some visualizations where data processing happened (can't remember if those got cut.

It would be neat in future chapters if we could link from the report to our scripts and document data sources (and seems very EDGI 🥇 to me).

Would that make sense @shaqsingh?

Re-ticketed from #53

Images are not compressed, might want to include 2x scaling for hires

link to bios of contributors

Re-ticketed from #53

I think it’s nice to add a little space before/after figures/images, so they’re more distinct from copy.

Twitter/facebook share button on the reports might be nice so readers can quickly share, as they would with a news article.

There are some different reasons to

Re-ticketed from #53

Treatment of report page cover image/title not consistent on Part I and Part II (should we just use same layout for Part I as Part II?)

Re-ticketed from #53

Should we increase the offset of ULs so they stand out a bit more from body copy?

Re-ticketed from #53

I really think it aids readability of sections if there is more space around subheadings, and especially before them. Ideally, there’s slightly more space above a section heading than below it, so that the heading is visually associated with its content. There’s a lot of space before main headings, which is nice; would be good to add more around sub- and sub-sub-headings, too.

from #65 and .section --

Does this need to be so tall? I feel like we are getting some odd length issues on small screens (i.e. this could be much more compact.) Probably doesn't belong in this PR so I can open an issue

I'm wondering if we could shorten the max-height and probably adjust the background-position to better feature elements of each image.

Looks like we aren't using https for JS loads (and maybe we want to serve locally anyway): https://github.com/edgi-govdata-archiving/100days/search?utf8=%E2%9C%93&q=script&type=

Convo from:
https://edgi.slack.com/archives/C4ER5PRD0/p1497883588497433

I think related to #4

I think an issue with relative path is causing this console error:

Can fix here I think: https://github.com/edgi-govdata-archiving/100days/search?utf8=%E2%9C%93&q=assets%2FCH1.png&type=

Re-ticketed from #53

re-enable disqus comments

• log-in and confirm settings? (generate new comment sections)
• share/add EDGI gmail as acct manager?

I'm moving @patcon's comments from #41 over here:

wonder if we should think a bit more about the title for SEO...?
Here's how we currently show up in Google search results:
![screenshot of 100 days report search result][https://imgur.com/UWZdMKD.png)
Note that there is nothing about "environment" in the words that show there. This is probably something to avoid? Perhaps we could either expand "EDGI" or add a secondary title mentioning what the 100 days site is?
I was using this "preview" tool here to see what some things looked like:
https://moz.com/learn/seo/title-tag

After some fidgeting around, this seemed to be a decent option:

100 Days and Counting - An environmental report series | EDGI

Re: "-" vs "|". No solid pref, but bar seems to take up less space, assuming search engines are clever and consider the width of characters when choosing what to display. Mozilla also seems to recommend "-" for separate primary and secondary titles, and "|" for separating the brand.

@re: prev "The First 100 Days and Counting" vs new "100 Days and Counting". It seems that the new titles perhaps needlessly uses up valuable characters in the search results, which are perhaps better used on a secondary title mentioning the environment? Might we be able to use "100 Days and Counting" just in the title, to conserve space?

Could we ditch the "part 1" in the header? I know it's important to us, but unsure if it's important to people who might see it in search results, so perhaps a distraction?

Thoughts on something like this?

"EPA Under Siege - Part of an environmental report series | EDGI: 100 Days and Counting"

See: https://github.com/edgi-govdata-archiving/100days/search?utf8=%E2%9C%93&q=%3Clink+rel%3D%22canonical%22+href%3D%22http%3A%2F%2Flocalhost%3A4000%2F%22%3E&type=

I think we need to rebuild static and ensure we are only pulling down the static site, not templates to productions

Re-ticketed from #53

There’s a stray extra linebreak or two. Maybe one of us should address minor formatting glitches in a PR?

Per conversation in #27 and in Slack, we should move to a more idiomatic use of Jekyll in advance of the remaining chapters publication!

Looks like the horizontal alignment isn't working quite as intended for the Peer Reviews section; I believe image should center and scale with charcoal background, as it does on main report page.

FF 54 beta on Linux. No obvious error messages in console so I think some JS isn't firing. Looks fine on Chrome on same machine.