edequartel / louis Goto Github PK

Audio files are separated in characters which you can find in phonetic and in words.

screenshots are cluttered all over the place. Organise them with a folder.

Make the repo more scalable by making it a mono repo

Put the app contents in a app folder.

I think this should be done before solving #16

setting up website within github

the screenshot in readme.md is dead. Therefore changing this link.

Move long sounds in zip to words folder

Make the repo public.

• sign your commits
• choose your license
• Add signed commits branch protection rule.

Audio for German and English. see if the audiofiles have to proceed with a language identifier or by a folder or bundle name.

when in airplane mode json file is downloadable and therefore data is corrupt.

download and update audio as a zip and install them local. see repo gzip

see https://designcode.io/swiftui-advanced-handbook-download-files-locally-part-1 for source download manager

also look at realm

These longSound separators are now only for Dutch has to be implemented in the JSON file
let separators = ["eeuw", "sch", "eeu", "ij", "ooi", "aa", "ui", "oo", "eu", "ei"]

Instead of array enumeration

I was wondering what the best way was of testing the app.

Do you connect the braille display to the laptop and use VoiceOver on the Mac to test if it works? Or do you build to an iPhone and connect the braille display with that device?

Best regards.

Audio files are not included in the Xcode project.

This makes it hard for new contributors to set up a development environment.

Currently you cannot get it running by just cloning the repo.

When getting in the routine the first time the initial value of item is taken.
When this file is taken and does not exists the value is unspoken.
When checking on the existing of this file is does not get out of the routine.
This check is needed if by accident a file does not exists and is in the json.
So two bugs.
1. non spoken first word (not init)
2. hangs if first word is not found and looking for file existence.

Check the number of folder and leave one or a notification in downloadView()

change the license to gnu public

edit listen() function where character is a word with length 1

This is a wish but it has issues in user interaction when using SwiftSpeech packager.

1. non conditional, focus stays on button, fingers are on brailledisplay, after a spoken word the next wordt is shown on the button
2. conditional, speak the word on the brailledisplay and when it is the same the next is shown otherwise a error sound is heard.

When pronounceType == .child and case != lowerCase words are separated in single characters and not in phonem

The files in the folder phonetic/child phonetic/adult and phonetic/form need all a prefix.

See let prefixPronounce = ["child_","adult_","form_","form_"] in PlaygroundView.swift

dont use appstorage saving persistent user values

see https://medium.com/geekculture/swiftui-tutorial-persistent-data-using-userdefaults-and-appstorage-c17a94e131cf

Crashes when changes method in settingsview, could be to do with changing or nrof lessons.
When changed from braillepi where alfabet is chosen and the mpop method the app crashes.

The index to
methods[n].lessons[m] m is to large and not checked.

optionals is the answer

In github pages and markdown

This appears when from the given letters not more then 1 audio files is found.
This can happen when the methods.json file is not written with the right letters record.

When changing language and the lesson is high to a basic methode app crashes

Make a class instead of struct for json file.