ed33 / rcsjta Goto Github PK

CR_004: Removal of un-necessary RCE-e APIs
From Qualcomm

Thumbnail not saved in database in case of terminating side

But done in originating side.

What steps will reproduce the problem?
1.when i use RI application , sharing --> geoloc sharing and choose show us in 
map it gives me error : no geoloc info to display , also when i tried to 
initiate geoloc sharing and invite another joyn contact the request didn't 
reach him , is there is specific configuration need to make Geoloc sharing and 
showing work , GPS or SIM card (i'm already connected to internet and GPS)?




What version of the product are you using? On what operating system?
Android : 2.3

* Removing RCSe raw contacts after SIM swap
  and disabling the RCSe icons from contact
  detail screen.
* Added Utility methods to check if RCSe is
  provisioned or not.

When session is terminated client doesn't performs OPTIONs exchange

03-27 11:36:41.145: W/InputMethodManagerService(596): Window already focused, 
ignoring focus gain of: 
com.android.internal.view.IInputMethodClient$Stub$Proxy@43249e50 
attribute=null, token = android.os.BinderProxy@433ef868
03-27 11:36:42.246: W/System.err(12867): java.lang.NullPointerException
03-27 11:36:42.246: W/System.err(12867):    at 
java.io.File.fixSlashes(File.java:185)
03-27 11:36:42.246: W/System.err(12867):    at java.io.File.<init>(File.java:134)
03-27 11:36:42.246: W/System.err(12867):    at 
com.orangelabs.rcs.platform.file.AndroidFileFactory.getFileDescription(AndroidFi
leFactory.java:78)
03-27 11:36:42.246: W/System.err(12867):    at 
com.orangelabs.rcs.service.api.FileTransferServiceImpl.transferFile(FileTransfer
ServiceImpl.java:304)
03-27 11:36:42.246: W/System.err(12867):    at 
com.gsma.services.rcs.ft.IFileTransferService$Stub.onTransact(IFileTransferServi
ce.java:117)
03-27 11:36:42.246: W/System.err(12867):    at 
android.os.Binder.execTransact(Binder.java:404)
03-27 11:36:42.246: W/System.err(12867):    at 
dalvik.system.NativeStart.run(Native Method)
03-27 11:36:42.246: E/JavaBinder(12867): *** Uncaught remote exception!  
(Exceptions are not yet supported across processes.)
03-27 11:36:42.246: E/JavaBinder(12867): java.lang.RuntimeException: 
com.orangelabs.rcs.service.api.ServerApiException
03-27 11:36:42.246: E/JavaBinder(12867):    at 
android.os.Parcel.writeException(Parcel.java:1362)
03-27 11:36:42.246: E/JavaBinder(12867):    at 
android.os.Binder.execTransact(Binder.java:410)
03-27 11:36:42.246: E/JavaBinder(12867):    at 
dalvik.system.NativeStart.run(Native Method)
03-27 11:36:42.246: E/JavaBinder(12867): Caused by: 
com.orangelabs.rcs.service.api.ServerApiException
03-27 11:36:42.246: E/JavaBinder(12867):    at 
com.orangelabs.rcs.service.api.FileTransferServiceImpl.transferFile(FileTransfer
ServiceImpl.java:330)
03-27 11:36:42.246: E/JavaBinder(12867):    at 
com.gsma.services.rcs.ft.IFileTransferService$Stub.onTransact(IFileTransferServi
ce.java:117)
03-27 11:36:42.246: E/JavaBinder(12867):    at 
android.os.Binder.execTransact(Binder.java:404)
03-27 11:36:42.246: E/JavaBinder(12867):    ... 1 more

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


Please use labels and text to provide additional information.

What steps will reproduce the problem?

A invite B for a chat. The P-Asserted-Identity in the message header of the SIP 
INVITE includes the display name as in the below example:

P-Asserted-Identity: "+33640174187" <tel:+33640174187>

What is the expected output? What do you see instead?
The invite is accepted.
A null exception occurs. The invite is discarded.

Please use labels and text to provide additional information.

CR_004: Removal of un-necessary RCE-e APIs
from Qualcomm

Blocking capabilities exchange with own self.

[deleted issue]

according to RFC 2616, section 14.16 the Content-Range header must contain an 
element bytes-unit

This is missing in HttpUploadManager.sendPutForResumingUpload():
change 
<<<connection.setRequestProperty("Content-Range", (resumeInfo.getEnd()+1) + "-" 
+ (content.getSize()-1) + "/"
                + content.getSize());
to
>>>connection.setRequestProperty("Content-Range", "bytes " + 
(resumeInfo.getEnd()+1) + "-" + (content.getSize()-1) + "/"
                + content.getSize());

The list of local provisioning files should only display config files and NOT 
other xml files from the SDCARD.
A filter should be added.

FileTransfer AutoAccept in Roaming

* IsAutAcceptFt - To check whether auto
  accept feature is enabled or not. When the device
  is provisioned with FT auto accept parameter, we
  have this db value as true. If we didn't get any
  info about autoaccept during provisioning it is
  as false.
* AutoAcceptFileTransferInRoaming -
  User option to enable or disable
  auto accept for filetransfer in roaming, even though
  we feature is enabled during provisioing. To enable
  auto accept in roaming, this parameter along with
  IsAutoAcceptFt has to be true

Branch name: quit-gc

https://code.google.com/p/rcsjta/source/detail?r=606fb90ca3071d21c154327fd4b679e
30e3b70ee&name=quit-gc

Purpose of code changes on this branch:
add possibility to quit a GC even if idle

When reviewing my code changes, please focus on:
quitConversation method is kept on the IGroupChat interface. Check if it 
possible to improve code by removing the quitConversation from this interface ?

After the review, I'll merge this branch into:
/integration

What steps will reproduce the problem?
1. Initiate message, session not established.  
2. Initiate another message again 
3. Wait till message gets deliver to the receiver side, but no message 
delivered to the other side as session still not established.  

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?
Android, kitkat

Please provide any additional information below.

Stack ignores the messages if MSRP Session didn't established.

CR_004: Remove Presence API from Qualcomm

Removal of un-necessary RCE-e APIs

[deleted issue]

Branch name: cr10-ic91

Purpose of code changes on this branch:
management of GC participants

After the review, I'll merge this branch into:
/integration

Note:
The method getGroupChatConnectedParticipants() in RichMessagingHistory is 
called to invite missing participants. It needs to be tested (I could not do 
test it with the current platform). To be done before merge into integration 
branch.

CR_004: Removal of un-necessary RCE-e APIs
From Qualcomm

CR_002: Delete the SIP API
From Samsung

Delete the SIP API section from the specification. SIP is used by RCS, but it 
is in no way defined in RCS specification and it is therefore out-of-scope to 
expose it as part of joyn Terminal APIs. Moreover such an API is already is 
covered defined by existing platforms (e.g. Google has one in Android). Also, 
such a low-level API must be covered by a higher security level exception or a 
dedicated “RCS Client API” and not a general “3rd party API”

What steps will reproduce the problem?

Terminating 1-1 Chat session in case of auto chat accept

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?
Android, Kitkat

Please provide any additional information below.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


Please use labels and text to provide additional information.

Vertical scrolling not working in javadoc documentation

In case of auto chat accept when A-Party send a sip invite and is received by 
stack on B-Party inside TerminatingOne2OneChatSession.java class run method, 
then it is not sending 180Ringing back to the sender side.

But in case of manual chat accept stack is calling 
"send180Ringing(getDialogPath().getInvite(), getDialogPath().getLocalTag())" 
method to send 180 ringing to A-Party


What is the expected output? What do you see instead?
Stack should also send 180 ringing in auto chat accept 

What version of the product are you using? On what operating system?
Android, Kitkat

Please provide any additional information below.

The template for local provisioning is not Blackbird compliant because there is 
no "SERVICES" declaration in the XML declaration. And "SERVICES" is used to 
determine if it's BB or Albatros.
Then it will be nice to have the possibility to modify the GSMA release from 
the local provisoning also.

W/System.err( 5756): java.lang.NoSuchMethodException: 
addServiceRegistrationListener []
W/System.err( 5756):     at 
java.lang.Class.getConstructorOrMethod(Class.java:472)
W/System.err( 5756):     at java.lang.Class.getDeclaredMethod(Class.java:640)
W/System.err( 5756):     at 
com.gsma.services.rcs.JoynService.callApiMethod(JoynService.java:144)
W/System.err( 5756):     at 
com.gsma.services.rcs.JoynService.addServiceRegistrationListener(JoynService.jav
a:232)
W/System.err( 5756):     at 
com.sonymobile.im.environment.ImEnvironmentManager.onPossibleApiConnectionStatus
Change(ImEnvironmentManager.java:236)
W/System.err( 5756):     at 
com.sonymobile.im.ImApiHolder$RcsCapabilityServiceListener.onServiceConnected(Im
ApiHolder.java:89)
W/System.err( 5756):     at 
com.gsma.services.rcs.capability.CapabilityService$1.onServiceConnected(Capabili
tyService.java:115)
W/System.err( 5756):     at 
android.app.LoadedApk$ServiceDispatcher.doConnected(LoadedApk.java:1123)
W/System.err( 5756):     at 
android.app.LoadedApk$ServiceDispatcher$RunConnection.run(LoadedApk.java:1140)
W/System.err( 5756):     at android.os.Handler.handleCallback(Handler.java:733)
W/System.err( 5756):     at android.os.Handler.dispatchMessage(Handler.java:95)
W/System.err( 5756):     at android.os.Looper.loop(Looper.java:216)
W/System.err( 5756):     at 
android.app.ActivityThread.main(ActivityThread.java:5151)
W/System.err( 5756):     at java.lang.reflect.Method.invokeNative(Native Method)
W/System.err( 5756):     at java.lang.reflect.Method.invoke(Method.java:515)
W/System.err( 5756):     at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:868)
W/System.err( 5756):     at 
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:684)
W/System.err( 5756):     at dalvik.system.NativeStart.main(Native Method)
E/ImEnvironmentManager( 5756): onPossibleApiConnectionStatusChange(242): 
Exception occured addServiceRegistrationListener []

For the MultimediaSession to work in RCS network we need to add
the IARI to the SIP registration.
Added the IARI from the intent filter with action
"com.gsma.services.rcs.capability.EXTENSION" and mimeType the IARI
to the SIP registeration

CR_006: Remove platform-specific definitions
From Summitech

This proposal serves to remove the platform-specific features from the formal 
API. An android specific document can present the Android specialization of the 
API.

[deleted issue]

CR_007: Clarification on remote URIs
From Summitech

Added new methods to expose phone number to URI normalization in the API. 

For example the class IMessagingAPi.Stub should not be displayed in Javdoc, 
only the class MessagingApi is used by implementors.
The same for these other API.

CR_003: Delete the Presence API
From Samsung

Presence is optional and it is almost not deployed for RCS in practice. The 
authors believe that proposing such an API now would give a wrong message to 
3rd party developers about what type of service RCS can provide and would lead 
to confusion. It is therefore proposed to remove Presence from this first 
version of specification, and to add it once it is ensured that there is 
sufficient deployment and market need for it.

When the RCS-e stack receives a non-RCS SIP INVITE, the dispatcher rejects the 
request with SIP 606 response (See 
com.orangelabs.rcs.core.ims.service.ImsServiceDispatcher.java).

04-09 09:04:56.358: V/[RCS][ImsServiceDispatcher](512): Unknown IMS service: 
automatically reject
04-09 09:04:56.368: V/[RCS][SipInterface](512): >>> Send SIP 606 response
04-09 09:04:56.368: I/System.out(512): >>> SIP/2.0 606 Session Not acceptable

In a multi-devices environment, it should answer with a SIP 4xx response, to 
allow another device receiving a fork of the same request to accept it.

* When Group Chat user leaves session due to
  network drop, the other participants receives
  'booted' notify state which was not properly
  parsed in ConferenceEventSubscribeManager
  class. Fixed the same.

See RCS 5.1 spec:

The EPSG format requires that the coordinate representation is defined by the 
coordinate
supplier. RCS client will always provide the coordinates in WGS 84 (latitude, 
longitude)
decimal notion as described in [RFC5491], providing the latitude and longitude 
as “double”-
encoded decimal numbers (as specified in [GML3.1.1]) representing the degrees, 
separated
by a space starting with the latitude. Negative values represent Southern and 
Western
hemisphere respectively.

[com.orangelabs.rcs.core.ims.service.richcall.RichCallService]

The stack allow to initiate an image share session while an IP call is 
established:
initiateImageSharingSession()
  // Test if call is established
  if (!getImsModule().getCallManager().isCallConnected() && !getImsModule().getIPCallService().isCallConnectedWith(contact)) {

In the other methods, the service only checks the call manager:
  // Test if call is established
  if (!getImsModule().getCallManager().isCallConnected()) {

The issue must be fixed in:
initiateGeolocSharingSession(String, MmContent, GeolocPush)
initiateLiveVideoSharingSession(String, IVideoPlayer)
receiveGeolocSharingInvitation(SipRequest)
receiveImageSharingInvitation(SipRequest)
receiveVideoSharingInvitation(SipRequest)

What steps will reproduce the problem?

Current stack logic is to remove session on based of number.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?

Android, Kitkat

Please provide any additional information below.

CR_004: Removal of un-necessary RCE-e APIs
From Qualcomm

Chat session which are created are saved in a list using method 
ChatServiceImpl.addChatSession(number, sessionApi) which is getting called in 
openSingleChat() method of ChatServiceImpl.java class. This take contact number 
as the key based on which the sessions are getting stored in the list.

But while removing these sessions in ChatImpl.java class the method 
ChatServiceImpl.removeChatSession(session.getContributionID()) is getting 
called with wrong arugument and because of which the keys are not matching and 
session are not getting removed and remains in the list.

What is the expected output? What do you see instead?

ChatServiceImpl.removeChatSession(number) should be called to remove session.

What version of the product are you using? On what operating system?
Android, kitkat

Please provide any additional information below.

Displayed report not sent on first message

* Discard those 1-1 chat invitations that does
  not have a message.
* According to RCS-e - Advanced Communications:
  Services and Client Specification Version 1.2.2:
  "It should be noted that a SIP INVITE carrying
  a CPIM/IMDN will have a multipart body as a SDP
  configuration is still required." So, we decline
  those INVITEs that does not have a multipart.

[deleted issue]

The API is using the letters API in many places. This is wrong. These letters 
will go.

What steps will reproduce the problem?
Stack passes different port in SIP invite from the TCP port

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?
Android, Kitkat

Please provide any additional information below.

Please check the attached screenshot.

What steps will reproduce the problem?
1. i have try to use RI code  , chat module

2. when i try to load chat history from (ChatLog.Message.CONTENT_CHAT_URI) and 
one of selected column is (ChatLog.Message.CONTACT_NUMBER) , it gives me error :

( no such column: contact_number: , while compiling: SELECT direction, 
contact_number, body, mime_type, status, msg_type, msg_id FROM message)


3.i tried to chage name  of column to "sender" instead of 
(ChatLog.Message.CONTACT_NUMBER) like what exists in javaDoc , and it is 
working fine

CR_005: Simplify Chat API
By Summitech

Simplify the Chat API to make it easier for application developers. The 
proposed change will reduce the amount of objects the API user needs to 
instantiate and maintain in order to handle API events.  It proposes a single 
handler instance for each of Chat, FT, and group chat. Some group chat methods 
not relevant for the Hotfixes were removed.

CR_007: Clarification on remote URIs
From Summitech

In addition, the API document refers to "contact" or "remote" in various 
places. These parameter names are too generic and therefore confusing. They 
should be replaced by "remoteUri" to make it clear that URI is expected. 

CR_001: Delete the common API
From Samsung

This CR proposes to delete the common API section from the specification. 
Allowing an application to enable or disable RCS service can have serious 
negative impact to other applications that rely on RCS. For example, if an 
application requests to disable RCS IM service, this will disable RCS IM 
service for all other applications that are relying on it. RCS-e specification 
defines that only a single client can be active at a time and has only one 
settings activity.

What steps will reproduce the problem?
Before ACS provisioning getting 511 code on 3G 

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?
Android, kitkat

Please provide any additional information below.