Giter Club home page Giter Club logo

Comments (12)

ecthelionvi avatar ecthelionvi commented on May 27, 2024 1

Sorry, I've been busy with school. I'll take a crack at this over the weekend.

from neocomposer.nvim.

ecthelionvi avatar ecthelionvi commented on May 27, 2024

Sorry for the delay. I was able to add separate highlight groups for the text:

text_delay, text_play, and text_rec as well as a text_bg option.

This will allow you to control the foreground and background of the text color separately from the symbols

from neocomposer.nvim.

ls-devs avatar ls-devs commented on May 27, 2024

Hey @ecthelionvi,
Don't worry for the delay and great job thank you !
Sorry to bother with this but there's still something happening after the text. I changed background of RecordingText to be none (transparent) and as you might see, on the far right of the text at the end, there's still some background color showing.
Please see :
image

from neocomposer.nvim.

ecthelionvi avatar ecthelionvi commented on May 27, 2024

Did you also change the text_bg color?

from neocomposer.nvim.

ls-devs avatar ls-devs commented on May 27, 2024

Did you also change the text_bg color?

@ecthelionvi I didn't. But I tried now to change text_bg and text_rec and I still got this :
image

from neocomposer.nvim.

ecthelionvi avatar ecthelionvi commented on May 27, 2024

What colorscheme are you using?

from neocomposer.nvim.

ls-devs avatar ls-devs commented on May 27, 2024

@ecthelionvi
I'm using folke/tokyonight

from neocomposer.nvim.

ecthelionvi avatar ecthelionvi commented on May 27, 2024

The color to the right is the bg_dark color from tokyonight "#1e2030". NeoComposer is not setting that color to my understanding.

It could also be coming from lualine itself. I am using tokyonight and I do have the issue you are experiencing.

from neocomposer.nvim.

ecthelionvi avatar ecthelionvi commented on May 27, 2024

This will require further investigation 🤔

from neocomposer.nvim.

ls-devs avatar ls-devs commented on May 27, 2024

This will require further investigation 🤔

@ecthelionvi After tweaking my configuration I can tell it only happens with NeoComposer.
It seems like there is an extra space at the end of the text and the highlight is not applying to it.

Can it be related to the way you setting up the highligh groups ?

  if state.get_recording() then
    status = "%#RecordingSymbol#%*%#RecordingText# REC%*"
  elseif state.get_playing() then
    status = "%#PlayingSymbol#%*%#PlayingText# PLAY%*"
  end

Is there any other way to set the highlights groups ?

from neocomposer.nvim.

ecthelionvi avatar ecthelionvi commented on May 27, 2024

I figured out the issue. It has to do with Lualine padding.

For example here is the default colorscheme with default padding of 1:

4BF6B837-55E2-47BA-AE24-E4EE6A6E973B_4_5005_c

Here I changed the right padding to 0 and kept the left padding at 1:

3D566DD1-0C51-4F01-99C4-EC8F037ED84D_4_5005_c

from neocomposer.nvim.

ls-devs avatar ls-devs commented on May 27, 2024

@ecthelionvi Well done ! Removing both padding left and right resolve the issue 👍🏼
Thanks for the help, very nice plugin you get there !

from neocomposer.nvim.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.