eclipse-thingweb / test-things Goto Github PK

Once the devices are deployed, we should link to their TDs from the Readme. Also, add them to plugfest.thingweb.io

In places like https://github.com/eclipse-thingweb/test-things/blob/main/things/calculator/http/express/main.js#L66 , there is no content type being sent whereas the TD says JSON.

Running test thing reports JSON TDs like this..

Hence, it is not returned as JSON

see http://plugfest.thingweb.io:8083/counter for example, which indicates it is application/json

The following section explains how simple it is to run the things with docker-compose up. Good so far.

What I am missing is information on where certain things are visible and maybe an overall list.

E.g., http://localhost/ reports a 404 and one has to dig into the code to find for example http://localhost/http-express-calculator.
Maybe the README can contain this information or the log of docker or there could be some information in the root of HTTP etc.
Not sure w.r.t. other protocols.

Even though observeproperty is in the forms, there is no observation mechanism implemented in HTTP Things

We should add BACnet Things given that the binding is online now at https://w3c.github.io/wot-binding-templates/bindings/protocols/bacnet/

We should Modbus Test Things since it is one of the bindings at https://w3c.github.io/wot-binding-templates/bindings/protocols/modbus. However, it cannot be based on the calculator since it is more property-driven. This is gonna be the case for BACnet so we can use the same TM.

Also see https://github.com/yaacov/node-modbus-serial#modbustcp-server

I tried on Windows to run docker-compose up as described here.

Anyhow, it fails with the following errors.

The HTTP and CoAP Things should be extended with affordances that exhibit media type based content negotiation as explained at https://w3c.github.io/wot-binding-templates/bindings/protocols/coap/index.html#content-negotiation

The generated Modbus forms contain "href": "?address=1&quantity=1", whereas the address should never be URI Variable. It should be part of the URI modbus+tcp://{address}:{port}/{unitID}/{address}?quantity={?quantity} e.g. modbus+tcp://127.0.0.1:60000/1/1

So far, we only test the TMs and TDs but not the communication. We should have end to end tests where a Consumer sends the requests. Ideally a node-wot consumer to really test TD consuming.

The current docker-compose file maps one port per Thing but since we want to add many Things here and do not want to ask for many ports from Eclipse, we should map one port to multiple devices internally. We need some routing of course. Some directions forward:

• https://doc.traefik.io/traefik/providers/docker/
• https://docs.docker.com/network/

Still in discussion but the idea is to also add node-wot Things and manage them via a single docker compose

Currently, the docker-compose file is meant for the deployment whereas the TDs in the repo are for local setup. Ideally, both should be supported. This means setting correct hostname and ports in the TDs are needed.