eclipse-platform / eclipse.platform.ua Goto Github PK

View Code? Open in Web Editor NEW

4.0 4.0 21.0 22.15 MB

eclipse.platform.ua's People

Contributors

Stargazers

Watchers

eclipse.platform.ua's Issues

128 ua.tests failed in I20220721-0550

Looks like help generation or retrieval is broken in I20220721-0550, we have 128 ua.tests fails in I20220721-0550.

See https://download.eclipse.org/eclipse/downloads/drops4/I20220721-0550/testresults/html/org.eclipse.ua.tests_ep425I-unit-cen64-gtk3-java11_linux.gtk.x86_64_11.html

http://localhost:36711/help/rtopic/org.eclipse.ua.tests/data/help/search/testnl1.xhtml?lang=de

java.io.FileNotFoundException: http://localhost:36711/help/rtopic/org.eclipse.ua.tests/data/help/search/testnl1.xhtml?lang=de
at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1909)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1509)
at java.base/java.net.URL.openStream(URL.java:1117)
at org.eclipse.ua.tests.help.remote.RemoteTestUtils.readFromURL(RemoteTestUtils.java:60)
at org.eclipse.ua.tests.help.remote.RemoteTestUtils.getRemoteContent(RemoteTestUtils.java:44)
at org.eclipse.ua.tests.help.remote.ContentServletTest.testContentInDeLocale(ContentServletTest.java:70)

Also see the fail in
https://download.eclipse.org/eclipse/downloads/drops4/I20220721-0550/testresults/html/org.eclipse.ua.tests.doc_ep425I-unit-cen64-gtk3-java11_linux.gtk.x86_64_11.html

expected:<[]> but was:<[java.io.FileNotFoundException: http://127.0.0.1:43425/help/topic/org.eclipse.platform.doc.isv/guide/product_extension.htm, java.io.FileNotFoundException: http://127.0.0.1:43425/help/topic/org.eclipse.platform.doc.isv/guide/jface.htm, java.io.FileNotFoundException: http://127.0.0.1:43425/help/topic/org.eclipse.platform.doc.isv/guide/login_extensions.html, java.io.FileNotFoundException: http://127.0.0.1:43425/help/topic/org.eclipse.platform.doc.isv/reference/extension-points/org_eclipse_debug_ui_debugModelPresentations.html, java.io.FileNotFoundException: http://127.0.0.1:43425/help/topic/org.eclipse.platform.doc.isv/reference/api/org/eclipse/jface/text/hyperlink/package-summary.html, java.io.FileNotFoundException: http://127.0.0.1:43425/help/topic/org.eclipse.platform.doc.isv/reference/extension-points/org_eclipse_ui_preferencePages.html, java.io.FileNotFoundException: http://127.0.0.1:43425/help/topic/org.eclipse.platform.doc.isv/reference/extension-points/org_eclipse_debug_ui_contextViewBindings.html, java.io.FileNotFoundException: http://127.0.0.1:43425/help/topic/org.eclipse.platform.doc.isv/reference/api/org/eclipse/core/filebuffers/package-summary.html, java.io.FileNotFoundException: http://127.0.0.1:43425/help/topic/org.eclipse.platform.doc.isv/reference/api/org/eclipse/core/databinding/observable/set/package-summary.html, java.io.FileNotFoundException: http://127.0.0.1:43425/help/topic/org.eclipse.platform.doc.isv/porting/4.9/faq.html, java.io.FileNotFoundException: http://127.0.0.1:43425/help/topic/org.eclipse.platform.doc.isv/porting/4.8/incompatibilities.html, java.io.FileNotFoundException: http://127.0.0.1:43425/help/topic/org.eclipse.platform.doc.isv/reference/extension-points/org_eclipse_equinox_http_registry_resources.html, java.io.FileNotFoundException: http://127.0.0.1:43425/help/topic/org.eclipse.platform.doc.isv/guide/wrkAdv_undo_ide.htm, java.io.FileNotFoundException: http://127.0.0.1:43425/help/topic/org.eclipse.platform.doc.isv/guide/st_text_types.htm, java.io.FileNotFoundException: 

...

JSPs can't be compiled on Java 17+

https://bugs.eclipse.org/bugs/show_bug.cgi?id=578221 is the original bug. In order to fix our build compilation I had to do b459090 to provide latest JDT.
But this effectively means Help system fails badly without jdt.core. We should find a way to update to jasper compiler with recent enough jdt.core bundled in it.

Unable to consume Lucene index from bundle 'org.eclipse.platform.doc.user

Open Help in latest SDK, see warning logged:

eclipse.buildId=4.27.0.I20230111-1800
java.version=17.0.4-internal
java.vendor=N/A
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
Command-line arguments:  -data /data/4x_platform_workspace -os linux -ws gtk -arch x86_64

org.eclipse.help.base
Warning
Thu Jan 12 09:36:04 CET 2023
Unable to consume Lucene index from bundle 'org.eclipse.platform.doc.user_4.27.0.v20221208-1243 [237]'. The index should be rebuilt with Lucene 9.4.2

Same also for org.eclipse.jdt.doc.user bundle.

@akurtakov : did we updated Lucene? I assume these "doc" bundles need to be touched & re-built now, or how does it work?

API Tools failure

Building locally from master, mvn verify -Pbuild-individual-bundles,api-check -pl org.eclipse.tips.ide fails with

[INFO] --- tycho-eclipserun-plugin:4.0.0-SNAPSHOT:eclipse-run (api-analysis) @ org.eclipse.tips.ide ---
[WARNING] Using JavaSE-19 to fulfill requested profile of JavaSE-17 this might lead to faulty dependency resolution, consider define a suitable JDK in the toolchains.xml
[WARNING] Using JavaSE-19 to fulfill requested profile of JavaSE-17 this might lead to faulty dependency resolution, consider define a suitable JDK in the toolchains.xml
[WARNING] Using JavaSE-19 to fulfill requested profile of JavaSE-17 this might lead to faulty dependency resolution, consider define a suitable JDK in the toolchains.xml
[WARNING] No toolchain was found in tycho-eclipserun-plugin for: JavaSE-17. Current Java runtime will be used
[INFO] Expected Eclipse log file: /home/mistria/git/eclipse.platform.ua/apiAnalyzer-workspace/data/.metadata/.log
[INFO] Command line:
	[/usr/lib/jvm/java-19-openjdk-19.0.2.0.7-1.rolling.fc37.x86_64/bin/java, -Xmx2048M, -Dp2.RepositoryPreferences.retryOnSocketTimeout=true, -Dp2.RepositoryPreferences.connectionRetryCount=3, -Dp2.RepositoryPreferences.connectionMsRetryDelay=500, -Dorg.eclipse.ecf.provider.filetransfer.retrieve.readTimeout=10000, -jar, /home/mistria/.m2/repository/p2/osgi/bundle/org.eclipse.equinox.launcher/1.6.400.v20210924-0641/org.eclipse.equinox.launcher-1.6.400.v20210924-0641.jar, -install, /home/mistria/git/eclipse.platform.ua/apiAnalyzer-workspace, -configuration, /home/mistria/git/eclipse.platform.ua/apiAnalyzer-workspace/configuration, -data, /home/mistria/git/eclipse.platform.ua/apiAnalyzer-workspace/data, -application, org.eclipse.pde.api.tools.apiAnalyzer, -project, /home/mistria/git/eclipse.platform.ua/org.eclipse.tips.ide, -baseline, /home/mistria/git/eclipse.platform.ua/org.eclipse.tips.ide/target/org.eclipse.tips.ide-apiBaseline.target, -dependencyList, /home/mistria/git/eclipse.platform.ua/org.eclipse.tips.ide/target/dependencies-list.txt, -failOnError]
Some blocking (most likely link/compilation) errors are present:
[FATAL] File TipsStartupService.java at line 35: The import org.osgi.service.component cannot be resolved (location: /home/mistria/git/eclipse.platform.ua/org.eclipse.tips.ide/src/org/eclipse/tips/ide/internal/TipsStartupService.java)
[FATAL] File TipsStartupService.java at line 44: Component cannot be resolved to a type (location: /home/mistria/git/eclipse.platform.ua/org.eclipse.tips.ide/src/org/eclipse/tips/ide/internal/TipsStartupService.java)
Some blocking (most likely link/compilation) errors are present ^^^

I observed with a debugger running java -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=1044 -Xmx2048M -jar /home/mistria/.m2/repository/p2/osgi/bundle/org.eclipse.equinox.launcher/1.6.400.v20210924-0641/org.eclipse.equinox.launcher-1.6.400.v20210924-0641.jar -install /home/mistria/git/eclipse.platform.ua/apiAnalyzer-workspace -configuration /home/mistria/git/eclipse.platform.ua/apiAnalyzer-workspace/configuration -data /home/mistria/git/eclipse.platform.ua/apiAnalyzer-workspace/data -application org.eclipse.pde.api.tools.apiAnalyzer -project /home/mistria/git/eclipse.platform.ua/org.eclipse.tips.ide -baseline /home/mistria/git/eclipse.platform.ua/org.eclipse.tips.ide/target/org.eclipse.tips.ide-apiBaseline.target -dependencyList /home/mistria/git/eclipse.platform.ua/org.eclipse.tips.ide/target/dependencies-list.txt -failOnError (the command generated by eclipse-run, with addition of debugging agent), and connected to the application, I can see that the target platform seems to be properly resolved, includes the org.osgi.service.component bundle, that the org.eclipse.tips.ide project is imported but I don't see org.osgi.service.component in its resolved classpath (while both Tycho and PDE in my IDE seem to add it to the classpath).

API Tools application creates a target-platform from the dependency-list file, and imports the project as source in the workspace, requests the build, then PDE starts working and the application returns filter API Tools problems. So it's mostly plain PDE, nothing fancy over a regular developer workspace. But devil hides in the details, and there is 1 detail here we're missing.
In the current state the issue is that: PDE adds org.osgi.service.component to the build path org org.eclipse.tips.ide in a regular workspace but doesn't add it when running the API Tools application.

Incomplete infocenter-web README-file

Hi,

I've tried to follow the readme to set up a local info-center and failed.
I've struggled a couple of days and been able to workaround a couple of things and got it to build. But not got it to run in Jetty nor Tomcat.

Would it possible to update the info-center's readme?

Best regards,
Mats-Ola

5 HelpServer tests are failing in Jenkins

Here is a dummy PR that shows the fails: #81.

I've stumbled over them while changing completely unrelated code in #77.

In official SDK tests the tests below succeed.
No idea what's wrong here, may be some maven/tycho specific issue (SDK tests run with ant).

Test Result (5 failures )
org.eclipse.ua.tests.help.webapp.HelpServerInterrupt.testServerWithInterrupt
org.eclipse.ua.tests.help.webapp.HelpServerInterrupt.testServerWithoutInterrupt
org.eclipse.ua.tests.help.webapp.HelpServerBinding.testStandaloneBinding
org.eclipse.ua.tests.help.webapp.HelpServerBinding.testInfocenterBinding
org.eclipse.ua.tests.help.webapp.HelpServerBinding.testWorkbenchBinding

First stack:

java.io.IOException: Server returned HTTP response code: 500 for URL: http://localhost:33771/help/index.jsp
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1997)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1589)
	at org.eclipse.ua.tests.help.webapp.HelpServerInterrupt.checkServer(HelpServerInterrupt.java:114)
	at org.eclipse.ua.tests.help.webapp.HelpServerInterrupt.testServerWithInterrupt(HelpServerInterrupt.java:66)

Update

The tests started to fail in Jenkins on January 09, last good build was on December 21:

Console logs good/bad

JDT IDETipManager: JsonSyntaxException

Somehow Tip of Today must be broken:

Visible when running any PluginTest - for example FileSystemResourceManagerTest as Plugin Test

!ENTRY org.eclipse.tips.json 4 0 2023-05-16 09:32:37.173
!MESSAGE com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 2 column 2 path $
!STACK 0
com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 2 column 2 path $
	at com.google.gson.JsonParser.parseReader(JsonParser.java:76)
	at org.eclipse.tips.json.JsonTipProvider.loadJsonObject(JsonTipProvider.java:113)
	at org.eclipse.tips.json.JsonTipProvider.loadNewTips(JsonTipProvider.java:84)
	at org.eclipse.jdt.tips.user.internal.JDTTipProvider.loadNewTips(JDTTipProvider.java:55)
	at org.eclipse.tips.ide.internal.IDETipManager$1.run(IDETipManager.java:93)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
	Suppressed: java.lang.IllegalArgumentException: Self-suppression not permitted
		at java.base/java.lang.Throwable.addSuppressed(Throwable.java:1072)
		at org.eclipse.tips.json.JsonTipProvider.loadJsonObject(JsonTipProvider.java:119)
		... 4 more
	Caused by: [CIRCULAR REFERENCE: com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 2 column 2 path $]
Caused by: com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 2 column 2 path $
	at com.google.gson.stream.JsonReader.syntaxError(JsonReader.java:1659)
	at com.google.gson.stream.JsonReader.checkLenient(JsonReader.java:1465)
	at com.google.gson.stream.JsonReader.doPeek(JsonReader.java:551)
	at com.google.gson.stream.JsonReader.peek(JsonReader.java:433)
	at com.google.gson.JsonParser.parseReader(JsonParser.java:71)
	... 5 more

Random failing LinkTest.testAllLinks

https://download.eclipse.org/eclipse/downloads/drops4/I20230615-1800/testresults/html/org.eclipse.ua.tests.doc_ep429I-unit-mac64-java17_macosx.cocoa.x86_64_17.html

java.lang.NullPointerException
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:564)
at java.base/java.util.concurrent.ForkJoinTask.reportException(ForkJoinTask.java:591)
at java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:689)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:159)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:765)
at org.eclipse.ua.tests.doc.internal.linkchecker.LinkTest.testAllLinks(LinkTest.java:82)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at org.junit.vintage.engine.execution.RunnerExecutor.execute(RunnerExecutor.java:42)
at org.junit.vintage.engine.VintageTestEngine.executeAllChildren(VintageTestEngine.java:80)
at org.junit.vintage.engine.VintageTestEngine.execute(VintageTestEngine.java:72)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:147)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:127)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:90)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:55)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:102)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:54)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
at org.junit.platform.launcher.core.SessionPerRequestLauncher.execute(SessionPerRequestLauncher.java:53)
at org.eclipse.test.EclipseTestRunner.runTests(EclipseTestRunner.java:212)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:187)
at org.eclipse.test.UITestApplication.lambda$0(UITestApplication.java:102)
at org.eclipse.e4.ui.internal.workbench.swt.E4Testable.lambda$1(E4Testable.java:127)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:132)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4368)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3991)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1155)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:342)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1046)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:155)
at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:643)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:342)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:550)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:171)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:152)
at org.eclipse.test.UITestApplication.run(UITestApplication.java:48)
at org.eclipse.test.UITestApplication.start(UITestApplication.java:117)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:136)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:402)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:659)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:596)
at org.eclipse.equinox.launcher.Main.run(Main.java:1467)
at org.eclipse.equinox.launcher.Main.main(Main.java:1440)
at org.eclipse.core.launcher.Main.main(Main.java:44)
Caused by: java.lang.NullPointerException: Cannot read field "right" because "l" is null
at java.base/java.util.TreeMap.rotateRight(TreeMap.java:2562)
at java.base/java.util.TreeMap.fixAfterInsertion(TreeMap.java:2594)
at java.base/java.util.TreeMap.addEntry(TreeMap.java:770)
at java.base/java.util.TreeMap.put(TreeMap.java:828)
at java.base/java.util.TreeMap.put(TreeMap.java:534)
at java.base/java.util.TreeSet.add(TreeSet.java:255)
at org.eclipse.ua.tests.doc.internal.linkchecker.LinkTest.checkLinks(LinkTest.java:131)
at org.eclipse.ua.tests.doc.internal.linkchecker.LinkTest.lambda$0(LinkTest.java:93)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1689)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290)
at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:754)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

According to the stacktrace an synchronized TreeMap is used in parallel (ForkJoinPool) which can cause random errors.

LinkTest fails since Jun 14, 2023, 2:37 AM

on master branch:
https://ci.eclipse.org/platform/job/eclipse.platform.ua/job/master/lastCompletedBuild/testReport/org.eclipse.ua.tests.doc.internal.linkchecker/LinkTest/testAllLinks/

org.junit.ComparisonFailure: expected:<[[]]> but was:<[[Link from http://127.0.0.1:33387/help/topic/org.eclipse.pde.doc.user/whatsNew/pde_whatsnew.html to Platform.php#force-https is broken: target URI http://127.0.0.1:33387/help/topic/org.eclipse.pde.doc.user/whatsNew/Platform.php#force-https doens't exist.]]>
	at org.junit.Assert.assertEquals(Assert.java:117)
	at org.junit.Assert.assertEquals(Assert.java:146)
	at org.eclipse.ua.tests.doc.internal.linkchecker.LinkTest.testAllLinks(LinkTest.java:101)

locally:

org.junit.ComparisonFailure: expected:<[[]]> but was:<[[java.io.FileNotFoundException: http://127.0.0.1:60092/help/topic/org.eclipse.ua.tests/participant2.xml, java.io.FileNotFoundException: http://127.0.0.1:60092/help/topic/org.eclipse.ua.tests/participant1.xml]]>
	at org.junit.Assert.assertEquals(Assert.java:117)
	at org.junit.Assert.assertEquals(Assert.java:146)
	at org.eclipse.ua.tests.doc.internal.linkchecker.LinkTest.testAllLinks(LinkTest.java:100)

@akurtakov is that related to PrebuiltIndexChecker?

Cheat Sheets advance to the bottom of the next step

When you click "Click when completed" on a Cheat Sheet step, the view is scrolled to the bottom of the next step.
It would be better to scroll to the top of the next step, as it is not obvious for the user that the cheat sheet really has advanced and is not stuck.

cc.mp4

This is a bigger issue when you have longer Steps that have more text as what currently fits into the view.

Invalid Manifest for org.eclipse.ui.intro

Since commit 9c6244e0b8e64c2c7fde93836070213ec39335a0
org.eclipse.core.expressions is removed but is still necessary (at compile time, and runtime as well)

Now it comes from org.eclipse.help.base (which reexport it) and without org.eclipse.help.base plugin in target platform, displaying welcome intro is not possible (CNFE for org.eclipse.core.expressions.IEvaluationContext)

I think either org.eclipse.base should become mandatory, either org.eclipse.core.expressions should be restored, otherwise it can leads with broken products

Test PrebuiltIndexChecker fails since 20230613

for example
https://download.eclipse.org/eclipse/downloads/drops4/I20230613-1050/testresults/html/org.eclipse.ua.tests.doc_ep429I-unit-macM1-java17_macosx.cocoa.aarch64_17.html

could not open: index

java.lang.AssertionError: could not open: index
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertNotNull(Assert.java:713)
at org.eclipse.ua.tests.doc.internal.linkchecker.PrebuiltIndexChecker.validateIndex(PrebuiltIndexChecker.java:69)
at org.eclipse.ua.tests.doc.internal.linkchecker.PrebuiltIndexChecker.testJdtIsvIndex(PrebuiltIndexChecker.java:57)

org.eclipse.tips.core.TipTest.testEqualsObject() fails

see #90 (comment)

Security Best Practices

Hi,

As a member of the Security Team from the Eclipse Foundation, we used a tools Scorecard and StepSecurity to analyze this repo in order to push a pull request that cover some or all the following best practices below:

Apply least privilege principle to GITHUB_TOKEN
Add or fine tune the use of Dependabot
Pin actions to a full length commit SHA

As a result, You will see a PR coming from StepSecurity to help to implement those fixes above which will cover a list of points below identified detected:

Apply least privilege principle to GITHUB_TOKEN for files .github/workflows/updateRelease.yml
Add or fine tune the use of Dependabot

Please don’t hesitate and reach out if there is something unclear above.

Kind Regards,
Francisco Perez

Merge this repo into either eclipse.platform or eclipse.platform.ui?

This seems to be one of the last separate code repos not considered for a merge, the build time is quite moderate with ~5minutes so it should not add much still the question would be

merge to eclipse.platform?
merge to eclipse.platform.ui?

@vogella @akurtakov @iloveeclipse @mickaelistria @..... what do you think?

Random failures in org.eclipse.ua.tests.doc.internal.linkchecker.LinkTest

https://download.eclipse.org/eclipse/downloads/drops4/I20230515-0600/testresults/html/org.eclipse.ua.tests.doc_ep428I-unit-macM1-java17_macosx.cocoa.aarch64_17.html

java.lang.NullPointerException
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:564)
at java.base/java.util.concurrent.ForkJoinTask.reportException(ForkJoinTask.java:591)
at java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:689)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:159)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:765)
at org.eclipse.ua.tests.doc.internal.linkchecker.LinkTest.testAllLinks(LinkTest.java:73)

https://download.eclipse.org/eclipse/downloads/drops4/I20230514-1800/testresults/html/org.eclipse.ua.tests.doc_ep428I-unit-cen64-gtk3-java17_linux.gtk.x86_64_17.html

Cannot read field "right" because "l" is null

java.lang.NullPointerException: Cannot read field "right" because "l" is null
at java.base/java.util.TreeMap.rotateRight(TreeMap.java:2562)
at java.base/java.util.TreeMap.fixAfterInsertion(TreeMap.java:2594)
at java.base/java.util.TreeMap.addEntry(TreeMap.java:770)
at java.base/java.util.TreeMap.put(TreeMap.java:828)
at java.base/java.util.TreeMap.put(TreeMap.java:534)
at java.base/java.util.TreeSet.add(TreeSet.java:255)
at org.eclipse.ua.tests.doc.internal.linkchecker.LinkTest.checkLinks(LinkTest.java:122)
at org.eclipse.ua.tests.doc.internal.linkchecker.LinkTest.lambda$0(LinkTest.java:84)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1707)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290)
at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:754)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:686)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:159)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:765)
at org.eclipse.ua.tests.doc.internal.linkchecker.LinkTest.testAllLinks(LinkTest.java:73)

Looks like null elements are added to indexedPagesURIs.

I will push a PR.

Compiler warnings in ua.tests.doc

The following warning is reported in ua.tests.doc

/src/org/eclipse/ua/tests/doc/internal/linkchecker/ApiDocTest.java : 1 warning :

1. WARNING in /src/org/eclipse/ua/tests/doc/internal/linkchecker/ApiDocTest.java (at line 113)private static final Pattern NON_API_PACKAGES = Pattern.compile(".+\.(?:internal|tests|examples)(?:\..+)?");The value of the field ApiDocTest.NON_API_PACKAGES is not used

eclipse-platform / eclipse.platform.ua Goto Github PK

eclipse.platform.ua's People

Contributors

Stargazers

Watchers

Forkers

eclipse.platform.ua's Issues

/src/org/eclipse/ua/tests/doc/internal/linkchecker/ApiDocTest.java : 1 warning :

1. WARNING in /src/org/eclipse/ua/tests/doc/internal/linkchecker/ApiDocTest.java (at line 113)private static final Pattern NON_API_PACKAGES = Pattern.compile(".+\.(?:internal|tests|examples)(?:\..+)?");The value of the field ApiDocTest.NON_API_PACKAGES is not used

Recommend Projects

Recommend Topics

Recommend Org