swob-geojson's People
swob-geojson's Issues
SWOB to GeoJSON feedback
@rjwest good work here https://github.com/ECCC-PMCU/SWOB-GeoJSON/blob/master/src/swob2geojson.py
Some feedback:
-
I like the data structure you're using internally to capture the content
-
I don't see the qualifiers parse. Where are you storing the 'qa_summary', 'data_flag' etc values? Perhaps you can store the qualifiers as sub item in each element's list as an element itself since qualifies also have the same XML attributes as their parent elements.
-
How are you handling 'code' uom? I don't see them in the structure for all the element, only some.
-
Make sure to do proper logging, remove all print statements
-
Make sure to run your code through pep8: https://www.python.org/dev/peps/pep-0008/. You can install pep8 like so https://pypi.org/project/pep8/ and run it against your code to clear any PEP8 style violations.
-
Provide a test suite https://docs.python.org/3/library/unittest.html. Here's an example: https://github.com/woudc/woudc-extcsv/tree/master/tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.