prj-rev-bwfs-dasmoto's People
prj-rev-bwfs-dasmoto's Issues
IMPORTANT - using '@amp;'
You want to be really careful when you are using & in code, reason being is that sometimes it can be interpreted as an AND in code and can cause some unexpected things to happen. To keep it safe, you're going to want to use '&' Check this page for more information: https://www.w3schools.com/html/html_entities.asp
GREAT - Folder structure
Your Folder structure follows community standards! It's recommended that you group everything related together, so that means putting your css file into a folder called css, and also putting all your images in a folder called images, here's an example: http://prnt.sc/ekir5r
Just make sure you remember to change the file path for the css file as well as the image path in all the image elements to reflect any changes you make with the folder structure.
GREAT - Organization
Great job keeping both the css and HTML neat and organized using comments and indentation. run through your HTML and make sure your indentation is consistent. everything that is nested to the same level should be indented the same.
consider making use of some well-placed line breaks throughout the HTML to help define each content chunk and make things easier to identify at a glance.
more info about HTML styling, in general, can be found here - https://www.w3schools.com/html/html5_syntax.asp
GREAT - Using alt
You considered adding an alt attribute to the images, that way if any of the images don't load for some reason, you don't get the broken link icon, rather the text you specify in alt will be displayed, more info here: https://www.w3schools.com/tags/att_img_alt.asp
SUMMARY
Project name: Dasmoto's Arts & Crafts
Grade: Meets Expectations
Summary: Good job completing this project and submitting it on time! You have learned to work locally in your text editor and that is a big step. Your file structure was well organized and your heading hierarchy was coherent.
Your project was tidy and well-formatted throughout. For a more in depth look at best practices, I recommend reading through this chapter: http://learn.shayhowe.com/html-css/writing-your-best-code/
For future projects, you may want to download all images and use relative paths to link to them rather than absolute paths. While this isnβt strictly necessary, I do encourage it as new developers often struggle with directory structure at first and this is an important concept to get right. For more info, please read this section:
https://internetingishard.com/html-and-css/links-and-images/#absolute-relative-and-root-relative-links
Finally, I encourage you to start thinking about web accessibility. This is something you will learn more about in week 7 but for a quick overview: βhttps://www.codecademy.com/articles/accessibility
Overall, you did an excellent job here. Keep up the hard work!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.