ebsy / discourse-nationalflags Goto Github PK

The country names don't seem to be sorted.

From playing a bit with the flags.yml, it seems it is following the ordering on that file which is by country code.

I could submit a PR with them sorted by country name, but that will not work when the plugin is used in other languages.

Would it be possible to sort them at the time the dropdown is created?

In a Discourse forum I belong to, we've been discussing the possibility of adding this plugin. There are some who would like it and others who wouldn't.

To satisfy both cases, I was wondering whether it would be possible to add a user preference to not show the flags, from a viewer perspective?

The default would be "show" unless changed by a user. For those not signed in, it could do whatever it does now but a "global" flag for the behaviour with non-signed-in viewers would be nice to have.

After an update to Discourse 3.2.0.beta4, I see a banner warning

[Admin Notice] One of your themes or plugins needs updating for compatibility with upcoming Discourse core changes (more info).

In the console logs, I see

Usage of the Ember Global is deprecated. You should import the Ember module or the specific API instead. [deprecation id: ember-global] See https://deprecations.emberjs.com/v3.x/#toc_ember-global for more details.

More information is available here:

https://meta.discourse.org/t/preparing-for-discourses-upgrade-to-ember-5/287211?u=mcdanlj

For de-at, fr-br, and us-at the description of the country seems undefined. Preferably because the flag's value itself isn't defined on the client.en.yml file. If you suggest the text, I can help fix this and test it out.

From the name of the flag filenames, I'm guessing the plugin follows ISO 3166-1 alpha-2 codes. Although often called "country codes", this standard is "to represent countries, dependent territories, and special areas of geographical interest".

On a worldwide forum, it is not uncommon for the use of the words "country" or, in this case, "national" to be a source of disagreement (eg: "X is not a country", etc.) or at least some friction.

Could the label on the profile settings be something like "Location flag"? This would also cover the special case with the EU flag. I do realize the name of the plugin, but it would be enough to update the user facing text.

Hi,

Would it be possible to get a Kosovo flag added?

.. it set flag to
plugins/discourse-nationalflags/images/nationalflags/false.png
but should set it to
plugins/discourse-nationalflags/images/nationalflags/no.png
the reason is that the link is missing here?
https://github.com/Ebsy/discourse-nationalflags/blob/master/config/locales/client.en.yml

no: Norway

Is there any chance we could get a pirate flag? Might add a bit of fun to discourse.

There are possibly other flags that could be filed under a similar category, but this is the first that came to mind.

Right now there is no quick way to identify the country if one does not know the flag. Right click > View image would allow one to see the country code from the image name, but it would be better to have the alt="[country_code]" attribute set, not to mention it would make the html code valid.

I performed the update on December 30th 2019, with the flag fixes, Norway was mentioned, but it shows a broken image.