ebidel / geo-location Goto Github PK

When having attributes like so:

<geo-location maximum-age="30000" high-accuracy="true" ></geo-location>

like maximum-age or high-accuracy every initial request ignores those attributes;

The Guard placed in fetch method is not sufficient to ensure the element is ready:

fetch: function () {
        // Guard clause in case observer runs before element is ready. Refer to Polymer issue #3438
        // https://github.com/Polymer/polymer/issues/3438
        if (this.idle === undefined || this.watchPos === undefined) {
          return;
        }

The fetch method (observer) is called twice - for each default value of this.idle and this.watchPos

idle: {
    type: Boolean,
    value: false,
    observer: 'fetch'
},
watchPos: {
    type: Boolean,
    value: false,
    observer: 'fetch'
}

but when this.idle and this.watchPos are set - the element is still not ready and none of the attributes are available , and fetch is executed with options like:

Object {enableHighAccuracy: undefined, timeout: undefined, maximumAge: undefined}

This causes maximum-age to not cache the location the first time, the first location is not accurate since the high-accuracy is not true and all sorts of problems on mobile device as well as performance issues.

A simple fix that is working for me is to add the 3 attributes to the list like so:

if (this.idle === undefined || this.watchPos === undefined || this.highAccuracy === undefined || this.timeout === undefined || this.maximumAge === undefined) {
          return;
        }

It's easier to set that way.

Why not?

When you add multiple geo-location elements with watch-pos in a single document, only one will effectively watch the position. The watch for the other elements is cleared. Is this on purpose?

Possible fix in this fork: https://github.com/appsup-polymer/geo-location

Do the clean up. Reuse https://github.com/ebidel/geo-location/blob/master/geo-location.html#L136

• Add keywords from bower.json as repo topics (https://github.com/blog/2309-introducing-topics).
• Change link https://ebidel.github.io/geo-location/ to https://webcomponents.org/element/ebidel/geo-location.

It makes sense to remove the https://ebidel.github.io/geo-location/ demo (gh-pages branch) completely, because:

1. it's outdated
2. the https://webcomponents.org catalog obsoletes the creation of GitHub pages for Polymer documentation and demos (see https://medium.com/collaborne-engineering/polymer-simplify-travis-builds-with-webcomponents-org-f44c3a879f3c)

Since your code has a five-second timeout, it is likely that devices will timeout before resolving location, especially with the accuracy turned up. Have you considered adding a backstop JSON service to perform IP-based geolocation if the initial resolution fails?

So it's easily configurable.

Hey Eric,

I am Binh Bui, the Marketing Community Specialist of Vaadin. I tested your components and really liked it. I published the blog Introducing geo-location, a web component which lets you easily locate, track or reverse geocode your current location.

Also, I would highly appreciate if there are some words down below the comment section from the original author.

Cheers!

Is there a way to incorporate GPS accuracy estimate? I am pretty sure the data should be provided.

Firefox asks the user to share his location using a popup, that popup can be dismissed. When the user does so, the watchPosition never throws an error. Perhaps we should add a timeout handler that fires an error if watchPosition doesn't success or error?

Hello, the component seems to be inactive on android devices. I tried with a Huawai tablet with android 7.0, and a Samsung Galaxy S8 with android 8.0.0.
The demo is not locating me, it renders a map that start at coordinate [0,0]

I think that idle and watchPos properties should have an observer, I mean, if one of this 2 properties change must request a position.

I'm getting the following error at https://www.webcomponents.org/element/ebidel/geo-location and the demo page after I click "share location" in the Firefox permission dialog.

It was workig a few days ago but now it only returns
2: Network location provider at 'https://www.googleapis.com/' : Returned error code 403.

Do I need an API_Key and set it somewere or it is realy bugged now?

It is not working for me on safari including in the demo. Safari supports geo location. http://caniuse.com/#search=geolocation

@addyosmani

Can you take a look at https://github.com/ebidel/geo-location/blob/master/geo-location.html and give it an initial review?

I'll send a pull request as soon as I have some free time. 😉

@ebidel Please update this web component to Polymer 2.x support.