ebhy / budgetml Goto Github PK

Is your feature request related to a problem? Please describe.
I'm not sure how to run a sockeye (https://github.com/awslabs/sockeye) model with budgetml

Describe the solution you'd like
A quickstart example to run a sockeye model. For example the model built in https://awslabs.github.io/sockeye/tutorials/wmt.html .

Describe alternatives you've considered
Using https://github.com/jamesewoo/sockeye-serving/tree/master/src/sockeye_serving or writing FastAPI endpoints that import sockeye.

Additional context
https://github.com/jamesewoo/sockeye-serving/tree/master/src/sockeye_serving does not seem to be in active development.

Describe the bug
Hi! first of all, thanks for such a neat tool! 🎉

It's not a bug, I just thought that sending HTTP 400 is not good when the predictor couldn't get loaded (all /predict* routes):

I think, it's better to use a 5XX server-side error:

• HTTP 400 means that there was a client error (e.g., malformed request syntax, invalid request message framing, or deceptive request routing).
• HTTP 500 means that the server encountered an unexpected condition that prevented it from fulfilling the request. This error response is a generic "catch-all" response. Usually, this indicates the server cannot find a better 5xx error code to response.

Hi @htahir1 , thanks for the super handy library !

I am wondering whether or not it is possible to include some extra python file when creating the Docker container?
I am attempting to infer a custom model and thus I need a bunch of files like: checkpoint, model file, config and so on..
I couldn't find anything mentioning this in the docs.

Thanks for your help 😄

Describe the bug
As a newbie in GCP, I'm trying to run BudgetML with the "getting started" code shared. After setting up GCP, and running run_budget_ml.py (which contains the budget_ml.launch() call), I get the following error:

Traceback (most recent call last):
File "run_budget_ml.py", line 24, in
budgetml.launch(
File "/Users/yadapruksachatkun/opt/anaconda3/lib/python3.8/site-packages/budgetml/main.py", line 321, in launch
self.create_scheduler_job(
File "/Users/yadapruksachatkun/opt/anaconda3/lib/python3.8/site-packages/budgetml/main.py", line 266, in create_scheduler_job
create_gcp_scheduler_job(project_id, topic, schedule, region)
File "/Users/yadapruksachatkun/opt/anaconda3/lib/python3.8/site-packages/budgetml/gcp/scheduler.py", line 30, in create_scheduler_job
response = client.create_job(
File "/Users/yadapruksachatkun/opt/anaconda3/lib/python3.8/site-packages/google/cloud/scheduler_v1/services/cloud_scheduler/client.py", line 595, in create_job
response = rpc(request, retry=retry, timeout=timeout, metadata=metadata,)
File "/Users/yadapruksachatkun/opt/anaconda3/lib/python3.8/site-packages/google/api_core/gapic_v1/method.py", line 145, in call
return wrapped_func(*args, **kwargs)
File "/Users/yadapruksachatkun/opt/anaconda3/lib/python3.8/site-packages/google/api_core/grpc_helpers.py", line 75, in error_remapped_callable
six.raise_from(exceptions.from_grpc_error(exc), exc)
File "", line 3, in raise_from
google.api_core.exceptions.InvalidArgument: 400 Location must equal us-west2 because the App Engine app that is associated with this project is located in us-west2

My app engine region is us-west-2, and I also set my project region to us-west-2. What region should I be setting?
Thank you!

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Stack Trace
If applicable, add the error stack trace to help explain your problem.

** Context (please complete the following information):**

• OS: [e.g. Ubuntu 18.04]
• Python Version: [e.g. 3.6.6]
• BudgetML Version: [e.g. 0.1.0]

Additional information
Add any other context about the problem here.

Describe the bug
FastAPI username and password are directly logged. It could be a potential security issue as described in CWE-532 in code

To Reproduce
launch_local

Expected behavior
Redacted the username and pasword

Screenshots
N/A

Stack Trace
N/A

** Context (please complete the following information):**
N/A

Additional information
N/A