ealsur / concurrentdocdb Goto Github PK

There is one issue that I'd like to highlight is that your public APIs are marked with "async" qualifier due to the fact that you are using "await" inside. This will cause deadlock issues when this code is run in ASP.NET context unless someone explicitly calls .ConfigureAwait(false) on the API(which most people don't know).

To fix this, either use .ConfigureAwait(false) in all the await statements within your API or have the public API return a Task or Task without "async" qualifier and wrap the code inside in a private async method.

Here is an example:

public static Task<ResourceResponse> ReplaceConcurrentDocumentAsync(this DocumentClient client, Document document, RequestOptions options = null)
{
return InlineIfPossible(() => this.ReplaceConcurrentDocumentPrivateAsync(this client, document, options));
}

private async Task<ResourceResponse> ReplaceConcurrentDocumentPrivateAsync(this DocumentClient client, Document document, RequestOptions options)
{
// Existing code that you have in ReplaceConcurrentDocumentAsync
}

static public Task InlineIfPossible(Func function)
{
if (SynchronizationContext.Current == null)
{
return function();
}
else
{
return Task.Run(function);
}
}

You should first try to repro this in an ASP.NET project and verify that the below change fixes it.

The reason I know this is that coincidently, I'm working on fixing the same issue in our .NET SDK APIs