e3v3a / mmm-tabulator Goto Github PK

Move all images to its own subdirectory: ./images/.

The module currently use units of milliseconds [ms] for the updateInterval option in config.js. This is silly, and I would like to see seconds (and possibly minutes) instead.

There is a difference in the rendering of the table, depending on if you are looking at the local host Mirror or on the server. The artifact renders like this:

On the local host (RPi3):

On the remote host using Firefox:

I'd like to get rid of this difference.

Currently the module only renders perfectly formatted JSON data. However, APIs are often very relaxed when providing JSON data.

# cat dirty.json

  { id: '1',
    somenumber: 112233,
    somestring: 'ABCD',
    somenull: null 
  },
  { id: '2',
    somenumber: 445566,
    somestring: 'EFGH',
    somenull: null
  }

# cat clean.json

  { "id": "1",
    "somenumber": 112233,
    "somestring": "ABCD",
    "somenull": null
  },
  { "id": "2",
    "somenumber": 445566,
    "somestring": "EFGH",
    "somenull": null
  }

• Also, how should we handle null?

I already tried using JSON.stringify(data); before sending it down the socket, but that didn't work as I expected, and no error reason was given...AFAICR.

Here is some more JSON documentation.

It would be good to have the table height being automatically adjusted to the number of table items to be shown. So let's try to adjust the Tabulator height according to either:

1. The config option maxItems max value, or if there are less items available, then
2. Adjust the number of rows to be shown to be what's available.

See: flightTable.tabulator({ height:205,...

Expected Behaviour:
Expected to see 20 items displayed on the mirror.

Actual Behaviour:
Instead of seeing the items, I see a message "Waiting for data". If I cut the list to 150 items (see attached file), it works as it should but if I expand it to 250 items (rows) then it doesn't work => "Waiting for data".
ListaCuvinte.txt
My girlfriend wants to learn Danish and I this is a list with all the Danish words, I want to make the mirror display 20 words at a time in DK, EN, RO and cycle through randomly every 3 min or so.
I tried everything with this list but I don't seem to get it work. Any help would be very much appreciated.

Steps to Reproduce the Issue:
Please have a look at the attached file. It's saved as UTF-8 and all I did was to change the extension to JSON. If you replace the demo.json with this one and change column names accordingly in the config files, it will not work (works with 150 words for example but not the rest). I don't know if it's an error in the file or the module cannot handle so much data.
Any input would be much appreciated.

For new bugs and issues, please make sure to:

• include detailed information on what you did before the error/issue occurred.
• get info about your system configuration, if relevant.
• make sure to use code mark-down using 3 backticks, ```, to enclose mulyi-line code/input/output.
• include a screenshot! for issues concerning layouts, formatting, or other UI stuff.

Good News from @olifolkerd (dev of Tabulator library)

You will be happy to hear that as of version 4.0 Tabulator is no longer jQuery dependent and now comes with a tabulator_core.min.js without all the modules installed to make it even more light weight.

I've been away from developing for a few months, so I currently don't know if there is any side effects because of this. Please report, if you find any.

Move all the demo code to a new subdirectory ./demo.

It would be very useful to measure exactly what the performance impact is when using Tabulator as compared to using a home-made JS DOM generator, as is often used in MMM's.

If someone find it easy to write DOM in JS, I would be extremely happy for PR into dev repo.
(Personally I hate writing DOM, which is why I started this repo in the first place.)

📊