e2openplugins / e2openplugin-filecommander Goto Github PK

Problem:
User currently needs to <Parent Folder> multiple times to get to the list of storage devices.

Suggestion:
Add option to show a <List of Storage Devices> item in the folder list (this currently only shows at the root level of each device)

Device root:

Concept:

Triple-dots appear in the current selection path line. Both files and folders are affected.

Eg.:

OpenATV 7.3 on Mut@nt HD51

Problem:
Currently only the partition number as it is found in sequence on the device is shown

Suggestion:
Use partition's LABEL value if it has one

Also:
If there is more than 1 partition on a device, and it doesn't have a LABEL, show it as (Partition 1)

Sample setup:

blkid:

/dev/sdb1: UUID="uuid" BLOCK_SIZE="512" TYPE="vfat" PARTLABEL="EFI system partition" PARTUUID="uuid"
/dev/sda1: LABEL_FATBOOT="EFI" LABEL="EFI" UUID="uuid" BLOCK_SIZE="512" TYPE="vfat" PARTLABEL="EFI System Partition" PARTUUID="uuid"
/dev/sdb3: LABEL="Win10 OS" BLOCK_SIZE="512" UUID="uuid" TYPE="ntfs" PARTLABEL="Basic data partition" PARTUUID="uuid"
/dev/sdb5: UUID="uuid" BLOCK_SIZE="4096" TYPE="ext4" PARTUUID="uuid"
/dev/sdb6: LABEL="Data" UUID="uuid" BLOCK_SIZE="512" TYPE="exfat" PARTLABEL="Basic data partition" PARTUUID="uuid"
/dev/sdb4: BLOCK_SIZE="512" UUID="uuid" TYPE="ntfs" PARTUUID="uuid"
/dev/sda2: LABEL="MBP17" UUID="uuid" BLOCK_SIZE="512" TYPE="exfat" PARTUUID="uuid"
/dev/sdc1: LABEL_FATBOOT="1GB FAT32" LABEL="1GB FAT32" UUID="uuid" BLOCK_SIZE="512" TYPE="vfat" PARTUUID="uuid"
/dev/sdc2: LABEL="4GB ext4" UUID="uuid" BLOCK_SIZE="4096" TYPE="ext4" PARTUUID="uuid"
/dev/sdc3: LABEL="24GB exFAT" UUID="uuid" BLOCK_SIZE="512" TYPE="exfat" PARTUUID="uuid"
/dev/sdb2: PARTLABEL="Microsoft reserved partition" PARTUUID="uuid"

df:

/dev/sda1               201633     83680    117954  42% /media/hdd2
/dev/sdb3             48748560  23381744  25366816  48% /media/sdd2
/dev/sdb5             19593168  17882864    645348  97% /media/sdd3
/dev/sdc1              1046516    758644    287872  72% /media/mmc
/dev/sdc2              4046560   2913500    906964  76% /media/usb2
/dev/sdb4               549884    459792     90092  84% /media/sdd4
/dev/sdb1                98304     30954     67350  31% /media/sdd5

When moving(copying/deleting?) a file which has relations (for example, a .ts recording with .eit, .ap, .cuts, .meta, .sc files), the user is prompted to:
Cancel
Move all related files
Move only highlighted file

If the user selects either Move option, they're prompted yet again:
Move these directories/files?
Yes
No

This isn't necessary as the user has already confirmed/cancelled by selecting an option in the previous prompt.

Extra note: Cancel should follow standard practice and appear as the bottom-most option.

Copying a file from one path to another will prompt before overwriting if the source filename already exists in the destination.

However, renaming a file to an existing file name in the same folder will destroy the target file and replace with the renamed file without warning the user.

eg:

root@mutant51:/# ls -1 /tmp
chrony.status
dw.info
hotplug.socket
kodiext.socket
powerup_without_waking_tv.txt
do_not_delete.log
random.log

From file commander, renaming random.log to do_not_delete.log will cause do_not_delete.log to be lost without warning.

OpenATV 7.3 on Mut@nt HD51

Hi, when I start a local video file (mp4) with FileCommander on OpenATV 7.x, the mediaplayer is not able to show an info screen. Ending the video is not possible with the configured key, only with stop key. With older version of FileCommander on OpenATV 6.x this both worked.