e-mission / cordova-server-sync Goto Github PK

The onPostExecute() of the current AsyncTask implementation does not override the superclass' hence the cachedCallbackContext.success() is never called

// cordova-server-sync/src/android/ServerSyncPlugin.java : line 70
            AsyncTask<Context, Void, Void> task = new AsyncTask<Context, Void, Void>() {
               ...

                protected void onPostExecute(Long result) {
                    cachedCallbackContext.success();
                }
            };

The solution was to pass Void as an argument instead of Long . I forked this repo and made the necessary changes however I was not able to add the forked version to my cordova project (e-mission-phone);

Error while adding the forked version.

$ cordova plugin add https://github.com/ericafenyo/cordova-server-sync.git

Failed to fetch plugin https://github.com/ericafenyo/cordova-server-sync.git via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Failed to get absolute path to installed module

Error when added to the config.xml

<plugin name="edu.berkeley.eecs.emission.cordova.serversync" spec="https://github.com/ericafenyo/cordova-server-sync.git" />

$ cordova prepare
...
Discovered plugin "edu.berkeley.eecs.emission.cordova.serversync" in config.xml. Adding it to the project
Failed to restore plugin "edu.berkeley.eecs.emission.cordova.serversync" from config.xml. You might need to try adding it again. Error: Failed to fetch plugin https://github.com/ericafenyo/cordova-server-sync.git via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Failed to get absolute path to installed module

The current sync architecture interface is not clean.

• On both android and iOS, it calls the usercache directly
• On android, it calls the code to fix the state machine automatically, which is in the data-collection plugin.
• On iOS, it is called from the data collection plugin since the sync happens in response to visit changes
• On both, we read the battery level, which is a data collection thing, and uses the battery wrapper.

Need to do a good design and rework this properly.

If that is turned on, then the sync can only be launched manually