dzunke / featureflagsbundle Goto Github PK

User Deprecated: The "dz.feature_flags.toggle" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead.

If I understand the documentation correclty the service dz.feature_flags.toggle needs to be public.
I added a PR to make the change.

Get rid of deprecation notifications?

Under PHP 8.1 I get the following deprecation notices:

PHP Deprecated:  Return type of DZunke\FeatureFlagsBundle\Toggle\ConditionBag::getIterator() should 
either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] 
attribute should be used to temporarily suppress the notice in /var/www/app/vendor/dzunke/feature-flags-
bundle/DZunke/FeatureFlagsBundle/Toggle/ConditionBag.php on line 18

PHP Deprecated:  Return type of DZunke\FeatureFlagsBundle\Toggle\ConditionBag::count() should either 
be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to
 temporarily suppress the notice in /var/www/app/vendor/dzunke/feature-flags-
bundle/DZunke/FeatureFlagsBundle/Toggle/ConditionBag.php on line 26

Hey,

In a8beb81 Symfony 2.3 has been removed from the composer dependency range, with the justification that it is EOL. According to the Symfony roadmap, it is not EOL May 2017, and will still be seeing security patches until this date.

Could you please reverse the change to composer.json until next May (under the proviso that there not be support for incompatibilities!), as alongside #3 (pretty please!) there are a bunch of features in v1.1.0 which greatly increase what is possible with this bundle in "legacy" Symfony applications even when support for those versions is finally dropped in this bundle.

Happy to PR if you haven't the time!

Cheers,
Alex

In case of multiple call to isActive() on a flag having percentage condition, there is multiple call to setcookie function, which can cause error because of too big response header (each Set-Cookie: ... will be in the response header).

To avoid this, you can, for example, add something like this: $this->request->cookies->set($config['cookie'], $value); after setcookie() function... Not very beautiful, but it works ;-)

Thx.

Installing v4.1 on Symfony 4.4 gives me the following error when I clear the cache:

In CheckExceptionOnInvalidReferenceBehaviorPass.php line 86:
                                                                                                       
  The service "dz.feature_flags.conditions_bag" has a dependency on a non-existent service "request". 

I can't see where the reference to "request" is coming from. Any ideas?
Thanks

Hi @DZunke, thanks for this useful package.

I'm in the process of upgrading a legacy codebase from Symfony 3.4 to 4.1.
And I was wondering if you have plans for supporting Sy4 anytime soon "like within 48 hours"!?
It's ok if you don't have time for it now, I may get someone or myself to handle it and contribute back, if you don't mind.

Best,

What would be required to upgrade this bundle to work with Symfony3? Is it a lot of work?

I think this bundle is really awesome and I would love to use it in my symfony3 project!