dyfanjones / s3fs Goto Github PK

Currently paws is unable to copy s3 object using multipart (paws-r/paws#501). This is fixed in (paws-r/paws#503).

Will need to restrict version of paws.common and paws.storage so s3fs functionality will work.

Prepare for release:

• Check current CRAN check results
• Update NEWS
• urlchecker::url_check()
• devtools::check_rhub()
• devtools::check_win_devel()
• Update cran-comments.md

Submit to CRAN:

• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• Update Github Release

Some functions in the s3fs package make use of base::trimws with the whitespace argument. However, that argument is not available prior to R version 3.6.0.

So in older R versions:

foo <- s3_dir_ls("s3://foo/bar")

gives:

Error in trimws(path, which = "right", whitespace = "/") : 
  unused argument (whitespace = "/")

Being able to stream files from urls directly to s3 paws-r/paws#517

When the directory already exists, fs::dir_create ignores it and returns the path(s) to the directory(ies), while s3fs::s3_dir_create returns the string "Directory already exists in AWS S3".

If the goal is to make code written using the fs package portable to the s3fs than the behavior of the functions should be as close as possible.

Also, returning a string is not the most common behavior in R. A condition should be raised, either error, warning or message.

Prepare for release:

- [ ] Check current CRAN check results

• Update NEWS
• urlchecker::url_check()
• devtools::check_rhub()
• devtools::check_win_devel()
• rhub::check_for_cran()
• Update cran-comments.md

Submit to CRAN:

• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• Update Github Release

Prepare for release:

• Check current CRAN check results
• Update NEWS
• urlchecker::url_check()
• devtools::check_rhub()
• devtools::check_win_devel()
• Update cran-comments.md

Submit to CRAN:

• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• Update Github Release