dwwoelfel / cetcd Goto Github PK

Thanks for this library, it's been helpful.

One minor point; attempting to use characters that are not allowed in URLs as arguments to the functions seems to fail. For example, (etcd/set-key! "foo bar" 123 ) gives URISyntaxException Illegal character in path at index 33: http://127.0.0.1:4001/v2/keys/foo bar java.net.URI$Parser.fail (URI.java:2829).

Can we alter the library to URL encode all strings before making them into URLs?

Could we extend delete-key! to support the backend's prevValue and prevExists? (https://github.com/coreos/etcd/blob/master/server/v2/delete_handler.go#L19)

I got this working with something like:

 (etcd/api-req :delete (->>  key url-encode (format "keys/%s"))
                                 :query-params {:prevValue old-value})

I'm not sure how you want to integrate the optional :prevValue argument into the cetcd API...

Add type annotations? Only helps if users of the library use type annotations.

When sending a write command to an etcd node that is not the leader (due to e.g. failover), the etcd node replies with a 307 redirect to the new leader. Unfortunately, these redirects are not implemented in http-kit versions lower than 2.1.16, so the current release of cetcd silently fails when directed to perform a write operation if it is not talking directly to the leader.

This can be fixed by bumping http-kit to 2.1.16 in project.clj.