dvdme / forecastiopy Goto Github PK
View Code? Open in Web Editor NEWA Python wrapper for the forecast.io API.
License: Eclipse Public License 1.0
forecastiopy's People
Contributors
Stargazers
Watchers
Forkers
allenfontenot geekbeard nate97 bitpixdigital furiousfive jonom137 zpriddy sclegg kalpetros nick5435 frandiego khannaum stellroy dyjn graemegcox cnisperosforecastiopy's Issues
FIODaily off-by-one
In FIODaily, day_1_* is actually day 8 and everything else is shifted by 1:
# daily_cycle_bug.py
from forecastiopy import *
import time
YOUR_API_KEY = open("FORECASTIO_API_KEY.txt").read().strip()
location=[25.5, -83.566667]
fio = ForecastIO.ForecastIO(YOUR_API_KEY, latitude=location[0], longitude=location[1])
d = FIODaily.FIODaily(fio)
print(time.ctime(d.day_1_time))
print(time.ctime(d.day_2_time))
print(time.ctime(d.day_3_time))
print(time.ctime(d.day_4_time))
print(time.ctime(d.day_5_time))
print(time.ctime(d.day_6_time))
print(time.ctime(d.day_7_time))
print(time.ctime(d.day_8_time))
output:
$ python daily_cycle_bug.py
Mon Sep 5 00:00:00 2016
Mon Aug 29 00:00:00 2016
Tue Aug 30 00:00:00 2016
Wed Aug 31 00:00:00 2016
Thu Sep 1 00:00:00 2016
Fri Sep 2 00:00:00 2016
Sat Sep 3 00:00:00 2016
Sun Sep 4 00:00:00 2016
No attribute 'forecast' inside ForecastIO
Traceback (most recent call last):
File "/home/olaf/.local/lib/python2.7/site-packages/flask/app.py", line 2000, in __call__
return self.wsgi_app(environ, start_response)
File "/home/olaf/.local/lib/python2.7/site-packages/flask/app.py", line 1991, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/home/olaf/.local/lib/python2.7/site-packages/flask/app.py", line 1567, in handle_exception
reraise(exc_type, exc_value, tb)
File "/home/olaf/.local/lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/home/olaf/.local/lib/python2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/olaf/.local/lib/python2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/olaf/.local/lib/python2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/home/olaf/.local/lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/home/olaf/Hackathons/Brumhack5/BrumHack5/jasien.py", line 49, in checkStuff
weatherResult = getWeather(message_body_split[1])
File "/home/olaf/Hackathons/Brumhack5/BrumHack5/jasien.py", line 26, in getWeather
current = FIOCurrently.FIOCurrently(fio)
File "/usr/local/lib/python2.7/dist-packages/forecastiopy/FIOCurrently.py", line 25, in __init__
if forecast_io.has_currently():
File "/usr/local/lib/python2.7/dist-packages/forecastiopy/ForecastIO.py", line 185, in has_currently
return 'currently' in self.forecast
AttributeError: 'ForecastIO' object has no attribute 'forecast'
Replace print calls with logging module
Thanks for this library and your efforts! 👍
Looking into your source code, I would kindly suggest to replace all print calls with Python's logging module for the following reasons:
- Easier to configure
- Easier to test
- Python's logging module allows to have different receivers for logging output (by stdout, mail, etc.)
- Separates error messages from debug or information messages
- Separates normal output for the user with logging output. Each serves different purposes.
Your code uses print a lot. For example, in file ForecastIO.py, there are a couple of prints. IMHO, I see the following problems with this approach:
- Error messages should always go to stderr, never to stdout. If they go to stdout, they mix with "normal" messages for the user. It's hard or impossible to redirect error message into a file, for example.
- If you really have to use
print, redirect your output to stderr like this:print("error:", err, file=sys.stderr)
So better use logging.error instead of print as stated above. 😄
FIOAlerts returns list, everything else returns a usable dict
Python3 Compatibility
xrange needs to move to range for python3. #7
time machine
Are you planning to implement a time-machine request of the API?
Thanks,
3.
Invalid API keys should be an exception
>>> fio = ForecastIO.ForecastIO("fds", latitude=83.6906, longitude=-39.4176)
The API Key doesn't seam to be valid.
>>> fio
<forecastiopy.ForecastIO.ForecastIO object at 0x7f573b300940>
>>> FIODaily.FIODaily(fio)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/kousu/.local/lib/python3.4/site-packages/forecastiopy-0.1-py3.4.egg/forecastiopy/FIODaily.py", line 20, in __init__
if forecast_io.has_daily():
File "/home/kousu/.local/lib/python3.4/site-packages/forecastiopy-0.1-py3.4.egg/forecastiopy/ForecastIO.py", line 204, in has_daily
return 'daily' in self.forecast
AttributeError: 'ForecastIO' object has no attribute 'forecast'
The real mistake here is that the API key is wrong, but the exception that actually crashes is obscure and makes it seem like maybe there's a library version mismatch or something else frustratingly impossible to fix. I wrote a largish script, ported it to a new host, and accidentally misimported my API key, so I didn't notice the first message and was focusing on the second exception.
Would you make that initial line into an exception instead of just a print?
Exclude List ?
I'm trying to exclude daily,alerts etc and can't seem to get the syntax correct.
I've tried: excludeList = ['daily,alerts,flags'] and this excludeList = 'daily,alerts,flags'
and
fio = ForecastIO.ForecastIO(apikey,exclude=excludeList,
units=ForecastIO.ForecastIO.UNITS_US,
lang=ForecastIO.ForecastIO.LANG_ENGLISH,
latitude=Prado[0], longitude=Prado[1])
and this
fio = ForecastIO.ForecastIO(apikey,
units=ForecastIO.ForecastIO.UNITS_US,
lang=ForecastIO.ForecastIO.LANG_ENGLISH,
latitude=Prado[0], longitude=Prado[1],
exclude=excludeList )
The results are always
https://api.darksky.net/forecast/apikey/lattitude,longittude?units=us&lang=en
Appreciate your help
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.