dvdagames / js-die-roller Goto Github PK

Roller should support functions whose parameters are nested functions, like in the following example used to generate a character's ability scores for D&D 5e:

drop(sum(drop(4d6)), sum(drop(4d6)), sum(drop(4d6)), sum(drop(4d6)), sum(drop(4d6)), sum(drop(4d6)), sum(drop(4d6)))

See if we can leverage an Abstract Syntax Tree for parsing the die notation instead of having to rely on RegEx and eval()ing.

There's too much variability to when it returns an Array or a nested Array or an integer in the results field.

There should be some more consistency.

Maybe always stick to an Array for the results and have a computedResults that does any addition of modifiers?

4d6 is different from 4d6+4 which is different from sum(4d6).

It might be nice to rely on explicitly requiring a sum() call if you want to automatically the rolls together in case users want to verify the actual die rolls instead of just seeing the sum, but we also store the relevant roll data in the rolls array, so maybe reducing to a single number is best?

Or maybe it should be clearly defined when to expect an Array and when to expect a number?

Currently there are issues with function parsing when nested functions are present.