duncanc / icu4lua Goto Github PK

I'm trying to port it over at https://gitlab.com/raingloom/icu4lua/ but I'm having trouble with the linker.

Any chance of getting this packaged for LuaRocks?

Inside: static int icu_utf8_char(lua_State *L)
at:

the test is incorrect:

       else if (codePoint > 0x110000) {
            return luaL_argerror(L,i+1,"invalid codepoint");
        }
        else {
            // 00000000 000zzzzz yyyyyyyy xxxxxxxx
            // 11110zzz 10zzyyyy 10yyyyxx 10xxxxxx
            ...

It seems you have reversed the original test that was

       else if (codePoint < 0x110000) {
            // 00000000 000zzzzz yyyyyyyy xxxxxxxx
            // 11110zzz 10zzyyyy 10yyyyxx 10xxxxxx
            ...
        }
        else {
            return luaL_argerror(L,i+1,"invalid codepoint");
        }

But you forgot the equal sign! So the code point 0x110000 is accepted as if it was valid and will generate a non-standard UTF-8 sequence (0xF8,0x80,0x80,0x80): the bytes 0xC0, 0xC1, and 0xF8 to 0xFF are NEVER part of any valid UTF-8 text.

Hello, @duncanc
We would like to use icu4lua in our project. Though we need versions to be declared explicitly for 3rd-party libraries.
Would you mind adding version tag for at least last commit?